[openAD] #262: function2subroutine - incorrect hoisting of variables
#262: function2subroutine - incorrect hoisting of variables ------------------------------+--------------------------------------------- Reporter: utke | Owner: utke Type: defect | Status: new Priority: major | Milestone: AD for SAS Component: SourceProcessing | Keywords: ------------------------------+--------------------------------------------- -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/262> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#262: function2subroutine - incorrect hoisting of variables ------------------------------+--------------------------------------------- Reporter: utke | Owner: utke Type: defect | Status: accepted Priority: major | Milestone: AD for SAS Component: SourceProcessing | Keywords: ------------------------------+--------------------------------------------- Changes (by utke): * status: new => accepted Comment: arguments of functions with side effects can only be hoisted of the value is copied back but for simplicity they should not be hoisted to begin with. -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/262#comment:1> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#262: function2subroutine - incorrect hoisting of arguments ------------------------------+--------------------------------------------- Reporter: utke | Owner: utke Type: defect | Status: accepted Priority: major | Milestone: AD for SAS Component: SourceProcessing | Keywords: ------------------------------+--------------------------------------------- -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/262#comment:2> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#262: function2subroutine - incorrect hoisting of arguments ------------------------------+--------------------------------------------- Reporter: utke | Owner: hlcm Type: defect | Status: assigned Priority: major | Milestone: AD for SAS Component: SourceProcessing | Keywords: ------------------------------+--------------------------------------------- Changes (by utke): * owner: utke => hlcm * status: accepted => assigned -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/262#comment:3> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#262: function2subroutine - incorrect hoisting of arguments ------------------------------+--------------------------------------------- Reporter: utke | Owner: hlcm Type: defect | Status: assigned Priority: major | Milestone: AD for SAS Component: SourceProcessing | Keywords: ------------------------------+--------------------------------------------- Comment(by utke): fix with http://mercurial.mcs.anl.gov/ad/SourceProcessing/rev/b187116672a7 is partial because it doesn't cover Apps that are array refs. -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/262#comment:4> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#262: function2subroutine - incorrect hoisting of arguments ------------------------------+--------------------------------------------- Reporter: utke | Owner: hlcm Type: defect | Status: assigned Priority: major | Milestone: AD for SAS Component: SourceProcessing | Keywords: ------------------------------+--------------------------------------------- Comment(by utke): Replying to [comment:4 utke]:
fix with http://mercurial.mcs.anl.gov/ad/SourceProcessing/rev/b187116672a7 is partial because it doesn't cover Apps that are array refs. Also this now leaves constants in place which should be hoisted for reverse mode.
-- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/262#comment:5> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#262: function2subroutine - incorrect hoisting of arguments ------------------------------+--------------------------------------------- Reporter: utke | Owner: hlcm Type: defect | Status: assigned Priority: major | Milestone: AD for SAS Component: SourceProcessing | Keywords: ------------------------------+--------------------------------------------- Comment(by utke): rewrote tests, see http://mercurial.mcs.anl.gov/ad/SourceProcessing/rev/3a01d69ab2ef http://mercurial.mcs.anl.gov/ad/SourceProcessing/rev/e640b8ec14d7 reference output changed first with http://mercurial.mcs.anl.gov/ad/RegressionSourceProcessing/rev/f2560183f660 but needed to retrigger the inference logic so changed the test cases again: http://mercurial.mcs.anl.gov/ad/RegressionSourceProcessing/rev/d628bec6a615 -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/262#comment:6> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#262: function2subroutine - incorrect hoisting of arguments ------------------------------+--------------------------------------------- Reporter: utke | Owner: hlcm Type: defect | Status: closed Priority: major | Milestone: AD for SAS Component: SourceProcessing | Resolution: fixed Keywords: | ------------------------------+--------------------------------------------- Changes (by hlcm): * status: assigned => closed * resolution: => fixed Comment: fixed with http://mercurial.mcs.anl.gov/ad/SourceProcessing/rev/e640b8ec14d7 -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/262#comment:7> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
participants (1)
-
OpenAD