[openAD] #220: COMMON block symbol reference ambiguity in whirl
#220: COMMON block symbol reference ambiguity in whirl --------------------------+------------------------------------------------- Reporter: utke | Owner: utke Type: defect | Status: new Priority: major | Milestone: Component: OpenADFortTk | Keywords: --------------------------+------------------------------------------------- for the following situation: subroutine foo () common /g/ v ... call bar() end subroutine subroutine bar() common /g/ v/ ... end subroutine the global whirl symbol table has 2 entries for 'v' (and also 'g'), one for each PU in which v is used. The association is done via the base ST of 'v' first to its corresponding 'g' and then that one's corresponding base symbol is either 'bar' or 'foo'. Normally the uses of the different incarnations do not overlap. However, the side effect analysis reports cumulative side effects in "foo" including sideeffects of 'bar' on bar's version of 'v' such that in foo now implicitly separate references occur (for checkpointing code) of both 'v' instance and that in turn leads to a duplication of the common block declaration in the unparser because there is no logic that can turn bar::v into the equivalent foo::v to avoid the bogus reference. This will have to be fixed either in OpenADFortTk or in whirl2f. -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/220> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#220: COMMON block symbol reference ambiguity in whirl --------------------------+------------------------------------------------- Reporter: utke | Owner: utke Type: defect | Status: accepted Priority: major | Milestone: Component: OpenADFortTk | Keywords: --------------------------+------------------------------------------------- Changes (by utke): * cc: malexe@… (added) * status: new => accepted -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/220#comment:1> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#220: COMMON block symbol reference ambiguity in whirl --------------------------+------------------------------------------------- Reporter: utke | Owner: utke Type: defect | Status: accepted Priority: major | Milestone: Component: OpenADFortTk | Keywords: --------------------------+------------------------------------------------- Comment(by utke): commited 3096d631c77c in the current branch held at /homes/utke/HG_Branch/Init/OpenADFortTk seems to fix the problem with implicitTypeCB but testing is not complete -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/220#comment:2> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#220: COMMON block symbol reference ambiguity in whirl --------------------------+------------------------------------------------- Reporter: utke | Owner: utke Type: defect | Status: accepted Priority: major | Milestone: Component: OpenADFortTk | Keywords: --------------------------+------------------------------------------------- Comment(by utke): Replying to [comment:2 utke]:
commited 3096d631c77c in the current branch held at /homes/utke/HG_Branch/Init/OpenADFortTk
seems to fix the problem with implicitTypeCB but testing is not complete Not quite if the common block isn't in the PU to begin with. Needed another fix done with f34f9682c472 and also added a test case Regression/testRoundTrip/examples/cbSideEffects added with 68efbf8c56a3
-- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/220#comment:3> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#220: COMMON block symbol reference ambiguity in whirl --------------------------+------------------------------------------------- Reporter: utke | Owner: utke Type: defect | Status: accepted Priority: major | Milestone: Component: OpenADFortTk | Keywords: --------------------------+------------------------------------------------- Comment(by utke): Replying to [comment:3 utke]:
Replying to [comment:2 utke]:
commited 3096d631c77c in the current branch held at /homes/utke/HG_Branch/Init/OpenADFortTk
seems to fix the problem with implicitTypeCB but testing is not complete Not quite if the common block isn't in the PU to begin with. Needed another fix done with f34f9682c472 and also added a test case Regression/testRoundTrip/examples/cbSideEffects added with 68efbf8c56a3 there was a bug in the lookup argument; fixed with dfdfe21bb0f9
-- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/220#comment:4> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
#220: COMMON block symbol reference ambiguity in whirl ----------------------------+----------------------------------------------- Reporter: utke | Owner: utke Type: defect | Status: closed Priority: major | Milestone: Component: Open64 whirl2f | Resolution: fixed Keywords: | ----------------------------+----------------------------------------------- Changes (by utke): * status: accepted => closed * resolution: => fixed * component: OpenADFortTk => Open64 whirl2f Comment: fixed in whirl2f -- Ticket URL: <https://trac.mcs.anl.gov/projects/openAD/ticket/220#comment:5> OpenAD <http://www.mcs.anl.gov/openad> Bug tracking for OpenAD components
participants (1)
-
OpenAD