On Feb 27, 2014, at 1:46 PM, "Latham, Robert J." <[email protected]> wrote:

On Thu, 2014-02-27 at 19:32 +0000, Dave Goodell (dgoodell) wrote:

...

I saw this fly by and a bug caught the corner of my eye (see inline)

...

...

+ # If the program linked OK, make sure there were no warnings - if test "$prog_links" = "yes" -a "`cat pac_test.log`" = "" ; then + if test "$prog_links" = "yes" -a "`diff pac_test1.log pac_test2.log`" = "" ; then AC_DEFINE([HAVE_MACRO_VA_ARGS],[1],[Define if C99-style variable argument list macro functionality]) AC_MSG_RESULT([yes]) + elif "`diff pac_test1.log pac_test2.log`" = "" ; then

This is bad shell code. You probably want "elif test" instead.

Or let autoconf worry about it for you with AS_IF

You still need the "test" in that case... -Dave