Hi, The existing, but non working, function is called PetscOptionsInsertFile_YAML. I just kept its name without checking the petsc developer style guide. My mistake. The attached patch fixes this issue. Blaise
Home come there is an _ before the YAML in the function name? We put in _ in function names for private functions and generally user called public functions (like this) would not have that.
Barry
On Aug 7, 2012, at 9:29 AM, Blaise Bourdin <[email protected]> wrote:
Hi,
My YAML patch did not exactly raise much enthusiasm so I tried to clean it up a bit... The attached patch is another attempt at providing partial support for parsing YAML files: -options_file_yaml now works from C and fortran. It's logic was changed so that it does not require reinserting the whole option string. Aliases and sequences are still not supported.
Is this patch worth being pushed to petsc-dev and petsc-3.3?
Blaise
<PetscOptionsInsertFile_YAML.patch> -- Department of Mathematics and Center for Computation & Technology Louisiana State University, Baton Rouge, LA 70803, USA Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin
-- Department of Mathematics and Center for Computation & Technology Louisiana State University, Baton Rouge, LA 70803, USA Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin
participants (1)
-
Blaise Bourdin