Re: [petsc-dev] Patches like this make me want to cry
On Thu, Jun 28, 2012 at 2:24 PM, Paul Mullowney <[email protected]> wrote:
VecTransplantPlaceArray
This thing is way too big to review, includes huge swaths of commented-out code, breaks coding conventions and portability, and introduces strange new APIs (like VecTransplantPlaceArray) that haven't really been explained and seem to produce questionable semantics.
Why is the non-portable?
It assumes C99 to begin with.
I asked for your input on this 2 days ago?
Sorry, I'm at a conference, finishing a proposal, and trying to make progress on my research. I was hoping someone else would comment because I think it's leaking implementation details. Also, you didn't provide the whole patch series to comment on, just some bits of code.
This is non-portable:
Can we please institute some sort of policy on patch quality/reviewability? This one patch is going to take a significant amount of fix-up (not made easier by the several merges since) and/or generate several build failures and user inconvenience (petsc-maints). No doubt the functionality is important, but we just don't have time to fix these things line-by-line after they are pushed.
participants (1)
-
Jed Brown