Re: [petsc-dev] Unneeded check in TSSetUp?
On Tue, 11 Dec 2018 at 07:47, Stefano Zampini via petsc-dev < [email protected]> wrote:
Yes, I have also noticed it. IMHO, we should enforce the TSGetDM + DMCreateGlobalVector pattern instead of duplicating ts->vec_sol in all the implementations. I'll open a bitbucket issue if you agree
As long as you do not break third party code that do not set a DM on TS, I would not object. Otherwise, I'll replace the sugar in your desk with salt, so you can have a really tasty afternoon coffee. -- Lisandro Dalcin ============ Research Scientist Computer, Electrical and Mathematical Sciences & Engineering (CEMSE) Extreme Computing Research Center (ECRC) King Abdullah University of Science and Technology (KAUST) http://ecrc.kaust.edu.sa/ 4700 King Abdullah University of Science and Technology al-Khawarizmi Bldg (Bldg 1), Office # 0109 Thuwal 23955-6900, Kingdom of Saudi Arabia http://www.kaust.edu.sa Office Phone: +966 12 808-0459
participants (1)
-
Lisandro Dalcin