Gautam Bisht <[email protected]> writes:

Hi Jed,

Earlier I completely missed your point. I believe the utility of SNESSetFunctionDomainError is that an application can determine if the state (xx) being passed to compute residual function is meaningful (eg. a pair of (P,T) could result in negative density). If the state is not meaningful, the application could simply call SNESSetFunctionDomainError() and not update the residual vector. This would cause SNES to exit with SNES_DIVERGED_FUNCTION_DOMAIN.

Yes.

Looking at PFLOTRAN code more carefully, I now realize that Peter is using SNESSetFunctionDomainError() in FLASH2/MPHASE/MISCIBLE/IMMISCIBLE modes. I will now implement similar check for TH mode.

Great.