On Fri, Mar 22, 2013 at 10:14 AM, Mark F. Adams <[email protected]>wrote:

I thought the primary mission of options_left was to catch spelling mistakes.

(This is also useful if a PC logically ought to pay attention to this option, but isn't.) What about making PCSetUseAmat() use PetscTryMethod() and move the check of "-pc_use_amat" into each implementation?

I agree with Barry that it should be high level and make it there for any PC to use if they want.

Do we really want to leave the confusing option in place for all the PCs that don't have inner solvers?

It just doesn't seem that bad to me.

Okay, okay, I'll stick with the simple thing. What about "-pc_reuse"? It is only referenced in src/ksp/pc/impls/factor/lu/lu.c and it doesn't have an API. Can it be removed entirely? I thought we were using SAME_PRECONDITIONER for this sort of thing.