i'd ask them if there is a XL compiler reason for the macro moves. the ADIOI_Asserts are fine with me. don't care about the fprintfs. rob On Jul 3, 2008, at 9:46 AM, Robert Latham wrote:
On Thu, Jul 03, 2008 at 09:34:17AM -0500, Rob Ross wrote:
what sort of code rearranging? -- rob
Aside from the casts, there are two major things the IBM patches do:
- additional and slightly mpich2-specific debugging code DBG_FPRINTF and ADIOI_Assert added to many many places
- In several places (ADIOI_GEN_ReadStrided, ADIOI_GEN_WriteStrided, ADIOI_Fill_user_buffer) they moved the macro definitions (things like ADIOI_BUF_INCR and ADIOI_BUFFERED_READ) inside the function. Maybe this makes xl compilers happier?
==rob
-- Rob Latham Mathematics and Computer Science Division A215 0178 EA2D B059 8CDF Argonne National Lab, IL USA B29D F333 664A 4280 315B