I have reviewed my two patches and attached my comments. Lots of the code is BG-specific and generally unusable. Of the 47 files patched, 22 of them pass muster while the remaining 25 should either be thrown out or otherwise modified. IBM doesn't seem to have their MPI_Aint story straight internally, since there are several changes that they made where they assume that sizeof(MPI_Aint)==sizeof(int) or sizeof(MPI_Aint)==sizeof(long). Also, they seem to have omitted several new files, such as wtimef90.f90 and all of the IO-node tests. -Dave On Fri, May 02, 2008 at 03:11:11AM -0500, Pavan Balaji wrote:
Hi all,
Sorry about the delay in sending out the BG/P patches. I've placed them here: http://www.mcs.anl.gov/~balaji/projects/mpich2/bgp/r2. I've assigned a few patches to each person below. Can the below folks please confirm that you can go over them and make sure there are no problems integrating them into the trunk? The plan is to go over these and have a telecon around mid next week.
The IBM folks didn't do a very good job in breaking up the diffs, so some of the patches are large; you'll probably need to break them up and try different parts separately.
build.patch -- Bill datatype.patch -- Pavan dcmfd.patch -- Pavan debugger.patch -- Darius ignore.patch -- Pavan mpe.patch -- Anthony other.patch -- Rajeev test-build.patch -- Dave test-source.patch -- Dave
A few things I noticed on a quick glance through the patches:
1. MPI_Aint vs. (void *). I remember that there was some discussion, but what was the conclusion? Can MPI_Aint be larger than (void *)? A large chunk of the patches assumes that these two can be different, so they introduce MPI_AINT_TO_VOID_PTR and friends to deal with such cases.
2. Some of the patches (e.g., debugger.patch, test-build.patch and test-source.patch) have a number of BG specific additions. These need to be pruned out in a way that IBM can still use it, but they will continue to be generic enough for other platforms.
Thanks.
-- Pavan
-- Pavan Balaji http://www.mcs.anl.gov/~balaji