This has been introduced in f42deef95efdb32c74e20b044efbd18de6bff042. That commit also broke another feature that I find very useful, which is to rerun only the failed tests. Now, the echofailures.sh file is no longer updated unless we do full testing. Can we please revert that commit? Il giorno mer 20 gen 2021 alle ore 14:11 Stefano Zampini < [email protected]> ha scritto:
This is an issue with the default shell used by the makefile. Below is my fix. We should probably have a CI machine that checks for these shell-related errors.
diff --git a/gmakefile.test b/gmakefile.test index c38e37f..ffd7bdb 100644 --- a/gmakefile.test +++ b/gmakefile.test @@ -379,10 +379,11 @@ starttime: pre-clean $(libpetscall) @$(eval STARTTIME := $(shell date +%s))
report_tests: starttime $(TESTTARGETS) +ifeq ($(showreport),true) @$(eval ENDTIME := $(shell date +%s)) - -@if test ${showreport} == "true"; then elapsed_time=$$(($(ENDTIME)- $(STARTTIME))) && \ - $(PYTHON) $(CONFIGDIR)/report_tests.py -m $(MAKE) -d $(TESTDIR)/counts -t 5 -e $${elapsed_time};\ - fi + elapsed_time=$$(($(ENDTIME)- $(STARTTIME))) && \ + $(PYTHON) $(CONFIGDIR)/report_tests.py -m $(MAKE) -d $(TESTDIR)/counts -t 5 -e $${elapsed_time}; +endif
Il giorno mar 19 gen 2021 alle ore 20:41 Scott Kruger <[email protected]> ha scritto:
I can't reproduce this with the latest master:
hip 1261: git pull Already up to date. hip 1262: make -f gmakefile.test test search='notatest' Using MAKEFLAGS: -- search=notatest hip 1263:
On 1/19/21 8:19 AM, Stefano Zampini wrote:
Just rebased over latest master and got this
zampins@vulture:~/Devel/petsc$ make -f gmakefile.test test search='notatest' Using MAKEFLAGS: -- search=notatest /bin/sh: 1: test: false: unexpected operator
-- Stefano
-- Tech-X Corporation [email protected] 5621 Arapahoe Ave, Suite A Phone: (720) 466-3196 Boulder, CO 80303 Fax: (303) 448-7756
-- Stefano
-- Stefano