August 2015 - petsc-dev - mailman3.cels.anl.gov

Re: [petsc-dev] [petsc-checkbuilds] PETSc blame digest (next) 2015-08-31
by Barry Smith 31 Aug '15

31 Aug '15

Karl, I'll fix this, I broke it. > On Aug 31, 2015, at 9:00 AM, PETSc checkBuilds <petsc-checkbuilds(a)mcs.anl.gov> wrote: > > > > Dear PETSc developer, > > This email contains listings of contributions attributed to you by > `git blame` that caused compiler errors or warnings in PETSc automated > testing. Follow the links to see the full log files. Please attempt to fix > the issues promptly or let us know at petsc-dev(a)mcs.anl.gov if you are unable > to resolve the issues. > > Thanks, > The PETSc development team > > ---- > > warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/1aa2665 > Uncrustified parts of src/snes/* > > src/snes/examples/tutorials/ex48.c:186 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:186: error: 'dz' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:186: error: 'dz' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:186: error: 'dz' was not declared in this scope > > ---- > To opt-out from receiving these messages - send a request to petsc-dev(a)mcs.anl.gov.

1 0

Re: [petsc-dev] [petsc-checkbuilds] PETSc blame digest (next) 2015-08-31
by Barry Smith 31 Aug '15

31 Aug '15

Jed, I'll fix this, I broke it. Barry > On Aug 31, 2015, at 9:00 AM, PETSc checkBuilds <petsc-checkbuilds(a)mcs.anl.gov> wrote: > > > > Dear PETSc developer, > > This email contains listings of contributions attributed to you by > `git blame` that caused compiler errors or warnings in PETSc automated > testing. Follow the links to see the full log files. Please attempt to fix > the issues promptly or let us know at petsc-dev(a)mcs.anl.gov if you are unable > to resolve the issues. > > Thanks, > The PETSc development team > > ---- > > warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/28c2760 > Add example multigrid solver for hydrostatic ice sheet flow > > src/snes/examples/tutorials/ex48.c:171 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-3/src/snes/examples/tutorials/ex48.c:171:20: warning: 'PetscScalar Sqr(PetscScalar)' defined but not used [-Wunused-function] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:171:20: warning: 'PetscScalar Sqr(PetscScalar)' defined but not used [-Wunused-function] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:171:20: warning: 'PetscScalar Sqr(PetscScalar)' defined but not used [-Wunused-function] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:171:20: warning: 'PetscScalar Sqr(PetscScalar)' defined but not used [-Wunused-function] > > src/snes/examples/tutorials/ex48.c:173 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-3/src/snes/examples/tutorials/ex48.c:173:13: warning: 'void HexGrad(const PetscReal (*)[3], const PetscReal*, PetscReal*)' defined but not used [-Wunused-function] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:173:13: warning: 'void HexGrad(const PetscReal (*)[3], const PetscReal*, PetscReal*)' defined but not used [-Wunused-function] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:173:13: warning: 'void HexGrad(const PetscReal (*)[3], const PetscReal*, PetscReal*)' defined but not used [-Wunused-function] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:173:13: warning: 'void HexGrad(const PetscReal (*)[3], const PetscReal*, PetscReal*)' defined but not used [-Wunused-function] > > src/snes/examples/tutorials/ex48.c:193 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:193: error: 'phi' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:193: error: 'phi' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:193: error: 'phi' was not declared in this scope > > src/snes/examples/tutorials/ex48.c:194 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:194: error: 'dphi' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:194: error: 'dphi' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:194: error: 'dphi' was not declared in this scope > > src/snes/examples/tutorials/ex48.c:198 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:198: error: 'jw' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:198: error: 'jw' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:198: error: 'jw' was not declared in this scope > > src/snes/examples/tutorials/ex48.c:728 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:728: error: 'du' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:728: error: 'du' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:728: error: 'du' was not declared in this scope > > src/snes/examples/tutorials/ex48.c:729 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:729: error: 'dv' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:729: error: 'dv' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:729: error: 'dv' was not declared in this scope > > src/snes/examples/tutorials/ex48.c:730 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:730: error: 'u' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:730: error: 'u' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:730: error: 'u' was not declared in this scope > > src/snes/examples/tutorials/ex48.c:731 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:731: error: 'v' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:731: error: 'v' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:731: error: 'v' was not declared in this scope > > src/snes/examples/tutorials/ex48.c:733 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:733: error: 'phi' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:733: error: 'n' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:733: error: 'n' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:733: error: 'n' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:733: error: 'phi' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:733: error: 'phi' was not declared in this scope > > src/snes/examples/tutorials/ex48.c:736 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:736: error: 'dphi' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:736: error: 'dphi' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:736: error: 'dphi' was not declared in this scope > > src/snes/examples/tutorials/ex48.c:741 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:741: error: 'eta' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:741: error: 'deta' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:741: error: 'deta' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:741: error: 'deta' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:741: error: 'eta' was not declared in this scope > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:741: error: 'eta' was not declared in this scope > > src/snes/examples/tutorials/ex48.c:78 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:78:21: warning: 'THI_CLASSID' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:78:21: warning: 'THI_CLASSID' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:78:21: warning: 'THI_CLASSID' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-3/src/snes/examples/tutorials/ex48.c:78:21: warning: 'THI_CLASSID' defined but not used [-Wunused-variable] > > src/snes/examples/tutorials/ex48.c:81 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:81:25: warning: 'QuadratureTypes' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:81:25: warning: 'QuadratureTypes' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:81:25: warning: 'QuadratureTypes' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-3/src/snes/examples/tutorials/ex48.c:81:25: warning: 'QuadratureTypes' defined but not used [-Wunused-variable] > > src/snes/examples/tutorials/ex48.c:810 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:810: error: at this point in file > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:810: error: at this point in file > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:810: error: at this point in file > > src/snes/examples/tutorials/ex48.c:811 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:811: error: at this point in file > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:811: error: at this point in file > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:811: error: at this point in file > > ---- > > warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/7bd1777 > snes ex48: Add option for standard Gauss quadrature > > src/snes/examples/tutorials/ex48.c:1109 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-2/src/snes/examples/tutorials/ex48.c:1109: error: at this point in file > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex48.c:1109: error: at this point in file > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /Users/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:1109: error: at this point in file > > src/snes/examples/tutorials/ex48.c:125 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:125:26: warning: 'HexQInterp' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:125:43: warning: 'HexQDeriv' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex48.c:125:43: warning: 'HexQDeriv' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:125:26: warning: 'HexQInterp' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-3/src/snes/examples/tutorials/ex48.c:125:43: warning: 'HexQDeriv' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /home/balay/petsc.clone-3/src/snes/examples/tutorials/ex48.c:125:26: warning: 'HexQInterp' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:125:43: warning: 'HexQDeriv' defined but not used [-Wunused-variable] > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/08/31/examples_ne…] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex48.c:125:26: warning: 'HexQInterp' defined but not used [-Wunused-variable] > > ---- > To opt-out from receiving these messages - send a request to petsc-dev(a)mcs.anl.gov.

1 0

For those who care about such things...
by Matthew Knepley 30 Aug '15

30 Aug '15

>From C.T. Kelley *Iterative Methods for Linear and Nonlinear Equations*, p.66, In this section we analyze convergence of fixed-point iteration, which is given by x_{n+1} = K(x_n) This iterative method is also called nonlinear Richardson iteration, Picard iteration, or the method of successive substitution. Matt -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener

1 0

Re: [petsc-dev] bullshit in Plex example under complex
by Barry Smith 29 Aug '15

29 Aug '15

> On Aug 29, 2015, at 6:13 PM, Tobin Isaac <tisaac(a)ices.utexas.edu> wrote: > > On Sat, Aug 29, 2015 at 05:53:22PM -0500, Barry Smith wrote: >> >>> On Aug 29, 2015, at 5:47 PM, Jed Brown <jed(a)jedbrown.org> wrote: >>> >>> Tobin Isaac <tisaac(a)ices.utexas.edu> writes: >>>> How am I supposed to add a test to the intersection of a package >>>> (testexamples_TRIANGLE) and a scalar type (testexamples_C_NoComplex). >>>> It's pretty frustrating, given how obvious this would be with >>>> something like sharness [1], that I couldn't easily figure this out. >>> >>> I've used sharness a reasonable amount and generally like it, especially >>> when paired with "prove". A couple years ago, I did some exploratory >>> work to parse PETSc makefile tests and generate sharness-style tests. I >>> still don't think it's a bad idea and might yet be able to get back to >> >> It seems to require a lot of boilerplate for each test. I sure as heck hope we don't have to write that by hand for each test. > > Really? Compare sharness in hpgmpg [1] to PETSc, keeping in mind that > the .out files in PETSc-parlance are incorporated into the test > script. Every test in PETSc (a) writes out the command line in full, > (b) diff's against the expected output, (c) writes out the "Possible > problem" message, and (d) removes the temporary files. If sharness > can meet PETSc's portability needs, that would strike me as a good > reduction in boiler plate. I never said the current system doesn't have boilerplate! It absolutely does, all I am saying is that a replacement should not have any. A replacement has to be fundamentally better than the current model, not just a bit better. For example the MORONs who switch from GNU autoconf to cmake (out of the frying pan into the fire). Barry > > Toby > > [1] https://bitbucket.org/hpgmg/hpgmg/src/26f74a2120cefc078b9b855297b77bf8d62ff… > >> >> I'm not a fan of the "parse the PETSc makefiles approach"; I think we need to define a standard format for declaring tests that is very concise (only exactly what is needed; I have one try in a branch somewhere). Then we can have code that translates from the standard format to anything people want to try with testing scripts. I am even willing to manually convert makefile crap to this format when necessary >> >> Barry >> >>> it. >>

1 0

Re: [petsc-dev] bullshit in Plex example under complex
by Barry Smith 29 Aug '15

29 Aug '15

> On Aug 29, 2015, at 6:11 PM, Jed Brown <jed(a)jedbrown.org> wrote: > > Barry Smith <bsmith(a)mcs.anl.gov> writes: >> It seems to require a lot of boilerplate for each test. I sure as heck hope we don't have to write that by hand for each test. > > Here is an example: > > $ cat src/hpgmg/finite-element/test/t230-fmg-poisson2.sh > #!/bin/sh > > test_description='Test Q2 Poisson solve using FMG' Hmm, the example code already says what it does. Repeating it here is annoying > > . ./hpgmg-sharness.sh > > # Error norm is converging at fourth order (superconvergent at Lagrange nodes) Again the example should really be providing this information, not test code > test_expect_stdout 'FE Poisson FMG solve fedegree=2 serial' 1 'hpgmg-fe fmg -op_type poisson2 -M 4,4,6 -smooth 4,3' ' > F(4,3) 0: |e|_2/|u|_2 9.08e-03 |r|_2/|f|_2 3.35e-04 > V(4,3) 1: |e|_2/|u|_2 9.17e-03 |r|_2/|f|_2 8.27e-07 > V(4,3) 2: |e|_2/|u|_2 9.17e-03 |r|_2/|f|_2 5.54e-09 Input arguments, out expected, fine. How are you indicating when what tests can be done. For example requires MUMPS, triangle and double precision. Or runs with all precisions both complex and real. etc etc. > ' > > test_expect_stdout 'FE Poisson FMG solve fedegree=2 parallel' 4 'hpgmg-fe fmg -op_type poisson2 -M 4,4,6 -smooth 4,3 -p 1,2,2' ' > F(4,3) 0: |e|_2/|u|_2 9.08e-03 |r|_2/|f|_2 3.35e-04 > V(4,3) 1: |e|_2/|u|_2 9.17e-03 |r|_2/|f|_2 8.27e-07 > V(4,3) 2: |e|_2/|u|_2 9.17e-03 |r|_2/|f|_2 5.54e-09 > ' > > test_done > > > Since I have quite short output here, the test output is inline. > >> I'm not a fan of the "parse the PETSc makefiles approach"; I think we need to define a standard format for declaring tests that is very concise (only exactly what is needed; I have one try in a branch somewhere). Then we can have code that translates from the standard format to anything people want to try with testing scripts. I am even willing to manually convert makefile crap to this format when necessary > > My "parse the makefiles" was intended to automate the conversion to a > more concise format that a (hopefully sane) test system can use > directly. I'm not wild about introducing extra translation phases > because it makes the testing system more difficult to understand and > exposes more possible failure modes. Even if we decided to use the sharness format we still need to write a parser so we can process the input files to see what we are testing and what we are not testing, generate tables of functionality tested etc. So I am very much opposed to picking one particular testers format and using that. We need our own format and then SIMPLE tools to translate to various testers. I agree the format must be simple and the tools that translate simple so we are not stuck in a morass of broken tester > > FWIW, we could greatly simplify the makefiles by having each target > simply call a script that runs the actual program, collects stdout and > stderr and exit codes, and outputs the test result in a standard format > (e.g., TAP). I.e., move the repetitive shell code we have now in each > target into a single script used for all tests. This script could also > have an argument containing restrictions (NoComplex, etc.) so that it > can determine when to skip. Moreover, it can sandbox the execution to a > temporary directory and clean up after it. As I see it, this is > basically equivalent to moving the tests into a sharness-type system or > similar. > > In my opinion, one crucial component in a revamped testing system is to > enable parallel execution with a maximum number of processes (perhaps > exceeded when a single job needs more than that, but definitely not > otherwise). Sure. Almost all our tests, in theory, can be run in any order or at the same time. > Sharness is really nice for tests that replicate a session > where the state is tested as various checkpoints along the way. We have > a few of these (e.g., creating and reading files), but most of our tests > are independent, which maps to sharness as independent test scripts. > One file per test is actually the best case for merging, but can be > cumbersome otherwise.

1 0

Re: [petsc-dev] bullshit in Plex example under complex
by Tobin Isaac 29 Aug '15

29 Aug '15

On Sat, Aug 29, 2015 at 05:53:22PM -0500, Barry Smith wrote: > > > On Aug 29, 2015, at 5:47 PM, Jed Brown <jed(a)jedbrown.org> wrote: > > > > Tobin Isaac <tisaac(a)ices.utexas.edu> writes: > >> How am I supposed to add a test to the intersection of a package > >> (testexamples_TRIANGLE) and a scalar type (testexamples_C_NoComplex). > >> It's pretty frustrating, given how obvious this would be with > >> something like sharness [1], that I couldn't easily figure this out. > > > > I've used sharness a reasonable amount and generally like it, especially > > when paired with "prove". A couple years ago, I did some exploratory > > work to parse PETSc makefile tests and generate sharness-style tests. I > > still don't think it's a bad idea and might yet be able to get back to > > It seems to require a lot of boilerplate for each test. I sure as heck hope we don't have to write that by hand for each test. Really? Compare sharness in hpgmpg [1] to PETSc, keeping in mind that the .out files in PETSc-parlance are incorporated into the test script. Every test in PETSc (a) writes out the command line in full, (b) diff's against the expected output, (c) writes out the "Possible problem" message, and (d) removes the temporary files. If sharness can meet PETSc's portability needs, that would strike me as a good reduction in boiler plate. Toby [1] https://bitbucket.org/hpgmg/hpgmg/src/26f74a2120cefc078b9b855297b77bf8d62ff… > > I'm not a fan of the "parse the PETSc makefiles approach"; I think we need to define a standard format for declaring tests that is very concise (only exactly what is needed; I have one try in a branch somewhere). Then we can have code that translates from the standard format to anything people want to try with testing scripts. I am even willing to manually convert makefile crap to this format when necessary > > Barry > > > it. >

1 0

Re: [petsc-dev] bullshit in Plex example under complex
by Jed Brown 29 Aug '15

29 Aug '15

Barry Smith <bsmith(a)mcs.anl.gov> writes: > It seems to require a lot of boilerplate for each test. I sure as heck hope we don't have to write that by hand for each test. Here is an example: $ cat src/hpgmg/finite-element/test/t230-fmg-poisson2.sh #!/bin/sh test_description='Test Q2 Poisson solve using FMG' . ./hpgmg-sharness.sh # Error norm is converging at fourth order (superconvergent at Lagrange nodes) test_expect_stdout 'FE Poisson FMG solve fedegree=2 serial' 1 'hpgmg-fe fmg -op_type poisson2 -M 4,4,6 -smooth 4,3' ' F(4,3) 0: |e|_2/|u|_2 9.08e-03 |r|_2/|f|_2 3.35e-04 V(4,3) 1: |e|_2/|u|_2 9.17e-03 |r|_2/|f|_2 8.27e-07 V(4,3) 2: |e|_2/|u|_2 9.17e-03 |r|_2/|f|_2 5.54e-09 ' test_expect_stdout 'FE Poisson FMG solve fedegree=2 parallel' 4 'hpgmg-fe fmg -op_type poisson2 -M 4,4,6 -smooth 4,3 -p 1,2,2' ' F(4,3) 0: |e|_2/|u|_2 9.08e-03 |r|_2/|f|_2 3.35e-04 V(4,3) 1: |e|_2/|u|_2 9.17e-03 |r|_2/|f|_2 8.27e-07 V(4,3) 2: |e|_2/|u|_2 9.17e-03 |r|_2/|f|_2 5.54e-09 ' test_done Since I have quite short output here, the test output is inline. > I'm not a fan of the "parse the PETSc makefiles approach"; I think we need to define a standard format for declaring tests that is very concise (only exactly what is needed; I have one try in a branch somewhere). Then we can have code that translates from the standard format to anything people want to try with testing scripts. I am even willing to manually convert makefile crap to this format when necessary My "parse the makefiles" was intended to automate the conversion to a more concise format that a (hopefully sane) test system can use directly. I'm not wild about introducing extra translation phases because it makes the testing system more difficult to understand and exposes more possible failure modes. FWIW, we could greatly simplify the makefiles by having each target simply call a script that runs the actual program, collects stdout and stderr and exit codes, and outputs the test result in a standard format (e.g., TAP). I.e., move the repetitive shell code we have now in each target into a single script used for all tests. This script could also have an argument containing restrictions (NoComplex, etc.) so that it can determine when to skip. Moreover, it can sandbox the execution to a temporary directory and clean up after it. As I see it, this is basically equivalent to moving the tests into a sharness-type system or similar. In my opinion, one crucial component in a revamped testing system is to enable parallel execution with a maximum number of processes (perhaps exceeded when a single job needs more than that, but definitely not otherwise). Sharness is really nice for tests that replicate a session where the state is tested as various checkpoints along the way. We have a few of these (e.g., creating and reading files), but most of our tests are independent, which maps to sharness as independent test scripts. One file per test is actually the best case for merging, but can be cumbersome otherwise.

1 0

Re: [petsc-dev] bullshit in Plex example under complex
by Barry Smith 29 Aug '15

29 Aug '15

> On Aug 29, 2015, at 5:47 PM, Jed Brown <jed(a)jedbrown.org> wrote: > > Tobin Isaac <tisaac(a)ices.utexas.edu> writes: >> How am I supposed to add a test to the intersection of a package >> (testexamples_TRIANGLE) and a scalar type (testexamples_C_NoComplex). >> It's pretty frustrating, given how obvious this would be with >> something like sharness [1], that I couldn't easily figure this out. > > I've used sharness a reasonable amount and generally like it, especially > when paired with "prove". A couple years ago, I did some exploratory > work to parse PETSc makefile tests and generate sharness-style tests. I > still don't think it's a bad idea and might yet be able to get back to It seems to require a lot of boilerplate for each test. I sure as heck hope we don't have to write that by hand for each test. I'm not a fan of the "parse the PETSc makefiles approach"; I think we need to define a standard format for declaring tests that is very concise (only exactly what is needed; I have one try in a branch somewhere). Then we can have code that translates from the standard format to anything people want to try with testing scripts. I am even willing to manually convert makefile crap to this format when necessary Barry > it.

1 0

Re: [petsc-dev] bullshit in Plex example under complex
by Jed Brown 29 Aug '15

29 Aug '15

Tobin Isaac <tisaac(a)ices.utexas.edu> writes: > How am I supposed to add a test to the intersection of a package > (testexamples_TRIANGLE) and a scalar type (testexamples_C_NoComplex). > It's pretty frustrating, given how obvious this would be with > something like sharness [1], that I couldn't easily figure this out. I've used sharness a reasonable amount and generally like it, especially when paired with "prove". A couple years ago, I did some exploratory work to parse PETSc makefile tests and generate sharness-style tests. I still don't think it's a bad idea and might yet be able to get back to it.

1 0

Re: [petsc-dev] strangness in Chebyshev estimate of eigenvalues
by Jed Brown 29 Aug '15

29 Aug '15

Mark Adams <mfadams(a)lbl.gov> writes: > The point is that it is possible to have a process invariant test, as > opposed to impossible. PETSc's MIS is not invariant now anyway. If we want something invariant that is algorithmically defensible, we have to use a quality hash function. It's entirely feasible, we just have to decide to do it. > I don't think about DMDA; the problems that I have experience with > have a global numbering that can be preserved if one wishes for > debugging. That implies a "1D partition" of a fixed ordering. I suppose that's okay when people have already chosen SFC orderings.

1 0