March 2011 - petsc-dev - mailman3.cels.anl.gov

Re: [petsc-dev] MatNullSpaceDestroy
by Matthew Knepley 23 Mar '11

23 Mar '11

On Wed, Mar 23, 2011 at 7:12 PM, Lisandro Dalcin <dalcinl(a)gmail.com> wrote: > On 23 March 2011 20:09, Barry Smith <bsmith(a)mcs.anl.gov> wrote: > > > > On Mar 23, 2011, at 5:58 PM, Lisandro Dalcin wrote: > > > >> Are you going to rename MatNullSpaceDestroy -> MatNullSpaceDestroy_ > >> and add the backward compatibility #define? Changeset 1a6f5fc1c27b > >> broke petsc4py... > > > > No, it was changed to the &object paradigm. > > > > Basically what is happening now is that commonly used destroys are > changed with the _ paradigm > > > > Uncommonly used destroy are fixed to use the &object paradigm. > > > > Understood... I'm going to fix petsc4py... > I already fixed MatNullSpaceDestroy(). Matt > > > > Don't like the fact that there are two paradigms well I could change > everything to & immediately :-( > > > > :-) > > > > > Barry > > > > Eventually I want to switch to the &object paradigm for everything but > I decided to be nice to Matt and leave the common ones with the same API so > users don't have to change their codes much. > > > > I still feel we should use a different approach for backward > compatibility... Perhaps adding a petsccompat.h header file (or even > compat/petscXXX.h headers) with backward compatibility macro defs and > even STATIC_INLINE routines, in order to help people switch > incrementally. > > My concern is that if you do not make pressure on users RIGHT NOW to > forcibly notice there is a new API's, most of them are going simply > ignore the changes, pretend they old API is fine to use, and finally > cry in the next release petsc-3.3 because their code is finally > broken. > > Please note that this is the approach I use for petsc4py, right now > petsc4py-dev can build back to petsc-3.0.0. Of course, a potential > petsccompat.h should have a reverse direction of compatibility for > what I have in petsc4py > > > > > -- > Lisandro Dalcin > --------------- > CIMEC (INTEC/CONICET-UNL) > Predio CONICET-Santa Fe > Colectora RN 168 Km 472, Paraje El Pozo > 3000 Santa Fe, Argentina > Tel: +54-342-4511594 (ext 1011) > Tel/Fax: +54-342-4511169 > -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener

1 0

Re: [petsc-dev] MatNullSpaceDestroy
by Lisandro Dalcin 23 Mar '11

23 Mar '11

On 23 March 2011 20:09, Barry Smith <bsmith(a)mcs.anl.gov> wrote: > > On Mar 23, 2011, at 5:58 PM, Lisandro Dalcin wrote: > >> Are you going to rename MatNullSpaceDestroy -> MatNullSpaceDestroy_ >> and add the backward compatibility #define? Changeset 1a6f5fc1c27b >> broke petsc4py... > > No, it was changed to the &object paradigm. > > Basically what is happening now is that commonly used destroys are changed with the _ paradigm > > Uncommonly used destroy are fixed to use the &object paradigm. > Understood... I'm going to fix petsc4py... > > Don't like the fact that there are two paradigms well I could change everything to & immediately :-( > :-) > > Barry > > Eventually I want to switch to the &object paradigm for everything but I decided to be nice to Matt and leave the common ones with the same API so users don't have to change their codes much. > I still feel we should use a different approach for backward compatibility... Perhaps adding a petsccompat.h header file (or even compat/petscXXX.h headers) with backward compatibility macro defs and even STATIC_INLINE routines, in order to help people switch incrementally. My concern is that if you do not make pressure on users RIGHT NOW to forcibly notice there is a new API's, most of them are going simply ignore the changes, pretend they old API is fine to use, and finally cry in the next release petsc-3.3 because their code is finally broken. Please note that this is the approach I use for petsc4py, right now petsc4py-dev can build back to petsc-3.0.0. Of course, a potential petsccompat.h should have a reverse direction of compatibility for what I have in petsc4py -- Lisandro Dalcin --------------- CIMEC (INTEC/CONICET-UNL) Predio CONICET-Santa Fe Colectora RN 168 Km 472, Paraje El Pozo 3000 Santa Fe, Argentina Tel: +54-342-4511594 (ext 1011) Tel/Fax: +54-342-4511169

1 0

Re: [petsc-dev] hg diff question
by Satish Balay 23 Mar '11

23 Mar '11

On Wed, 23 Mar 2011, Barry Smith wrote: > > On Mar 23, 2011, at 5:20 PM, Satish Balay wrote: > > > On Wed, 23 Mar 2011, Satish Balay wrote: > > > >> > >> Well this is what I have: > >> > >> function bsmithdiff { > >> hg diff -c `hg log -l 1 --template '{node}' $1` > >> } > >> > >> bsmithdiff src/makefile > > > > This one [bash function] is slightly better > > > > function bsmithdiff { > > hg diff -c `hg log -l $1 --template '{node}\n' $2| tail -1` $2 > > } > > > > bsmithdiff 1 src/makefile > > bsmithdiff 2 src/makefile > > > > What good is this? It doesn't show any changes. I want to see the last two sets of changes. It shows the last 2 changes to src/makefile for me. asterix:/home/balay/spetsc>function bsmithdiff { > hg diff -c `hg log -l $1 --template '{node}\n' $2| tail -1` $2 > } asterix:/home/balay/spetsc>bsmithdiff 1 src/makefile diff -r 3b37fb452c93 -r 88a383b52fbf src/makefile --- a/src/makefile Wed Mar 23 13:06:49 2011 +0100 +++ b/src/makefile Wed Mar 23 13:49:05 2011 +0100 @@ -1,5 +1,5 @@ -DIRS = inline sys vec mat dm ksp snes ts contrib benchmarks docs tops characteristic +DIRS = inline sys vec mat dm ksp snes ts contrib benchmarks docs tops LOCDIR = src/ MANSEC = Sys asterix:/home/balay/spetsc>bsmithdiff 2 src/makefile diff -r 2d1785e2f9cd -r 2aec9ed184d1 src/makefile --- a/src/makefile Mon Jun 14 17:32:56 2010 -0500 +++ b/src/makefile Mon Jun 14 17:51:48 2010 -0500 @@ -1,5 +1,5 @@ -DIRS = inline sys vec mat ksp snes ts dm contrib benchmarks docs tops characteristic +DIRS = inline sys vec mat dm ksp snes ts contrib benchmarks docs tops characteristic LOCDIR = src/ MANSEC = Sys asterix:/home/balay/spetsc>

1 0

Re: [petsc-dev] hg diff question
by Barry Smith 23 Mar '11

23 Mar '11

On Mar 23, 2011, at 5:20 PM, Satish Balay wrote: > On Wed, 23 Mar 2011, Satish Balay wrote: > >> >> Well this is what I have: >> >> function bsmithdiff { >> hg diff -c `hg log -l 1 --template '{node}' $1` >> } >> >> bsmithdiff src/makefile > > This one [bash function] is slightly better > > function bsmithdiff { > hg diff -c `hg log -l $1 --template '{node}\n' $2| tail -1` $2 > } > > bsmithdiff 1 src/makefile > bsmithdiff 2 src/makefile > What good is this? It doesn't show any changes. I want to see the last two sets of changes. Barry > satish

1 0

Re: [petsc-dev] MatNullSpaceDestroy
by Barry Smith 23 Mar '11

23 Mar '11

On Mar 23, 2011, at 5:58 PM, Lisandro Dalcin wrote: > Are you going to rename MatNullSpaceDestroy -> MatNullSpaceDestroy_ > and add the backward compatibility #define? Changeset 1a6f5fc1c27b > broke petsc4py... No, it was changed to the &object paradigm. Basically what is happening now is that commonly used destroys are changed with the _ paradigm Uncommonly used destroy are fixed to use the &object paradigm. Don't like the fact that there are two paradigms well I could change everything to & immediately :-( Barry Eventually I want to switch to the &object paradigm for everything but I decided to be nice to Matt and leave the common ones with the same API so users don't have to change their codes much. > > -- > Lisandro Dalcin > --------------- > CIMEC (INTEC/CONICET-UNL) > Predio CONICET-Santa Fe > Colectora RN 168 Km 472, Paraje El Pozo > 3000 Santa Fe, Argentina > Tel: +54-342-4511594 (ext 1011) > Tel/Fax: +54-342-4511169

1 0

Re: [petsc-dev] hg diff question
by Satish Balay 23 Mar '11

23 Mar '11

On Wed, 23 Mar 2011, Satish Balay wrote: > > Well this is what I have: > > function bsmithdiff { > hg diff -c `hg log -l 1 --template '{node}' $1` > } > > bsmithdiff src/makefile This one [bash function] is slightly better function bsmithdiff { hg diff -c `hg log -l $1 --template '{node}\n' $2| tail -1` $2 } bsmithdiff 1 src/makefile bsmithdiff 2 src/makefile satish

1 0

Re: [petsc-dev] hg diff question
by Satish Balay 23 Mar '11

23 Mar '11

On Wed, 23 Mar 2011, Matthew Knepley wrote: > On Wed, Mar 23, 2011 at 4:47 PM, Satish Balay <balay(a)mcs.anl.gov> wrote: > > > On Wed, 23 Mar 2011, Matthew Knepley wrote: > > > > > On Wed, Mar 23, 2011 at 3:21 PM, Barry Smith <bsmith(a)mcs.anl.gov> wrote: > > > > > > > > > > > hg diff src/makefile > > > > > > > > > > > > How come there isn't an option to have it show the most recent set of > > > > changes? It seems I have to hunt down some "revision numbers" and type > > them > > > > in the request to get any useful information? How about something like > > > > > > > > hg diff --last src/makefile > > > > > > > > > The closest I can find is > > > > > > hg diff -r-2 src/makefile > > > > > > which diffs against the first revision before tip. However, if you pull a > > > bunch of revisions, there > > > is no guarantee that is right. You can generate this diff before the pull > > > using 'hg incoming', but > > > I can't yet find a command to give me the last thing pulled down. > > > > hg diff by default does diff with working dir. What you want is: > > > > hg diff -c tip > > or > > hg diff -c -2 > > > > The relative-rev numbering is based on full changeset numbering from > > tip - and not selective-file-changeset nubmering - which is what Barry > > wants.. I don't know if that exists.. > > > I will point out that this would be easy to write as an extension. We use > a 'bsmithdiff' diff that first calls 'log' to get the sequence of changesets > for this file, and then counts backwards. Well this is what I have: function bsmithdiff { hg diff -c `hg log -l 1 --template '{node}' $1` } bsmithdiff src/makefile

1 0

Re: [petsc-dev] hg diff question
by Matthew Knepley 23 Mar '11

23 Mar '11

On Wed, Mar 23, 2011 at 4:47 PM, Satish Balay <balay(a)mcs.anl.gov> wrote: > On Wed, 23 Mar 2011, Matthew Knepley wrote: > > > On Wed, Mar 23, 2011 at 3:21 PM, Barry Smith <bsmith(a)mcs.anl.gov> wrote: > > > > > > > > hg diff src/makefile > > > > > > > > > How come there isn't an option to have it show the most recent set of > > > changes? It seems I have to hunt down some "revision numbers" and type > them > > > in the request to get any useful information? How about something like > > > > > > hg diff --last src/makefile > > > > > > The closest I can find is > > > > hg diff -r-2 src/makefile > > > > which diffs against the first revision before tip. However, if you pull a > > bunch of revisions, there > > is no guarantee that is right. You can generate this diff before the pull > > using 'hg incoming', but > > I can't yet find a command to give me the last thing pulled down. > > hg diff by default does diff with working dir. What you want is: > > hg diff -c tip > or > hg diff -c -2 > > The relative-rev numbering is based on full changeset numbering from > tip - and not selective-file-changeset nubmering - which is what Barry > wants.. I don't know if that exists.. I will point out that this would be easy to write as an extension. We use a 'bsmithdiff' diff that first calls 'log' to get the sequence of changesets for this file, and then counts backwards. Matt > > Satish -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener

1 0

Re: [petsc-dev] hg diff question
by Satish Balay 23 Mar '11

23 Mar '11

On Wed, 23 Mar 2011, Matthew Knepley wrote: > On Wed, Mar 23, 2011 at 3:21 PM, Barry Smith <bsmith(a)mcs.anl.gov> wrote: > > > > > hg diff src/makefile > > > > > > How come there isn't an option to have it show the most recent set of > > changes? It seems I have to hunt down some "revision numbers" and type them > > in the request to get any useful information? How about something like > > > > hg diff --last src/makefile > > > The closest I can find is > > hg diff -r-2 src/makefile > > which diffs against the first revision before tip. However, if you pull a > bunch of revisions, there > is no guarantee that is right. You can generate this diff before the pull > using 'hg incoming', but > I can't yet find a command to give me the last thing pulled down. hg diff by default does diff with working dir. What you want is: hg diff -c tip or hg diff -c -2 The relative-rev numbering is based on full changeset numbering from tip - and not selective-file-changeset nubmering - which is what Barry wants.. I don't know if that exists.. Satish

1 0

Re: [petsc-dev] hg diff question
by Matthew Knepley 23 Mar '11

23 Mar '11

On Wed, Mar 23, 2011 at 3:21 PM, Barry Smith <bsmith(a)mcs.anl.gov> wrote: > > hg diff src/makefile > > > How come there isn't an option to have it show the most recent set of > changes? It seems I have to hunt down some "revision numbers" and type them > in the request to get any useful information? How about something like > > hg diff --last src/makefile The closest I can find is hg diff -r-2 src/makefile which diffs against the first revision before tip. However, if you pull a bunch of revisions, there is no guarantee that is right. You can generate this diff before the pull using 'hg incoming', but I can't yet find a command to give me the last thing pulled down. Matt Matt > > Barry > > > -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener

1 0