May 2012 - petsc-dev - mailman3.cels.anl.gov

Re: [petsc-dev] release preparation
by Satish Balay 31 May '12

31 May '12

I've now created the release repos - so petsc-dev is now open for all commits. [If you've accumulated petsc-dev related commits - rebasing them with current petsc-dev - before pushing would be good.] Release related commits should now go to the release repo [and not directly to petsc-dev]. Please use the usual release repo workflow. i.e: - clone the release repos - commit/push [to release-repos] - from petsc-dev clone - pull/merge release commits and push to petsc-dev. [or defer this last step to me until the release] ssh://[email protected]//hg/petsc/releases/petsc-3.3 ssh://[email protected]//hg/petsc/releases/BuildSystem-3.3 Satish On Thu, 17 May 2012, Barry Smith wrote: > > petsc-dev folks, > > Recall that we are in a phase of a code freeze that means do not push random new code to petsc-dev, push only bug fixes and clean up to petsc-dev. By all means keep on with code development, just don't push the new stuff to petsc-dev. > > We hope to make the release repository (and then tarball) next Wednesday May 23. So please do be checking the nightly builds and making fixes to petsc-dev. > > Barry > > Note: threaded code and GPU code will not be supported with the release (users should continue to use petsc-dev after the release) so fixes/extensions to those things are not needed and shouldn't be pushed to petsc-dev at the moment. > >

1 0

Re: [petsc-dev] What needs to be done before a release?
by Blaise Bourdin 30 May '12

30 May '12

Fantastic! Thanks you so much, Blaise On May 30, 2012, at 10:04 PM, Barry Smith wrote: > > Blaise, > > I have pushed PetscOptionsGetEnum() and PetscBagRegisterEnum() for f90 to petsc-dev tests are in src/sys/examples/tutorials > > Barry > > On May 29, 2012, at 3:29 AM, Blaise Bourdin wrote: > >> >> On May 29, 2012, at 1:18 AM, Barry Smith wrote: >> >>> >>> Blaise, >>> >>> How about the attached? My goal is to have the usage be as similar to the other PetscOptions... calls and too not require the Fortran user to be C aware that is, they should not have to append null characters or declare special C type declaration. In other words, the user writes Fortran77 code :-).[see attached file: ex1f.F90] >>> >>> I don't think it should bleed, but then I am no longer a Fortran programmer. >> >> Once a fortran programmer, always a fortran programmer... It's not like there is a lot to forget. >> >> Now I understand what you want. I agree with your goal of making the call standard and transparent. There is one issue with this approach for a function like PetscBagRegisterEnum (as far as I understand the C code), where you don't copy the string array in the bag item structure, but keep a reference to it (l. 80 in bag.c). After Carray and list1 are deallocated, the bag item->list points to some nonsense. I lost my mind trying to find a workaround last week. >> >> Would you be OK with requesting that each of the strings in list have some padding at the end, and be modified in the wrapper (adding the C_NULL_CHAR)? The alternative would be to modify PetscBagRegisterEnum, in order to store the content of list instead of just a reference, which may not be something you want to do right now. >> >> Blaise >> >> >>> >>> Barry >>> >>> >>> >>> On May 27, 2012, at 10:16 AM, Blaise Bourdin wrote: >>> >>>> Barry, >>>> >>>> If I frame your email, will you sign it for me? ;) >>>> >>>> I am traveling so I did not have much time to do it, even in my sleep, but Tim's solution is essentially right. >>>> >>>> Have a look at the attached code. I had to write my own interface to PetscOptionsGetEnum, but I have to do the equivalent of FIXCHAR by myself (basically appending //C_NULL_CHAR). I checked in the debugger, and the list argument that is passed to PetscOptionsGetEList is the same as the one passed from C. Is this what you want? >>>> >>>> Do you want to do the FIXCHAR business in the C or fortran side? I suspect that you would prefer not having to append the C_NULL_CHAR in fortran, but I can't figure how to do that without allocating a new array of strings, and causing a memory leak. What do you think? >>>> >>>> If this is not what you want, could you meet me half way and write the fortran interface you would like to use, in which case I will try to write the missing fortran parts. >>>> >>>> Blaise >>>> <PetscF2003.F90> >>>>> >>>>> Tim, >>>>> >>>>> Thanks. But what I want is all bundled up a routine that takes in the Fortran array of character strings and allocates and copies over them to the C ptr business. Likely I could figure it out myself with but Blaise is such a Fortran wizard he can do it optimally in his sleep :-) >>>>> >>>>> Barry >>>>> >>>>> On May 25, 2012, at 8:14 PM, Tim Gallagher wrote: >>>>> >>>>>> For what it's worth, I answered a question about how to pass string arrays awhile ago on StackOverflow: >>>>>> >>>>>> http://stackoverflow.com/questions/9686532/arrays-of-strings-in-fortran-c-b… >>>>>> >>>>>> Tim >>>>>> >>>>>> ----- Original Message ----- >>>>>> From: "Barry Smith" <bsmith(a)mcs.anl.gov> >>>>>> To: "For users of the development version of PETSc" <petsc-dev(a)mcs.anl.gov> >>>>>> Sent: Friday, May 25, 2012 8:57:52 PM >>>>>> Subject: Re: [petsc-dev] What needs to be done before a release? >>>>>> >>>>>> Blaise >>>>>> >>>>>> If you provide a fortran function to convert an array of Fortran strings to an array of C strings and tell us how to delete the result then we'll provide a PetscOptionsGetEnum() for Fortran. >>>>>> >>>>>> Barry >>>>>> >>>>>> On May 2, 2012, at 12:02 PM, Blaise Bourdin wrote: >>>>>> >>>>>>> Barry, >>>>>>> >>>>>>>>> Also, fortran wrappers over PetscOptionsEnum and PetscBagRegisterEnum would be nice. I understand that it >>>>>>>>> is a bit tricky since it involves passing fortran arrays of strings. >>>>>>>> >>>>>>>> Yup. We'd be willing to support these from FORTRAN but someone else has to do the dirty work of figuring out how to handle those array of strings (maybe F2003?). >>>>>>> >>>>>>> I am attaching a simple proof of concept example that demonstrates how to write a fortran interface and call petsc C functions from fortran using F2003 C-interoperability instead of going through the fortran bindings. >>>>>>> >>>>>>> Don't be put off by all the warnings if you use gfortran. They would be easy to avoid. Basically, right now, you detect the fortran integer and real kinds that match that of the C ones. It would be quite simple to get the fortran C-interoperable integer and real types associated with the C type of PetscInt, PetscReal etc. >>>>>>> >>>>>>> Basically, we (I?) could write a fortran interface and a fortran function for the tricky functions involving arrays of string, instead of creating a custom binding in C. Are you willing to let some fortran pollution into the petsc code? Where would these function have to be? >>>>>>> >>>>>>> Blaise >>>>>>> >>>>>>> PS: you need FCFLAGS='-ffixed-line-length-none -ffree-line-length-none -ffree-form' or some subset of these to compile with gfortran. I'm not sure why these are not the default with a file suffix .F90 >>>>>>> >>>>>>> <PetscF2003Binding.F90> >>>>>>> -- >>>>>>> Department of Mathematics and Center for Computation & Technology >>>>>>> Louisiana State University, Baton Rouge, LA 70803, USA >>>>>>> Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> -- >>>> Department of Mathematics and Center for Computation & Technology >>>> Louisiana State University, Baton Rouge, LA 70803, USA >>>> Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> <ex1f.F90> >> >> -- >> Department of Mathematics and Center for Computation & Technology >> Louisiana State University, Baton Rouge, LA 70803, USA >> Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin >> >> >> >> >> >> >> > -- Department of Mathematics and Center for Computation & Technology Louisiana State University, Baton Rouge, LA 70803, USA Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin

1 0

Re: [petsc-dev] What needs to be done before a release?
by Barry Smith 30 May '12

30 May '12

Blaise, I have pushed PetscOptionsGetEnum() and PetscBagRegisterEnum() for f90 to petsc-dev tests are in src/sys/examples/tutorials Barry On May 29, 2012, at 3:29 AM, Blaise Bourdin wrote: > > On May 29, 2012, at 1:18 AM, Barry Smith wrote: > >> >> Blaise, >> >> How about the attached? My goal is to have the usage be as similar to the other PetscOptions... calls and too not require the Fortran user to be C aware that is, they should not have to append null characters or declare special C type declaration. In other words, the user writes Fortran77 code :-).[see attached file: ex1f.F90] >> >> I don't think it should bleed, but then I am no longer a Fortran programmer. > > Once a fortran programmer, always a fortran programmer... It's not like there is a lot to forget. > > Now I understand what you want. I agree with your goal of making the call standard and transparent. There is one issue with this approach for a function like PetscBagRegisterEnum (as far as I understand the C code), where you don't copy the string array in the bag item structure, but keep a reference to it (l. 80 in bag.c). After Carray and list1 are deallocated, the bag item->list points to some nonsense. I lost my mind trying to find a workaround last week. > > Would you be OK with requesting that each of the strings in list have some padding at the end, and be modified in the wrapper (adding the C_NULL_CHAR)? The alternative would be to modify PetscBagRegisterEnum, in order to store the content of list instead of just a reference, which may not be something you want to do right now. > > Blaise > > >> >> Barry >> >> >> >> On May 27, 2012, at 10:16 AM, Blaise Bourdin wrote: >> >>> Barry, >>> >>> If I frame your email, will you sign it for me? ;) >>> >>> I am traveling so I did not have much time to do it, even in my sleep, but Tim's solution is essentially right. >>> >>> Have a look at the attached code. I had to write my own interface to PetscOptionsGetEnum, but I have to do the equivalent of FIXCHAR by myself (basically appending //C_NULL_CHAR). I checked in the debugger, and the list argument that is passed to PetscOptionsGetEList is the same as the one passed from C. Is this what you want? >>> >>> Do you want to do the FIXCHAR business in the C or fortran side? I suspect that you would prefer not having to append the C_NULL_CHAR in fortran, but I can't figure how to do that without allocating a new array of strings, and causing a memory leak. What do you think? >>> >>> If this is not what you want, could you meet me half way and write the fortran interface you would like to use, in which case I will try to write the missing fortran parts. >>> >>> Blaise >>> <PetscF2003.F90> >>>> >>>> Tim, >>>> >>>> Thanks. But what I want is all bundled up a routine that takes in the Fortran array of character strings and allocates and copies over them to the C ptr business. Likely I could figure it out myself with but Blaise is such a Fortran wizard he can do it optimally in his sleep :-) >>>> >>>> Barry >>>> >>>> On May 25, 2012, at 8:14 PM, Tim Gallagher wrote: >>>> >>>>> For what it's worth, I answered a question about how to pass string arrays awhile ago on StackOverflow: >>>>> >>>>> http://stackoverflow.com/questions/9686532/arrays-of-strings-in-fortran-c-b… >>>>> >>>>> Tim >>>>> >>>>> ----- Original Message ----- >>>>> From: "Barry Smith" <bsmith(a)mcs.anl.gov> >>>>> To: "For users of the development version of PETSc" <petsc-dev(a)mcs.anl.gov> >>>>> Sent: Friday, May 25, 2012 8:57:52 PM >>>>> Subject: Re: [petsc-dev] What needs to be done before a release? >>>>> >>>>> Blaise >>>>> >>>>> If you provide a fortran function to convert an array of Fortran strings to an array of C strings and tell us how to delete the result then we'll provide a PetscOptionsGetEnum() for Fortran. >>>>> >>>>> Barry >>>>> >>>>> On May 2, 2012, at 12:02 PM, Blaise Bourdin wrote: >>>>> >>>>>> Barry, >>>>>> >>>>>>>> Also, fortran wrappers over PetscOptionsEnum and PetscBagRegisterEnum would be nice. I understand that it >>>>>>>> is a bit tricky since it involves passing fortran arrays of strings. >>>>>>> >>>>>>> Yup. We'd be willing to support these from FORTRAN but someone else has to do the dirty work of figuring out how to handle those array of strings (maybe F2003?). >>>>>> >>>>>> I am attaching a simple proof of concept example that demonstrates how to write a fortran interface and call petsc C functions from fortran using F2003 C-interoperability instead of going through the fortran bindings. >>>>>> >>>>>> Don't be put off by all the warnings if you use gfortran. They would be easy to avoid. Basically, right now, you detect the fortran integer and real kinds that match that of the C ones. It would be quite simple to get the fortran C-interoperable integer and real types associated with the C type of PetscInt, PetscReal etc. >>>>>> >>>>>> Basically, we (I?) could write a fortran interface and a fortran function for the tricky functions involving arrays of string, instead of creating a custom binding in C. Are you willing to let some fortran pollution into the petsc code? Where would these function have to be? >>>>>> >>>>>> Blaise >>>>>> >>>>>> PS: you need FCFLAGS='-ffixed-line-length-none -ffree-line-length-none -ffree-form' or some subset of these to compile with gfortran. I'm not sure why these are not the default with a file suffix .F90 >>>>>> >>>>>> <PetscF2003Binding.F90> >>>>>> -- >>>>>> Department of Mathematics and Center for Computation & Technology >>>>>> Louisiana State University, Baton Rouge, LA 70803, USA >>>>>> Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >>> -- >>> Department of Mathematics and Center for Computation & Technology >>> Louisiana State University, Baton Rouge, LA 70803, USA >>> Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin >>> >>> >>> >>> >>> >>> >>> >> >> <ex1f.F90> > > -- > Department of Mathematics and Center for Computation & Technology > Louisiana State University, Baton Rouge, LA 70803, USA > Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin > > > > > > >

1 0

Re: [petsc-dev] What needs to be done before a release?
by Jed Brown 30 May '12

30 May '12

On Wed, May 30, 2012 at 12:40 AM, Satish Balay <balay(a)mcs.anl.gov> wrote: > On Tue, 29 May 2012, Barry Smith wrote: > > > > > I have changed PetscBagRegisterEnum() to now properly copy the list > of enum strings values > > > > /home/balay/spetsc/src/sys/bag/bag.c: In function ‘PetscBagRegisterEnum’: > /home/balay/spetsc/src/sys/bag/bag.c:79:3: warning: passing argument 2 of > ‘PetscStrArrayallocpy’ from incompatible pointer type [enabled by default] > /home/balay/spetsc/include/petscsys.h:1156:29: note: expected ‘char ***’ > but argument is of type ‘const char ***’ > /home/balay/spetsc/src/sys/bag/bag.c: In function ‘PetscBagDestroy’: > /home/balay/spetsc/src/sys/bag/bag.c:473:7: warning: passing argument 1 of > ‘PetscStrArrayDestroy’ from incompatible pointer type [enabled by default] > /home/balay/spetsc/include/petscsys.h:1157:29: note: expected ‘char **’ > but argument is of type ‘const char **’ > > if anyone has a better fix - do correct the following. > http://petsc.cs.iit.edu/petsc/petsc-dev/rev/c62350f780f9 I prefer to be honest about const. http://petsc.cs.iit.edu/petsc/petsc-dev/rev/44a418def4d0

1 0

Re: [petsc-dev] What needs to be done before a release?
by Satish Balay 30 May '12

30 May '12

On Tue, 29 May 2012, Barry Smith wrote: > > I have changed PetscBagRegisterEnum() to now properly copy the list of enum strings values > /home/balay/spetsc/src/sys/bag/bag.c: In function οΏ½PetscBagRegisterEnumοΏ½: /home/balay/spetsc/src/sys/bag/bag.c:79:3: warning: passing argument 2 of οΏ½PetscStrArrayallocpyοΏ½ from incompatible pointer type [enabled by default] /home/balay/spetsc/include/petscsys.h:1156:29: note: expected οΏ½char ***οΏ½ but argument is of type οΏ½const char ***οΏ½ /home/balay/spetsc/src/sys/bag/bag.c: In function οΏ½PetscBagDestroyοΏ½: /home/balay/spetsc/src/sys/bag/bag.c:473:7: warning: passing argument 1 of οΏ½PetscStrArrayDestroyοΏ½ from incompatible pointer type [enabled by default] /home/balay/spetsc/include/petscsys.h:1157:29: note: expected οΏ½char **οΏ½ but argument is of type οΏ½const char **οΏ½ if anyone has a better fix - do correct the following. http://petsc.cs.iit.edu/petsc/petsc-dev/rev/c62350f780f9 Satish

1 0

Re: [petsc-dev] What needs to be done before a release?
by Barry Smith 29 May '12

29 May '12

On May 29, 2012, at 8:00 AM, Barry Smith wrote: >> >> Now I understand what you want. I agree with your goal of making the call standard and transparent. There is one issue with this approach for a function like PetscBagRegisterEnum (as far as I understand the C code), where you don't copy the string array in the bag item structure, but keep a reference to it (l. 80 in bag.c). After Carray and list1 are deallocated, the bag item->list points to some nonsense. I lost my mind trying to find a workaround last week. >> >> Would you be OK with requesting that each of the strings in list have some padding at the end, and be modified in the wrapper (adding the C_NULL_CHAR)? The alternative would be to modify PetscBagRegisterEnum, in order to store the content of list instead of just a reference, which may not be something you want to do right now. > > Actually. I think PetscBagRegisterEnum() should be modified to copy the list, it is an unsafe function even from C now. Implicitly I assumed that list was declared as a global static variable (hence the current PetscBagRegisterEnum() is ok) but I should not have made that assumption. I have changed PetscBagRegisterEnum() to now properly copy the list of enum strings values Barry > > Barry > >> >> Blaise >> >> >>> >>> Barry >>> >>> >>> >>> On May 27, 2012, at 10:16 AM, Blaise Bourdin wrote: >>> >>>> Barry, >>>> >>>> If I frame your email, will you sign it for me? ;) >>>> >>>> I am traveling so I did not have much time to do it, even in my sleep, but Tim's solution is essentially right. >>>> >>>> Have a look at the attached code. I had to write my own interface to PetscOptionsGetEnum, but I have to do the equivalent of FIXCHAR by myself (basically appending //C_NULL_CHAR). I checked in the debugger, and the list argument that is passed to PetscOptionsGetEList is the same as the one passed from C. Is this what you want? >>>> >>>> Do you want to do the FIXCHAR business in the C or fortran side? I suspect that you would prefer not having to append the C_NULL_CHAR in fortran, but I can't figure how to do that without allocating a new array of strings, and causing a memory leak. What do you think? >>>> >>>> If this is not what you want, could you meet me half way and write the fortran interface you would like to use, in which case I will try to write the missing fortran parts. >>>> >>>> Blaise >>>> <PetscF2003.F90> >>>>> >>>>> Tim, >>>>> >>>>> Thanks. But what I want is all bundled up a routine that takes in the Fortran array of character strings and allocates and copies over them to the C ptr business. Likely I could figure it out myself with but Blaise is such a Fortran wizard he can do it optimally in his sleep :-) >>>>> >>>>> Barry >>>>> >>>>> On May 25, 2012, at 8:14 PM, Tim Gallagher wrote: >>>>> >>>>>> For what it's worth, I answered a question about how to pass string arrays awhile ago on StackOverflow: >>>>>> >>>>>> http://stackoverflow.com/questions/9686532/arrays-of-strings-in-fortran-c-b… >>>>>> >>>>>> Tim >>>>>> >>>>>> ----- Original Message ----- >>>>>> From: "Barry Smith" <bsmith(a)mcs.anl.gov> >>>>>> To: "For users of the development version of PETSc" <petsc-dev(a)mcs.anl.gov> >>>>>> Sent: Friday, May 25, 2012 8:57:52 PM >>>>>> Subject: Re: [petsc-dev] What needs to be done before a release? >>>>>> >>>>>> Blaise >>>>>> >>>>>> If you provide a fortran function to convert an array of Fortran strings to an array of C strings and tell us how to delete the result then we'll provide a PetscOptionsGetEnum() for Fortran. >>>>>> >>>>>> Barry >>>>>> >>>>>> On May 2, 2012, at 12:02 PM, Blaise Bourdin wrote: >>>>>> >>>>>>> Barry, >>>>>>> >>>>>>>>> Also, fortran wrappers over PetscOptionsEnum and PetscBagRegisterEnum would be nice. I understand that it >>>>>>>>> is a bit tricky since it involves passing fortran arrays of strings. >>>>>>>> >>>>>>>> Yup. We'd be willing to support these from FORTRAN but someone else has to do the dirty work of figuring out how to handle those array of strings (maybe F2003?). >>>>>>> >>>>>>> I am attaching a simple proof of concept example that demonstrates how to write a fortran interface and call petsc C functions from fortran using F2003 C-interoperability instead of going through the fortran bindings. >>>>>>> >>>>>>> Don't be put off by all the warnings if you use gfortran. They would be easy to avoid. Basically, right now, you detect the fortran integer and real kinds that match that of the C ones. It would be quite simple to get the fortran C-interoperable integer and real types associated with the C type of PetscInt, PetscReal etc. >>>>>>> >>>>>>> Basically, we (I?) could write a fortran interface and a fortran function for the tricky functions involving arrays of string, instead of creating a custom binding in C. Are you willing to let some fortran pollution into the petsc code? Where would these function have to be? >>>>>>> >>>>>>> Blaise >>>>>>> >>>>>>> PS: you need FCFLAGS='-ffixed-line-length-none -ffree-line-length-none -ffree-form' or some subset of these to compile with gfortran. I'm not sure why these are not the default with a file suffix .F90 >>>>>>> >>>>>>> <PetscF2003Binding.F90> >>>>>>> -- >>>>>>> Department of Mathematics and Center for Computation & Technology >>>>>>> Louisiana State University, Baton Rouge, LA 70803, USA >>>>>>> Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> -- >>>> Department of Mathematics and Center for Computation & Technology >>>> Louisiana State University, Baton Rouge, LA 70803, USA >>>> Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> <ex1f.F90> >> >> -- >> Department of Mathematics and Center for Computation & Technology >> Louisiana State University, Baton Rouge, LA 70803, USA >> Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin >> >> >> >> >> >> >> >

1 0

Re: [petsc-dev] OpenMP compiler options
by Jed Brown 29 May '12

29 May '12

On Tue, May 29, 2012 at 10:56 AM, Satish Balay <balay(a)mcs.anl.gov> wrote: > Perhaps the 'empty' flag check should be at the begining of the list.. > No, because most compilers ignore the pragmas when no options are given. I do not know of any portable way, short of running code, to determine whether a compiler used the OpenMP pragmas or ignored them. > > [we do have other places in configure where we fix the order in which > flags are checked - due to similar conflicts between compilers] > > Satish > > On Tue, 29 May 2012, Jed Brown wrote: > > > The OpenMP flags do not definitively identify that OpenMP is used. In > > particular, IBM XL interprets Cray's option "-h omp" as being equivalent > to > > "-soname omp", then silently ignores the Open MP pragmas. We can perhaps > > "fix" this instance by moving -qsmp up in the list, but we may eventually > > need to move it to compilerOptions.py. > > > > def configureLibrary(self): > > ''' Checks for -fopenmp compiler flag''' > > ''' Needs to check if OpenMP actually exists and works ''' > > self.setCompilers.pushLanguage('C') > > # > > for flag in ["-fopenmp", # Gnu > > "-h omp", # Cray > > "-mp", # Portland Group > > "-Qopenmp", # Intel windows > > "-openmp", # Intel > > " ", # Empty, if compiler automatically accepts > > openmp > > "-xopenmp", # Sun > > "+Oopenmp", # HP > > "-qsmp", # IBM XL C/c++ > > "/openmp" # Microsoft Visual Studio > > ]: > > if self.setCompilers.checkCompilerFlag(flag): > > ompflag = flag > > break > > > >

1 0

Re: [petsc-dev] OpenMP compiler options
by Satish Balay 29 May '12

29 May '12

Perhaps the 'empty' flag check should be at the begining of the list.. [we do have other places in configure where we fix the order in which flags are checked - due to similar conflicts between compilers] Satish On Tue, 29 May 2012, Jed Brown wrote: > The OpenMP flags do not definitively identify that OpenMP is used. In > particular, IBM XL interprets Cray's option "-h omp" as being equivalent to > "-soname omp", then silently ignores the Open MP pragmas. We can perhaps > "fix" this instance by moving -qsmp up in the list, but we may eventually > need to move it to compilerOptions.py. > > def configureLibrary(self): > ''' Checks for -fopenmp compiler flag''' > ''' Needs to check if OpenMP actually exists and works ''' > self.setCompilers.pushLanguage('C') > # > for flag in ["-fopenmp", # Gnu > "-h omp", # Cray > "-mp", # Portland Group > "-Qopenmp", # Intel windows > "-openmp", # Intel > " ", # Empty, if compiler automatically accepts > openmp > "-xopenmp", # Sun > "+Oopenmp", # HP > "-qsmp", # IBM XL C/c++ > "/openmp" # Microsoft Visual Studio > ]: > if self.setCompilers.checkCompilerFlag(flag): > ompflag = flag > break >

1 0

Re: [petsc-dev] OpenMP compiler options
by Matthew Knepley 29 May '12

29 May '12

On Tue, May 29, 2012 at 3:52 PM, Jed Brown <jedbrown(a)mcs.anl.gov> wrote: > The OpenMP flags do not definitively identify that OpenMP is used. In > particular, IBM XL interprets Cray's option "-h omp" as being equivalent to > "-soname omp", then silently ignores the Open MP pragmas. We can perhaps > "fix" this instance by moving -qsmp up in the list, but we may eventually > need to move it to compilerOptions.py. Move it up, and add it to the comment. And people think OpenMP is the easy way? Matt > def configureLibrary(self): > ''' Checks for -fopenmp compiler flag''' > ''' Needs to check if OpenMP actually exists and works ''' > self.setCompilers.pushLanguage('C') > # > for flag in ["-fopenmp", # Gnu > "-h omp", # Cray > "-mp", # Portland Group > "-Qopenmp", # Intel windows > "-openmp", # Intel > " ", # Empty, if compiler automatically accepts > openmp > "-xopenmp", # Sun > "+Oopenmp", # HP > "-qsmp", # IBM XL C/c++ > "/openmp" # Microsoft Visual Studio > ]: > if self.setCompilers.checkCompilerFlag(flag): > ompflag = flag > break > > -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener

1 0

OpenMP compiler options
by Jed Brown 29 May '12

29 May '12

The OpenMP flags do not definitively identify that OpenMP is used. In particular, IBM XL interprets Cray's option "-h omp" as being equivalent to "-soname omp", then silently ignores the Open MP pragmas. We can perhaps "fix" this instance by moving -qsmp up in the list, but we may eventually need to move it to compilerOptions.py. def configureLibrary(self): ''' Checks for -fopenmp compiler flag''' ''' Needs to check if OpenMP actually exists and works ''' self.setCompilers.pushLanguage('C') # for flag in ["-fopenmp", # Gnu "-h omp", # Cray "-mp", # Portland Group "-Qopenmp", # Intel windows "-openmp", # Intel " ", # Empty, if compiler automatically accepts openmp "-xopenmp", # Sun "+Oopenmp", # HP "-qsmp", # IBM XL C/c++ "/openmp" # Microsoft Visual Studio ]: if self.setCompilers.checkCompilerFlag(flag): ompflag = flag break

1 0