petsc-dev
Threads by month
- ----- 2026 -----
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2025 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
September 2015
- 23 participants
- 134 discussions
>
> The function tolerances are usually something like |f(x_k) - f_(x_{k-1})|
> <= fatol
But that is *not* what they are in TAO, this has always been a source of
confusion.
The one upside of the f-tolerances is that they give the users a reasonable
level of confidence that the objective function value
achieved is within ftol of the true minimum, but it just happens to be
redundant because f(x)-f(X*) is estimated using ||g(x)||^2 (How? I thought
this made sense to me once, but now I don't see it anymore) and we also
have a convergence criteria for ||g(x)||.
On Wed, Sep 9, 2015 at 10:02 AM, Munson, Todd S. <tmunson(a)mcs.anl.gov>
wrote:
>
> I do not see a need to keep them around. The function tolerances are
> usually something like |f(x_k) - f_(x_{k-1})| <= fatol and then you
> use |f(x_0)| in the denominator for the relative tolerance. There
> are pretty useless tests though and give many false positives.
>
> Todd.
>
> > On Sep 9, 2015, at 9:26 AM, Jason Sarich <sarich(a)mcs.anl.gov> wrote:
> >
> > Todd, can you come up with a reason why we might need to keep these
> fatol, frtol tests around? I would prefer to take them out.
> >
> > Jason
> >
> > On Tue, Sep 8, 2015 at 9:54 PM, Smith, Barry F. <bsmith(a)mcs.anl.gov>
> wrote:
> >
> > Jason,
> >
> > Perhaps it is just documentation.
> >
> > /*@
> > TaoSetTolerances - Sets parameters used in TAO convergence tests
> >
> > Logically collective on Tao
> >
> > Input Parameters:
> > + tao - the Tao context
> > . fatol - absolute convergence tolerance
> > . frtol - relative convergence tolerance
> > . gatol - stop if norm of gradient is less than this
> > . grtol - stop if relative norm of gradient is less than this
> > - gttol - stop if norm of gradient is reduced by this factor
> >
> > Options Database Keys:
> > + -tao_fatol <fatol> - Sets fatol
> > . -tao_frtol <frtol> - Sets frtol
> > . -tao_gatol <gatol> - Sets gatol
> > . -tao_grtol <grtol> - Sets grtol
> > - -tao_gttol <gttol> - Sets gttol
> >
> > Stopping Criteria:
> > $ f(X) - f(X*) (estimated) <= fatol
> > $ |f(X) - f(X*)| (estimated) / |f(X)| <= frtol
> > $ ||g(X)|| <= gatol
> > $ ||g(X)|| / |f(X)| <= grtol
> > $ ||g(X)|| / ||g(X0)|| <= gttol
> >
> > How is f(x) - f(X*) (estimated) and how come the second definition has
> absolute values but the first does not?
> >
> > From below it looks like f(x) - f(X*) is estimated as gnorm*gnorm?
> >
> > } else if (gnorm2 <= fatol && cnorm <=catol) {
> > ierr = PetscInfo2(tao,"Converged due to estimated f(X) - f(X*) = %g
> < %g\n",(double)gnorm2,(double)fatol);CHKERRQ(ierr);
> > reason = TAO_CONVERGED_FATOL;
> > } else if (f != 0 && gnorm2 / PetscAbsReal(f)<= frtol &&
> cnorm/PetscMax(cnorm0,1.0) <= crtol) {
> > ierr = PetscInfo2(tao,"Converged due to estimated |f(X)-f(X*)|/f(X)
> = %g < %g\n",(double)(gnorm2/PetscAbsReal(f)),(double)frtol);CHKERRQ(ierr);
> > reason = TAO_CONVERGED_FRTOL;
> >
> > It seems the next test is the same as the first I list above exact gnorm
> is not squared? Why is it worth having this duplicate test?
> >
> > } else if (gnorm<= gatol && cnorm <=catol) {
> > ierr = PetscInfo2(tao,"Converged due to residual norm ||g(X)||=%g <
> %g\n",(double)gnorm,(double)gatol);CHKERRQ(ierr);
> > reason = TAO_CONVERGED_GATOL;
> >
> > At a minimum the manual page should document what f(X) - f(X*)
> (estimated) means.
> >
> > Barry
> >
> > } else if ( f!=0 && PetscAbsReal(gnorm/f) <= grtol && cnorm <= crtol) {
> > ierr = PetscInfo2(tao,"Converged due to residual ||g(X)||/|f(X)| =%g
> < %g\n",(double)(gnorm/f),(double)grtol);CHKERRQ(ierr);
> >
> >
>
>
1
0
I do not see a need to keep them around. The function tolerances are
usually something like |f(x_k) - f_(x_{k-1})| <= fatol and then you
use |f(x_0)| in the denominator for the relative tolerance. There
are pretty useless tests though and give many false positives.
Todd.
> On Sep 9, 2015, at 9:26 AM, Jason Sarich <sarich(a)mcs.anl.gov> wrote:
>
> Todd, can you come up with a reason why we might need to keep these fatol, frtol tests around? I would prefer to take them out.
>
> Jason
>
> On Tue, Sep 8, 2015 at 9:54 PM, Smith, Barry F. <bsmith(a)mcs.anl.gov> wrote:
>
> Jason,
>
> Perhaps it is just documentation.
>
> /*@
> TaoSetTolerances - Sets parameters used in TAO convergence tests
>
> Logically collective on Tao
>
> Input Parameters:
> + tao - the Tao context
> . fatol - absolute convergence tolerance
> . frtol - relative convergence tolerance
> . gatol - stop if norm of gradient is less than this
> . grtol - stop if relative norm of gradient is less than this
> - gttol - stop if norm of gradient is reduced by this factor
>
> Options Database Keys:
> + -tao_fatol <fatol> - Sets fatol
> . -tao_frtol <frtol> - Sets frtol
> . -tao_gatol <gatol> - Sets gatol
> . -tao_grtol <grtol> - Sets grtol
> - -tao_gttol <gttol> - Sets gttol
>
> Stopping Criteria:
> $ f(X) - f(X*) (estimated) <= fatol
> $ |f(X) - f(X*)| (estimated) / |f(X)| <= frtol
> $ ||g(X)|| <= gatol
> $ ||g(X)|| / |f(X)| <= grtol
> $ ||g(X)|| / ||g(X0)|| <= gttol
>
> How is f(x) - f(X*) (estimated) and how come the second definition has absolute values but the first does not?
>
> From below it looks like f(x) - f(X*) is estimated as gnorm*gnorm?
>
> } else if (gnorm2 <= fatol && cnorm <=catol) {
> ierr = PetscInfo2(tao,"Converged due to estimated f(X) - f(X*) = %g < %g\n",(double)gnorm2,(double)fatol);CHKERRQ(ierr);
> reason = TAO_CONVERGED_FATOL;
> } else if (f != 0 && gnorm2 / PetscAbsReal(f)<= frtol && cnorm/PetscMax(cnorm0,1.0) <= crtol) {
> ierr = PetscInfo2(tao,"Converged due to estimated |f(X)-f(X*)|/f(X) = %g < %g\n",(double)(gnorm2/PetscAbsReal(f)),(double)frtol);CHKERRQ(ierr);
> reason = TAO_CONVERGED_FRTOL;
>
> It seems the next test is the same as the first I list above exact gnorm is not squared? Why is it worth having this duplicate test?
>
> } else if (gnorm<= gatol && cnorm <=catol) {
> ierr = PetscInfo2(tao,"Converged due to residual norm ||g(X)||=%g < %g\n",(double)gnorm,(double)gatol);CHKERRQ(ierr);
> reason = TAO_CONVERGED_GATOL;
>
> At a minimum the manual page should document what f(X) - f(X*) (estimated) means.
>
> Barry
>
> } else if ( f!=0 && PetscAbsReal(gnorm/f) <= grtol && cnorm <= crtol) {
> ierr = PetscInfo2(tao,"Converged due to residual ||g(X)||/|f(X)| =%g < %g\n",(double)(gnorm/f),(double)grtol);CHKERRQ(ierr);
>
>
1
0
Todd, can you come up with a reason why we might need to keep these fatol,
frtol tests around? I would prefer to take them out.
Jason
On Tue, Sep 8, 2015 at 9:54 PM, Smith, Barry F. <bsmith(a)mcs.anl.gov> wrote:
>
> Jason,
>
> Perhaps it is just documentation.
>
> /*@
> TaoSetTolerances - Sets parameters used in TAO convergence tests
>
> Logically collective on Tao
>
> Input Parameters:
> + tao - the Tao context
> . fatol - absolute convergence tolerance
> . frtol - relative convergence tolerance
> . gatol - stop if norm of gradient is less than this
> . grtol - stop if relative norm of gradient is less than this
> - gttol - stop if norm of gradient is reduced by this factor
>
> Options Database Keys:
> + -tao_fatol <fatol> - Sets fatol
> . -tao_frtol <frtol> - Sets frtol
> . -tao_gatol <gatol> - Sets gatol
> . -tao_grtol <grtol> - Sets grtol
> - -tao_gttol <gttol> - Sets gttol
>
> Stopping Criteria:
> $ f(X) - f(X*) (estimated) <= fatol
> $ |f(X) - f(X*)| (estimated) / |f(X)| <= frtol
> $ ||g(X)|| <= gatol
> $ ||g(X)|| / |f(X)| <= grtol
> $ ||g(X)|| / ||g(X0)|| <= gttol
>
> How is f(x) - f(X*) (estimated) and how come the second definition has
> absolute values but the first does not?
>
> From below it looks like f(x) - f(X*) is estimated as gnorm*gnorm?
>
> } else if (gnorm2 <= fatol && cnorm <=catol) {
> ierr = PetscInfo2(tao,"Converged due to estimated f(X) - f(X*) = %g <
> %g\n",(double)gnorm2,(double)fatol);CHKERRQ(ierr);
> reason = TAO_CONVERGED_FATOL;
> } else if (f != 0 && gnorm2 / PetscAbsReal(f)<= frtol &&
> cnorm/PetscMax(cnorm0,1.0) <= crtol) {
> ierr = PetscInfo2(tao,"Converged due to estimated |f(X)-f(X*)|/f(X) =
> %g < %g\n",(double)(gnorm2/PetscAbsReal(f)),(double)frtol);CHKERRQ(ierr);
> reason = TAO_CONVERGED_FRTOL;
>
> It seems the next test is the same as the first I list above exact gnorm
> is not squared? Why is it worth having this duplicate test?
>
> } else if (gnorm<= gatol && cnorm <=catol) {
> ierr = PetscInfo2(tao,"Converged due to residual norm ||g(X)||=%g <
> %g\n",(double)gnorm,(double)gatol);CHKERRQ(ierr);
> reason = TAO_CONVERGED_GATOL;
>
> At a minimum the manual page should document what f(X) - f(X*)
> (estimated) means.
>
> Barry
>
> } else if ( f!=0 && PetscAbsReal(gnorm/f) <= grtol && cnorm <= crtol) {
> ierr = PetscInfo2(tao,"Converged due to residual ||g(X)||/|f(X)| =%g <
> %g\n",(double)(gnorm/f),(double)grtol);CHKERRQ(ierr);
>
>
1
0
08 Sep '15
Barry,
I amended this commit - and removed that section of code, and pushed
my change. [to pr352/dmay/pctelescope/master and merged to next]
[I did this ammend - as this commit didn't propogage to next or master]
[Assuming you haven't added anything else to this branch] Can you do
the following - to get this 'amended' commit cleanly - and discard the
previous commit in your branch.
git checkout pr352/dmay/pctelescope/master
git fetch
git reset --hard origin/pr352/dmay/pctelescope/master
Thanks,
Satish
On Tue, 8 Sep 2015, Barry Smith wrote:
>
> Satish,
>
> Likely it is wrong. I was forced by git to do some strange merge that produced that result. I can't explain why it happened.
>
> Feel free to fix the branch and master
>
>
> Barry
>
> > On Sep 8, 2015, at 11:25 PM, Satish Balay <balay(a)mcs.anl.gov> wrote:
> >
> > Barry,
> >
> >
> > I don't understand the commit https://bitbucket.org/petsc/petsc/commits/3dcc747d65aa2f2e79d189bef52568da1…
> >
> >>>>>>
> > -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v)
> > +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v)
> > {
> > PetscTryMethod(pc,"PCTelescopeSetIgnoreDM_C",(PC,PetscBool),(pc,v));
> > return(0);
> > <<<<<<<<
> >
> > This reverts the change I made earlier - which was required to compile
> > code [otherwise (PetscBool)(PetscInt) is flaged as compiler error]
> >
> >
> >>>>> -PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscInt);
> >>>>> +PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscBool);
> >
> >>>>> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v)
> >>>>> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v)
> >
> > Satish
> >
> > On Tue, 8 Sep 2015, Barry Smith wrote:
> >
> >>
> >> Done. But I may have messed up the history a little
> >>
> >>> On Sep 8, 2015, at 4:28 PM, Satish Balay <balay(a)mcs.anl.gov> wrote:
> >>>
> >>> Barry,
> >>>
> >>> I see you made some changes to pr352/dmay/pctelescope/master and merged to next [and pushed]
> >>>
> >>> However - you did not push pr352/dmay/pctelescope/master. Could you push this branch?
> >>>
> >>> I have fix for the following warnings - and would like to push my changes..
> >>>
> >>> [Just want to make sure all changes are in sync]
> >>>
> >>>
> >>> thanks,
> >>> Satish
> >>> --------
> >>>
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetKSP':
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:654: warning: statement with no effect
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetReductionFactor':
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:675: warning: statement with no effect
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeSetReductionFactor':
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:696: warning: statement with no effect
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetIgnoreDM':
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:717: warning: statement with no effect
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeSetIgnoreDM':
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:738: warning: statement with no effect
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetDM':
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:759: warning: statement with no effect
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCSetUp_Telescope':
> >>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:352: warning: 'subcomm' may be used uninitialized in this function
> >>>
> >>> On Tue, 8 Sep 2015, Satish Balay wrote:
> >>>
> >>>> Ok - pushed to pr352/dmay/pctelescope/master - and merged to next
> >>>>
> >>>> https://bitbucket.org/petsc/petsc/commits/bfd6bcc6ac8e2f0022fa8b00b8cd29f3a…
> >>>>
> >>>> [please before further changes - or merge to master]
> >>>>
> >>>> Satish
> >>>>
> >>>> On Tue, 8 Sep 2015, Satish Balay wrote:
> >>>>
> >>>>> I haven't check the examples - but I have the following fix for the build. Will push now
> >>>>>
> >>>>> Satish
> >>>>>
> >>>>> diff --git a/include/petscpc.h b/include/petscpc.h
> >>>>> index 7e583b8..0cddc86 100644
> >>>>> --- a/include/petscpc.h
> >>>>> +++ b/include/petscpc.h
> >>>>> @@ -324,7 +324,7 @@ PETSC_EXTERN PetscErrorCode PCMGResidualDefault(Mat,Vec,Vec,Vec);
> >>>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetReductionFactor(PC,PetscInt*);
> >>>>> PETSC_EXTERN PetscErrorCode PCTelescopeSetReductionFactor(PC,PetscInt);
> >>>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetIgnoreDM(PC,PetscBool*);
> >>>>> -PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscInt);
> >>>>> +PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscBool);
> >>>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetDM(PC,DM*);
> >>>>>
> >>>>> #endif /* __PETSCPC_H */
> >>>>> diff --git a/src/ksp/pc/impls/telescope/telescope.c b/src/ksp/pc/impls/telescope/telescope.c
> >>>>> index 5e899de..fe75c46 100644
> >>>>> --- a/src/ksp/pc/impls/telescope/telescope.c
> >>>>> +++ b/src/ksp/pc/impls/telescope/telescope.c
> >>>>> @@ -207,7 +207,7 @@ PetscErrorCode PCTelescopeMatCreate_default(PC pc,PC_Telescope sred,MatReuse reu
> >>>>> if (reuse != MAT_INITIAL_MATRIX) { Bred = *A; }
> >>>>>
> >>>>> ierr = MatGetSize(Blocal,&mm,NULL);CHKERRQ(ierr);
> >>>>> - //ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr);
> >>>>> + /* ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); */
> >>>>> ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,mm,reuse,&Bred);CHKERRQ(ierr);
> >>>>> }
> >>>>> *A = Bred;
> >>>>> @@ -734,7 +734,7 @@ PetscErrorCode PCTelescopeGetIgnoreDM(PC pc,PetscBool *v)
> >>>>>
> >>>>> .keywords: PC, telescoping solve
> >>>>> @*/
> >>>>> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v)
> >>>>> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v)
> >>>>> {
> >>>>> PetscTryMethod(pc,"PCTelescopeSetIgnoreDM_C",(PC,PetscBool),(pc,v));
> >>>>> return(0);
> >>>>> diff --git a/src/ksp/pc/impls/telescope/telescope_dmda.c b/src/ksp/pc/impls/telescope/telescope_dmda.c
> >>>>> index edd1708..98d0c7f 100644
> >>>>> --- a/src/ksp/pc/impls/telescope/telescope_dmda.c
> >>>>> +++ b/src/ksp/pc/impls/telescope/telescope_dmda.c
> >>>>> @@ -757,7 +757,7 @@ PetscErrorCode PCTelescopeMatCreate_dmda(PC pc,PC_Telescope sred,MatReuse reuse,
> >>>>>
> >>>>> if (reuse != MAT_INITIAL_MATRIX) {Bred = *A;}
> >>>>> ierr = MatGetSize(Blocal,&mm,NULL);CHKERRQ(ierr);
> >>>>> - //ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr);
> >>>>> + /* ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); */
> >>>>> ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,mm,reuse,&Bred);CHKERRQ(ierr);
> >>>>> }
> >>>>> *A = Bred;
> >>>>>
> >>>>>
> >>>>> On Tue, 8 Sep 2015, Barry Smith wrote:
> >>>>>
> >>>>>>
> >>>>>> Dave,
> >>>>>>
> >>>>>> I'll be fixing these.
> >>>>>>
> >>>>>> Barry
> >>>>>>
> >>>>>>> On Sep 8, 2015, at 9:00 AM, PETSc checkBuilds <petsc-checkbuilds(a)mcs.anl.gov> wrote:
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> Dear PETSc developer,
> >>>>>>>
> >>>>>>> This email contains listings of contributions attributed to you by
> >>>>>>> `git blame` that caused compiler errors or warnings in PETSc automated
> >>>>>>> testing. Follow the links to see the full log files. Please attempt to fix
> >>>>>>> the issues promptly or let us know at petsc-dev(a)mcs.anl.gov if you are unable
> >>>>>>> to resolve the issues.
> >>>>>>>
> >>>>>>> Thanks,
> >>>>>>> The PETSc development team
> >>>>>>>
> >>>>>>> ----
> >>>>>>>
> >>>>>>> warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/6ab51f8
> >>>>>>> PCSemiRedundant:
> >>>>>>>
> >>>>>>> src/ksp/pc/impls/telescope/telescope.c:116
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope.c:116:3: warning: 'subdm' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>>>>>>
> >>>>>>> src/ksp/pc/impls/telescope/telescope.c:210
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope.c:210:5: error: expected expression before '/' token
> >>>>>>>
> >>>>>>> src/ksp/pc/impls/telescope/telescope.c:380
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope.c:380:12: warning: 'subcomm' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>>>>>>
> >>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:112
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:112:18: warning: 'start_IJK' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:112:7: warning: 'start_IJK' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>>>>>>
> >>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:535
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/balay/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /home/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/balay/petsc.clone-4/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/balay/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>>
> >>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:609
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/balay/petsc.clone-4/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/balay/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /home/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/balay/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>>>
> >>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:760
> >>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:760:5: error: expected expression before '/' token
> >>>>>>>
> >>>>>>> ----
> >>>>>>> To opt-out from receiving these messages - send a request to petsc-dev(a)mcs.anl.gov.
> >>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>
> >>
> >>
> >
>
>
1
0
08 Sep '15
Satish,
Likely it is wrong. I was forced by git to do some strange merge that produced that result. I can't explain why it happened.
Feel free to fix the branch and master
Barry
> On Sep 8, 2015, at 11:25 PM, Satish Balay <balay(a)mcs.anl.gov> wrote:
>
> Barry,
>
>
> I don't understand the commit https://bitbucket.org/petsc/petsc/commits/3dcc747d65aa2f2e79d189bef52568da1…
>
>>>>>>
> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v)
> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v)
> {
> PetscTryMethod(pc,"PCTelescopeSetIgnoreDM_C",(PC,PetscBool),(pc,v));
> return(0);
> <<<<<<<<
>
> This reverts the change I made earlier - which was required to compile
> code [otherwise (PetscBool)(PetscInt) is flaged as compiler error]
>
>
>>>>> -PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscInt);
>>>>> +PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscBool);
>
>>>>> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v)
>>>>> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v)
>
> Satish
>
> On Tue, 8 Sep 2015, Barry Smith wrote:
>
>>
>> Done. But I may have messed up the history a little
>>
>>> On Sep 8, 2015, at 4:28 PM, Satish Balay <balay(a)mcs.anl.gov> wrote:
>>>
>>> Barry,
>>>
>>> I see you made some changes to pr352/dmay/pctelescope/master and merged to next [and pushed]
>>>
>>> However - you did not push pr352/dmay/pctelescope/master. Could you push this branch?
>>>
>>> I have fix for the following warnings - and would like to push my changes..
>>>
>>> [Just want to make sure all changes are in sync]
>>>
>>>
>>> thanks,
>>> Satish
>>> --------
>>>
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetKSP':
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:654: warning: statement with no effect
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetReductionFactor':
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:675: warning: statement with no effect
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeSetReductionFactor':
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:696: warning: statement with no effect
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetIgnoreDM':
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:717: warning: statement with no effect
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeSetIgnoreDM':
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:738: warning: statement with no effect
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetDM':
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:759: warning: statement with no effect
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCSetUp_Telescope':
>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:352: warning: 'subcomm' may be used uninitialized in this function
>>>
>>> On Tue, 8 Sep 2015, Satish Balay wrote:
>>>
>>>> Ok - pushed to pr352/dmay/pctelescope/master - and merged to next
>>>>
>>>> https://bitbucket.org/petsc/petsc/commits/bfd6bcc6ac8e2f0022fa8b00b8cd29f3a…
>>>>
>>>> [please before further changes - or merge to master]
>>>>
>>>> Satish
>>>>
>>>> On Tue, 8 Sep 2015, Satish Balay wrote:
>>>>
>>>>> I haven't check the examples - but I have the following fix for the build. Will push now
>>>>>
>>>>> Satish
>>>>>
>>>>> diff --git a/include/petscpc.h b/include/petscpc.h
>>>>> index 7e583b8..0cddc86 100644
>>>>> --- a/include/petscpc.h
>>>>> +++ b/include/petscpc.h
>>>>> @@ -324,7 +324,7 @@ PETSC_EXTERN PetscErrorCode PCMGResidualDefault(Mat,Vec,Vec,Vec);
>>>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetReductionFactor(PC,PetscInt*);
>>>>> PETSC_EXTERN PetscErrorCode PCTelescopeSetReductionFactor(PC,PetscInt);
>>>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetIgnoreDM(PC,PetscBool*);
>>>>> -PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscInt);
>>>>> +PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscBool);
>>>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetDM(PC,DM*);
>>>>>
>>>>> #endif /* __PETSCPC_H */
>>>>> diff --git a/src/ksp/pc/impls/telescope/telescope.c b/src/ksp/pc/impls/telescope/telescope.c
>>>>> index 5e899de..fe75c46 100644
>>>>> --- a/src/ksp/pc/impls/telescope/telescope.c
>>>>> +++ b/src/ksp/pc/impls/telescope/telescope.c
>>>>> @@ -207,7 +207,7 @@ PetscErrorCode PCTelescopeMatCreate_default(PC pc,PC_Telescope sred,MatReuse reu
>>>>> if (reuse != MAT_INITIAL_MATRIX) { Bred = *A; }
>>>>>
>>>>> ierr = MatGetSize(Blocal,&mm,NULL);CHKERRQ(ierr);
>>>>> - //ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr);
>>>>> + /* ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); */
>>>>> ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,mm,reuse,&Bred);CHKERRQ(ierr);
>>>>> }
>>>>> *A = Bred;
>>>>> @@ -734,7 +734,7 @@ PetscErrorCode PCTelescopeGetIgnoreDM(PC pc,PetscBool *v)
>>>>>
>>>>> .keywords: PC, telescoping solve
>>>>> @*/
>>>>> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v)
>>>>> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v)
>>>>> {
>>>>> PetscTryMethod(pc,"PCTelescopeSetIgnoreDM_C",(PC,PetscBool),(pc,v));
>>>>> return(0);
>>>>> diff --git a/src/ksp/pc/impls/telescope/telescope_dmda.c b/src/ksp/pc/impls/telescope/telescope_dmda.c
>>>>> index edd1708..98d0c7f 100644
>>>>> --- a/src/ksp/pc/impls/telescope/telescope_dmda.c
>>>>> +++ b/src/ksp/pc/impls/telescope/telescope_dmda.c
>>>>> @@ -757,7 +757,7 @@ PetscErrorCode PCTelescopeMatCreate_dmda(PC pc,PC_Telescope sred,MatReuse reuse,
>>>>>
>>>>> if (reuse != MAT_INITIAL_MATRIX) {Bred = *A;}
>>>>> ierr = MatGetSize(Blocal,&mm,NULL);CHKERRQ(ierr);
>>>>> - //ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr);
>>>>> + /* ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); */
>>>>> ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,mm,reuse,&Bred);CHKERRQ(ierr);
>>>>> }
>>>>> *A = Bred;
>>>>>
>>>>>
>>>>> On Tue, 8 Sep 2015, Barry Smith wrote:
>>>>>
>>>>>>
>>>>>> Dave,
>>>>>>
>>>>>> I'll be fixing these.
>>>>>>
>>>>>> Barry
>>>>>>
>>>>>>> On Sep 8, 2015, at 9:00 AM, PETSc checkBuilds <petsc-checkbuilds(a)mcs.anl.gov> wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Dear PETSc developer,
>>>>>>>
>>>>>>> This email contains listings of contributions attributed to you by
>>>>>>> `git blame` that caused compiler errors or warnings in PETSc automated
>>>>>>> testing. Follow the links to see the full log files. Please attempt to fix
>>>>>>> the issues promptly or let us know at petsc-dev(a)mcs.anl.gov if you are unable
>>>>>>> to resolve the issues.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> The PETSc development team
>>>>>>>
>>>>>>> ----
>>>>>>>
>>>>>>> warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/6ab51f8
>>>>>>> PCSemiRedundant:
>>>>>>>
>>>>>>> src/ksp/pc/impls/telescope/telescope.c:116
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope.c:116:3: warning: 'subdm' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>>>>>
>>>>>>> src/ksp/pc/impls/telescope/telescope.c:210
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope.c:210:5: error: expected expression before '/' token
>>>>>>>
>>>>>>> src/ksp/pc/impls/telescope/telescope.c:380
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope.c:380:12: warning: 'subcomm' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>>>>>
>>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:112
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:112:18: warning: 'start_IJK' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:112:7: warning: 'start_IJK' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>>>>>
>>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:535
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/balay/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /home/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/balay/petsc.clone-4/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/balay/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>>
>>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:609
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/balay/petsc.clone-4/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/balay/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /home/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/balay/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>>>
>>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:760
>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:760:5: error: expected expression before '/' token
>>>>>>>
>>>>>>> ----
>>>>>>> To opt-out from receiving these messages - send a request to petsc-dev(a)mcs.anl.gov.
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>
1
0
08 Sep '15
Barry,
I don't understand the commit https://bitbucket.org/petsc/petsc/commits/3dcc747d65aa2f2e79d189bef52568da1…
>>>>>
-PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v)
+PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v)
{
PetscTryMethod(pc,"PCTelescopeSetIgnoreDM_C",(PC,PetscBool),(pc,v));
return(0);
<<<<<<<<
This reverts the change I made earlier - which was required to compile
code [otherwise (PetscBool)(PetscInt) is flaged as compiler error]
> >>> -PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscInt);
> >>> +PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscBool);
> >>> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v)
> >>> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v)
Satish
On Tue, 8 Sep 2015, Barry Smith wrote:
>
> Done. But I may have messed up the history a little
>
> > On Sep 8, 2015, at 4:28 PM, Satish Balay <balay(a)mcs.anl.gov> wrote:
> >
> > Barry,
> >
> > I see you made some changes to pr352/dmay/pctelescope/master and merged to next [and pushed]
> >
> > However - you did not push pr352/dmay/pctelescope/master. Could you push this branch?
> >
> > I have fix for the following warnings - and would like to push my changes..
> >
> > [Just want to make sure all changes are in sync]
> >
> >
> > thanks,
> > Satish
> > --------
> >
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetKSP':
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:654: warning: statement with no effect
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetReductionFactor':
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:675: warning: statement with no effect
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeSetReductionFactor':
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:696: warning: statement with no effect
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetIgnoreDM':
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:717: warning: statement with no effect
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeSetIgnoreDM':
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:738: warning: statement with no effect
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetDM':
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:759: warning: statement with no effect
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCSetUp_Telescope':
> > /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:352: warning: 'subcomm' may be used uninitialized in this function
> >
> > On Tue, 8 Sep 2015, Satish Balay wrote:
> >
> >> Ok - pushed to pr352/dmay/pctelescope/master - and merged to next
> >>
> >> https://bitbucket.org/petsc/petsc/commits/bfd6bcc6ac8e2f0022fa8b00b8cd29f3a…
> >>
> >> [please before further changes - or merge to master]
> >>
> >> Satish
> >>
> >> On Tue, 8 Sep 2015, Satish Balay wrote:
> >>
> >>> I haven't check the examples - but I have the following fix for the build. Will push now
> >>>
> >>> Satish
> >>>
> >>> diff --git a/include/petscpc.h b/include/petscpc.h
> >>> index 7e583b8..0cddc86 100644
> >>> --- a/include/petscpc.h
> >>> +++ b/include/petscpc.h
> >>> @@ -324,7 +324,7 @@ PETSC_EXTERN PetscErrorCode PCMGResidualDefault(Mat,Vec,Vec,Vec);
> >>> PETSC_EXTERN PetscErrorCode PCTelescopeGetReductionFactor(PC,PetscInt*);
> >>> PETSC_EXTERN PetscErrorCode PCTelescopeSetReductionFactor(PC,PetscInt);
> >>> PETSC_EXTERN PetscErrorCode PCTelescopeGetIgnoreDM(PC,PetscBool*);
> >>> -PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscInt);
> >>> +PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscBool);
> >>> PETSC_EXTERN PetscErrorCode PCTelescopeGetDM(PC,DM*);
> >>>
> >>> #endif /* __PETSCPC_H */
> >>> diff --git a/src/ksp/pc/impls/telescope/telescope.c b/src/ksp/pc/impls/telescope/telescope.c
> >>> index 5e899de..fe75c46 100644
> >>> --- a/src/ksp/pc/impls/telescope/telescope.c
> >>> +++ b/src/ksp/pc/impls/telescope/telescope.c
> >>> @@ -207,7 +207,7 @@ PetscErrorCode PCTelescopeMatCreate_default(PC pc,PC_Telescope sred,MatReuse reu
> >>> if (reuse != MAT_INITIAL_MATRIX) { Bred = *A; }
> >>>
> >>> ierr = MatGetSize(Blocal,&mm,NULL);CHKERRQ(ierr);
> >>> - //ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr);
> >>> + /* ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); */
> >>> ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,mm,reuse,&Bred);CHKERRQ(ierr);
> >>> }
> >>> *A = Bred;
> >>> @@ -734,7 +734,7 @@ PetscErrorCode PCTelescopeGetIgnoreDM(PC pc,PetscBool *v)
> >>>
> >>> .keywords: PC, telescoping solve
> >>> @*/
> >>> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v)
> >>> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v)
> >>> {
> >>> PetscTryMethod(pc,"PCTelescopeSetIgnoreDM_C",(PC,PetscBool),(pc,v));
> >>> return(0);
> >>> diff --git a/src/ksp/pc/impls/telescope/telescope_dmda.c b/src/ksp/pc/impls/telescope/telescope_dmda.c
> >>> index edd1708..98d0c7f 100644
> >>> --- a/src/ksp/pc/impls/telescope/telescope_dmda.c
> >>> +++ b/src/ksp/pc/impls/telescope/telescope_dmda.c
> >>> @@ -757,7 +757,7 @@ PetscErrorCode PCTelescopeMatCreate_dmda(PC pc,PC_Telescope sred,MatReuse reuse,
> >>>
> >>> if (reuse != MAT_INITIAL_MATRIX) {Bred = *A;}
> >>> ierr = MatGetSize(Blocal,&mm,NULL);CHKERRQ(ierr);
> >>> - //ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr);
> >>> + /* ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); */
> >>> ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,mm,reuse,&Bred);CHKERRQ(ierr);
> >>> }
> >>> *A = Bred;
> >>>
> >>>
> >>> On Tue, 8 Sep 2015, Barry Smith wrote:
> >>>
> >>>>
> >>>> Dave,
> >>>>
> >>>> I'll be fixing these.
> >>>>
> >>>> Barry
> >>>>
> >>>>> On Sep 8, 2015, at 9:00 AM, PETSc checkBuilds <petsc-checkbuilds(a)mcs.anl.gov> wrote:
> >>>>>
> >>>>>
> >>>>>
> >>>>> Dear PETSc developer,
> >>>>>
> >>>>> This email contains listings of contributions attributed to you by
> >>>>> `git blame` that caused compiler errors or warnings in PETSc automated
> >>>>> testing. Follow the links to see the full log files. Please attempt to fix
> >>>>> the issues promptly or let us know at petsc-dev(a)mcs.anl.gov if you are unable
> >>>>> to resolve the issues.
> >>>>>
> >>>>> Thanks,
> >>>>> The PETSc development team
> >>>>>
> >>>>> ----
> >>>>>
> >>>>> warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/6ab51f8
> >>>>> PCSemiRedundant:
> >>>>>
> >>>>> src/ksp/pc/impls/telescope/telescope.c:116
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope.c:116:3: warning: 'subdm' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>>>>
> >>>>> src/ksp/pc/impls/telescope/telescope.c:210
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope.c:210:5: error: expected expression before '/' token
> >>>>>
> >>>>> src/ksp/pc/impls/telescope/telescope.c:380
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope.c:380:12: warning: 'subcomm' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>>>>
> >>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:112
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:112:18: warning: 'start_IJK' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:112:7: warning: 'start_IJK' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>>>>
> >>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:535
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/balay/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /home/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/balay/petsc.clone-4/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/balay/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>
> >>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:609
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/balay/petsc.clone-4/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/balay/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /home/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/balay/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
> >>>>>
> >>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:760
> >>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
> >>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:760:5: error: expected expression before '/' token
> >>>>>
> >>>>> ----
> >>>>> To opt-out from receiving these messages - send a request to petsc-dev(a)mcs.anl.gov.
> >>>>
> >>>>
> >>>
> >>>
> >>
> >>
> >
>
>
1
0
Jason,
Perhaps it is just documentation.
/*@
TaoSetTolerances - Sets parameters used in TAO convergence tests
Logically collective on Tao
Input Parameters:
+ tao - the Tao context
. fatol - absolute convergence tolerance
. frtol - relative convergence tolerance
. gatol - stop if norm of gradient is less than this
. grtol - stop if relative norm of gradient is less than this
- gttol - stop if norm of gradient is reduced by this factor
Options Database Keys:
+ -tao_fatol <fatol> - Sets fatol
. -tao_frtol <frtol> - Sets frtol
. -tao_gatol <gatol> - Sets gatol
. -tao_grtol <grtol> - Sets grtol
- -tao_gttol <gttol> - Sets gttol
Stopping Criteria:
$ f(X) - f(X*) (estimated) <= fatol
$ |f(X) - f(X*)| (estimated) / |f(X)| <= frtol
$ ||g(X)|| <= gatol
$ ||g(X)|| / |f(X)| <= grtol
$ ||g(X)|| / ||g(X0)|| <= gttol
How is f(x) - f(X*) (estimated) and how come the second definition has absolute values but the first does not?
From below it looks like f(x) - f(X*) is estimated as gnorm*gnorm?
} else if (gnorm2 <= fatol && cnorm <=catol) {
ierr = PetscInfo2(tao,"Converged due to estimated f(X) - f(X*) = %g < %g\n",(double)gnorm2,(double)fatol);CHKERRQ(ierr);
reason = TAO_CONVERGED_FATOL;
} else if (f != 0 && gnorm2 / PetscAbsReal(f)<= frtol && cnorm/PetscMax(cnorm0,1.0) <= crtol) {
ierr = PetscInfo2(tao,"Converged due to estimated |f(X)-f(X*)|/f(X) = %g < %g\n",(double)(gnorm2/PetscAbsReal(f)),(double)frtol);CHKERRQ(ierr);
reason = TAO_CONVERGED_FRTOL;
It seems the next test is the same as the first I list above exact gnorm is not squared? Why is it worth having this duplicate test?
} else if (gnorm<= gatol && cnorm <=catol) {
ierr = PetscInfo2(tao,"Converged due to residual norm ||g(X)||=%g < %g\n",(double)gnorm,(double)gatol);CHKERRQ(ierr);
reason = TAO_CONVERGED_GATOL;
At a minimum the manual page should document what f(X) - f(X*) (estimated) means.
Barry
} else if ( f!=0 && PetscAbsReal(gnorm/f) <= grtol && cnorm <= crtol) {
ierr = PetscInfo2(tao,"Converged due to residual ||g(X)||/|f(X)| =%g < %g\n",(double)(gnorm/f),(double)grtol);CHKERRQ(ierr);
1
0
08 Sep '15
Ulrike Yang <umyang(a)llnl.gov> added the comment:
Hi Barry,
Thanks for finding this problem.
We will get it fixed for the next release.
Ulrike
----------
status: unread -> chatting
_____________________________________________
hypre Issue Tracker <hypre-support(a)llnl.gov>
<http://tux273.llnl.gov:8070/hypre/issue1342>
_____________________________________________
1
0
petsc@crank:/sandbox/petsc/petsc.test/src/ksp/ksp/examples/tutorials$ /sandbox/petsc/petsc.test/bin/petscmpiexec -valgrind -n 3 ./ex10 -pc_type hypre -pc_hypre_type parasails -f0 ${DATAFILESPATH}/matrices/medium
==12918== Use of uninitialised value of size 8
==12918== at 0x5C2CDD1: DiagScaleCreate (DiagScale.c:129)
==12918== by 0x5BB8733: ParaSailsSetupPattern (ParaSails.c:1678)
==12918== by 0x5BB4D9E: hypre_ParaSailsSetup (hypre_ParaSails.c:227)
==12918== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12918== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12918== by 0x559714A: PCSetUp (precon.c:984)
==12918== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12918== by 0x40525E: main (ex10.c:312)
==12918== Uninitialised value was created by a heap allocation
==12918== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==12918== by 0x5BB6D32: MemAlloc (Mem.c:108)
==12918== by 0x5C2CD69: DiagScaleCreate (DiagScale.c:120)
==12918== by 0x5BB8733: ParaSailsSetupPattern (ParaSails.c:1678)
==12918== by 0x5BB4D9E: hypre_ParaSailsSetup (hypre_ParaSails.c:227)
==12918== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12918== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12918== by 0x559714A: PCSetUp (precon.c:984)
==12918== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12918== by 0x40525E: main (ex10.c:312)
==12918==
==12924== Conditional jump or move depends on uninitialised value(s)
==12924== at 0x5BBB160: PrunedRowsCreate (PrunedRows.c:71)
==12924== by 0x5BB8791: ParaSailsSetupPattern (ParaSails.c:1683)
==12924== by 0x5BB4D9E: hypre_ParaSailsSetup (hypre_ParaSails.c:227)
==12924== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12924== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12924== by 0x559714A: PCSetUp (precon.c:984)
==12924== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12924== by 0x40525E: main (ex10.c:312)
==12924== Uninitialised value was created by a heap allocation
==12924== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==12924== by 0x5C2CACD: DiagScaleCreate (DiagScale.c:190)
==12924== by 0x5BB8733: ParaSailsSetupPattern (ParaSails.c:1678)
==12924== by 0x5BB4D9E: hypre_ParaSailsSetup (hypre_ParaSails.c:227)
==12924== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12924== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12924== by 0x559714A: PCSetUp (precon.c:984)
==12924== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12924== by 0x40525E: main (ex10.c:312)
==12924==
==12924== Conditional jump or move depends on uninitialised value(s)
==12924== at 0x5BBB219: PrunedRowsCreate (PrunedRows.c:84)
==12924== by 0x5BB8791: ParaSailsSetupPattern (ParaSails.c:1683)
==12924== by 0x5BB4D9E: hypre_ParaSailsSetup (hypre_ParaSails.c:227)
==12924== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12924== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12924== by 0x559714A: PCSetUp (precon.c:984)
==12924== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12924== by 0x40525E: main (ex10.c:312)
==12924== Uninitialised value was created by a heap allocation
==12924== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==12924== by 0x5C2CACD: DiagScaleCreate (DiagScale.c:190)
==12924== by 0x5BB8733: ParaSailsSetupPattern (ParaSails.c:1678)
==12924== by 0x5BB4D9E: hypre_ParaSailsSetup (hypre_ParaSails.c:227)
==12924== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12924== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12924== by 0x559714A: PCSetUp (precon.c:984)
==12924== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12924== by 0x40525E: main (ex10.c:312)
==12924==
==12917== Conditional jump or move depends on uninitialised value(s)
==12917== at 0x5BBB160: PrunedRowsCreate (PrunedRows.c:71)
==12917== by 0x5BB8791: ParaSailsSetupPattern (ParaSails.c:1683)
==12917== by 0x5BB4D9E: hypre_ParaSailsSetup (hypre_ParaSails.c:227)
==12917== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12917== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12917== by 0x559714A: PCSetUp (precon.c:984)
==12917== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12917== by 0x40525E: main (ex10.c:312)
==12917== Uninitialised value was created by a heap allocation
==12917== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==12917== by 0x5C2CACD: DiagScaleCreate (DiagScale.c:190)
==12917== by 0x5BB8733: ParaSailsSetupPattern (ParaSails.c:1678)
==12917== by 0x5BB4D9E: hypre_ParaSailsSetup (hypre_ParaSails.c:227)
==12917== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12917== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12917== by 0x559714A: PCSetUp (precon.c:984)
==12917== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12917== by 0x40525E: main (ex10.c:312)
==12917==
==12917== Conditional jump or move depends on uninitialised value(s)
==12917== at 0x5BBB219: PrunedRowsCreate (PrunedRows.c:84)
==12917== by 0x5BB8791: ParaSailsSetupPattern (ParaSails.c:1683)
==12917== by 0x5BB4D9E: hypre_ParaSailsSetup (hypre_ParaSails.c:227)
==12917== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12917== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12917== by 0x559714A: PCSetUp (precon.c:984)
==12917== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12917== by 0x40525E: main (ex10.c:312)
==12917== Uninitialised value was created by a heap allocation
==12917== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==12917== by 0x5C2CACD: DiagScaleCreate (DiagScale.c:190)
==12917== by 0x5BB8733: ParaSailsSetupPattern (ParaSails.c:1678)
==12917== by 0x5BB4D9E: hypre_ParaSailsSetup (hypre_ParaSails.c:227)
==12917== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12917== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12917== by 0x559714A: PCSetUp (precon.c:984)
==12917== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12917== by 0x40525E: main (ex10.c:312)
==12917==
==12917== Use of uninitialised value of size 8
==12917== at 0x5C2CDD1: DiagScaleCreate (DiagScale.c:129)
==12917== by 0x5BBA287: ParaSailsSetupValues (ParaSails.c:1844)
==12917== by 0x5BB4E1C: hypre_ParaSailsSetup (hypre_ParaSails.c:234)
==12917== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12917== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12917== by 0x559714A: PCSetUp (precon.c:984)
==12917== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12917== by 0x40525E: main (ex10.c:312)
==12917== Uninitialised value was created by a heap allocation
==12917== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==12917== by 0x5BB6D32: MemAlloc (Mem.c:108)
==12917== by 0x5C2CD69: DiagScaleCreate (DiagScale.c:120)
==12917== by 0x5BBA287: ParaSailsSetupValues (ParaSails.c:1844)
==12917== by 0x5BB4E1C: hypre_ParaSailsSetup (hypre_ParaSails.c:234)
==12917== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12917== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12917== by 0x559714A: PCSetUp (precon.c:984)
==12917== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12917== by 0x40525E: main (ex10.c:312)
==12917==
==12917== Invalid read of size 8
==12917== at 0x5C2CDD1: DiagScaleCreate (DiagScale.c:129)
==12917== by 0x5BBA287: ParaSailsSetupValues (ParaSails.c:1844)
==12917== by 0x5BB4E1C: hypre_ParaSailsSetup (hypre_ParaSails.c:234)
==12917== by 0x5AD9357: HYPRE_ParaSailsSetup (HYPRE_parcsr_ParaSails.c:372)
==12917== by 0x56A3ECC: PCSetUp_HYPRE (hypre.c:208)
==12917== by 0x559714A: PCSetUp (precon.c:984)
==12917== by 0x56AEEC7: KSPSetUp (itfunc.c:332)
==12917== by 0x40525E: main (ex10.c:312)
==12917== Address 0x213b27498 is not stack'd, malloc'd or (recently) free'd
==12917==
[0]PETSC ERROR: ------------------------------------------------------------------------
[0]PETSC ERROR: Caught signal number 11 SEGV: Segmentation Violation, probably memory access out of range
[0]PETSC ERROR: Try option -start_in_debugger or -on_error_attach_debugger
[0]PETSC ERROR: or see http://www.mcs.anl.gov/petsc/documentation/faq.html#valgrind
[0]PETSC ERROR: or try http://valgrind.org on GNU/linux and Apple Mac OS X to find memory corruption errors
[0]PETSC ERROR: configure using --with-debugging=yes, recompile, link, and run
[0]PETSC ERROR: to get more information on the crash.
[0]PETSC ERROR: --------------------- Error Message ------------------------------------------
Looking at the code there appears to be a problem. The routine first does a probe which gives a source and a count, you then allocate the space, but then you do a
hypre_MPI_Recv(recvbuf, count, HYPRE_MPI_INT, hypre_MPI_ANY_SOURCE, ...
but use hypre_MPI_ANY_SOURCE instead of source as the source. Thus you might get a different message (with a different length) then the probe found. I think you need to pass source instead of hypre_MPI_ANY_SOURCE here. Note that other places in the same directory where you use Probe you always use the source to receive on. When I make this change in my copy of hypre the problem goes away.
Barry
static void ExchangeDiagEntriesServer(MPI_Comm comm, Matrix *mat,
HYPRE_Real *local_diags, HYPRE_Int num_requests, Mem *mem, hypre_MPI_Request *requests)
{
hypre_MPI_Status status;
HYPRE_Int *recvbuf;
HYPRE_Real *sendbuf;
HYPRE_Int i, j, source, count;
/* recvbuf contains requested indices */
/* sendbuf contains corresponding diagonal entries */
for (i=0; i<num_requests; i++)
{
hypre_MPI_Probe(hypre_MPI_ANY_SOURCE, DIAG_INDS_TAG, comm, &status);
source = status.hypre_MPI_SOURCE;
hypre_MPI_Get_count(&status, HYPRE_MPI_INT, &count);
recvbuf = (HYPRE_Int *) MemAlloc(mem, count*sizeof(HYPRE_Int));
sendbuf = (HYPRE_Real *) MemAlloc(mem, count*sizeof(HYPRE_Real));
hypre_MPI_Recv(recvbuf, count, HYPRE_MPI_INT, hypre_MPI_ANY_SOURCE,
DIAG_INDS_TAG, comm, &status);
source = status.hypre_MPI_SOURCE;
/* Construct reply message of diagonal entries in sendbuf */
for (j=0; j<count; j++)
sendbuf[j] = local_diags[recvbuf[j] - mat->beg_row];
/* Use ready-mode send, since receives already posted */
hypre_MPI_Irsend(sendbuf, count, hypre_MPI_DOUBLE, source,
DIAG_VALS_TAG, comm, &requests[i]);
}
}
1
0
08 Sep '15
Done. But I may have messed up the history a little
> On Sep 8, 2015, at 4:28 PM, Satish Balay <balay(a)mcs.anl.gov> wrote:
>
> Barry,
>
> I see you made some changes to pr352/dmay/pctelescope/master and merged to next [and pushed]
>
> However - you did not push pr352/dmay/pctelescope/master. Could you push this branch?
>
> I have fix for the following warnings - and would like to push my changes..
>
> [Just want to make sure all changes are in sync]
>
>
> thanks,
> Satish
> --------
>
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetKSP':
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:654: warning: statement with no effect
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetReductionFactor':
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:675: warning: statement with no effect
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeSetReductionFactor':
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:696: warning: statement with no effect
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetIgnoreDM':
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:717: warning: statement with no effect
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeSetIgnoreDM':
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:738: warning: statement with no effect
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetDM':
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:759: warning: statement with no effect
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCSetUp_Telescope':
> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:352: warning: 'subcomm' may be used uninitialized in this function
>
> On Tue, 8 Sep 2015, Satish Balay wrote:
>
>> Ok - pushed to pr352/dmay/pctelescope/master - and merged to next
>>
>> https://bitbucket.org/petsc/petsc/commits/bfd6bcc6ac8e2f0022fa8b00b8cd29f3a…
>>
>> [please before further changes - or merge to master]
>>
>> Satish
>>
>> On Tue, 8 Sep 2015, Satish Balay wrote:
>>
>>> I haven't check the examples - but I have the following fix for the build. Will push now
>>>
>>> Satish
>>>
>>> diff --git a/include/petscpc.h b/include/petscpc.h
>>> index 7e583b8..0cddc86 100644
>>> --- a/include/petscpc.h
>>> +++ b/include/petscpc.h
>>> @@ -324,7 +324,7 @@ PETSC_EXTERN PetscErrorCode PCMGResidualDefault(Mat,Vec,Vec,Vec);
>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetReductionFactor(PC,PetscInt*);
>>> PETSC_EXTERN PetscErrorCode PCTelescopeSetReductionFactor(PC,PetscInt);
>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetIgnoreDM(PC,PetscBool*);
>>> -PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscInt);
>>> +PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscBool);
>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetDM(PC,DM*);
>>>
>>> #endif /* __PETSCPC_H */
>>> diff --git a/src/ksp/pc/impls/telescope/telescope.c b/src/ksp/pc/impls/telescope/telescope.c
>>> index 5e899de..fe75c46 100644
>>> --- a/src/ksp/pc/impls/telescope/telescope.c
>>> +++ b/src/ksp/pc/impls/telescope/telescope.c
>>> @@ -207,7 +207,7 @@ PetscErrorCode PCTelescopeMatCreate_default(PC pc,PC_Telescope sred,MatReuse reu
>>> if (reuse != MAT_INITIAL_MATRIX) { Bred = *A; }
>>>
>>> ierr = MatGetSize(Blocal,&mm,NULL);CHKERRQ(ierr);
>>> - //ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr);
>>> + /* ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); */
>>> ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,mm,reuse,&Bred);CHKERRQ(ierr);
>>> }
>>> *A = Bred;
>>> @@ -734,7 +734,7 @@ PetscErrorCode PCTelescopeGetIgnoreDM(PC pc,PetscBool *v)
>>>
>>> .keywords: PC, telescoping solve
>>> @*/
>>> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v)
>>> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v)
>>> {
>>> PetscTryMethod(pc,"PCTelescopeSetIgnoreDM_C",(PC,PetscBool),(pc,v));
>>> return(0);
>>> diff --git a/src/ksp/pc/impls/telescope/telescope_dmda.c b/src/ksp/pc/impls/telescope/telescope_dmda.c
>>> index edd1708..98d0c7f 100644
>>> --- a/src/ksp/pc/impls/telescope/telescope_dmda.c
>>> +++ b/src/ksp/pc/impls/telescope/telescope_dmda.c
>>> @@ -757,7 +757,7 @@ PetscErrorCode PCTelescopeMatCreate_dmda(PC pc,PC_Telescope sred,MatReuse reuse,
>>>
>>> if (reuse != MAT_INITIAL_MATRIX) {Bred = *A;}
>>> ierr = MatGetSize(Blocal,&mm,NULL);CHKERRQ(ierr);
>>> - //ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr);
>>> + /* ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); */
>>> ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,mm,reuse,&Bred);CHKERRQ(ierr);
>>> }
>>> *A = Bred;
>>>
>>>
>>> On Tue, 8 Sep 2015, Barry Smith wrote:
>>>
>>>>
>>>> Dave,
>>>>
>>>> I'll be fixing these.
>>>>
>>>> Barry
>>>>
>>>>> On Sep 8, 2015, at 9:00 AM, PETSc checkBuilds <petsc-checkbuilds(a)mcs.anl.gov> wrote:
>>>>>
>>>>>
>>>>>
>>>>> Dear PETSc developer,
>>>>>
>>>>> This email contains listings of contributions attributed to you by
>>>>> `git blame` that caused compiler errors or warnings in PETSc automated
>>>>> testing. Follow the links to see the full log files. Please attempt to fix
>>>>> the issues promptly or let us know at petsc-dev(a)mcs.anl.gov if you are unable
>>>>> to resolve the issues.
>>>>>
>>>>> Thanks,
>>>>> The PETSc development team
>>>>>
>>>>> ----
>>>>>
>>>>> warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/6ab51f8
>>>>> PCSemiRedundant:
>>>>>
>>>>> src/ksp/pc/impls/telescope/telescope.c:116
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope.c:116:3: warning: 'subdm' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>>>
>>>>> src/ksp/pc/impls/telescope/telescope.c:210
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope.c:210:5: error: expected expression before '/' token
>>>>>
>>>>> src/ksp/pc/impls/telescope/telescope.c:380
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope.c:380:12: warning: 'subcomm' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>>>
>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:112
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:112:18: warning: 'start_IJK' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:112:7: warning: 'start_IJK' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>>>
>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:535
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/balay/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /home/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/balay/petsc.clone-4/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/balay/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>
>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:609
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/balay/petsc.clone-4/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/balay/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /home/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/balay/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable]
>>>>>
>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:760
>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…]
>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:760:5: error: expected expression before '/' token
>>>>>
>>>>> ----
>>>>> To opt-out from receiving these messages - send a request to petsc-dev(a)mcs.anl.gov.
>>>>
>>>>
>>>
>>>
>>
>>
>
1
0