September 2015 - petsc-dev - mailman3.cels.anl.gov

broken options handling with intel 16.0 compilers on mac OS
by Blaise A Bourdin 16 Sep '15

16 Sep '15

Hi, I am testing intel 16 compilers under mac OS, and notice that options handling for all past and current versions of petsc is broken in fortran (options are not parsed). I narrowed it down to *argc at start.c:168 always being 0 when intel 16 is used (but taking the right value using intel 15 or gcc 5), but I can’t find my way through the multiple macros to figure out what is really the matter… The problem does not seem to arise under linux with the same compilers. Any idea of what is going on? Any test I can run to help (I assume that you don’t have a test box with the latest intel compilers)? Is it a petsc bug or an intel bug? I use an up to date pets-dev master, and the configure.log file is available at https://filestogeaux.lsu.edu/public/download.php?FILE=bourdin/89329uFByT9 Thanks, Blaise -- Department of Mathematics and Center for Computation & Technology Louisiana State University, Baton Rouge, LA 70803, USA Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin

1 0

Re: [petsc-dev] Nested event logging and human friendly output
by Koos Huijssen 15 Sep '15

15 Sep '15

Dear Barry, Thanks for that. Good luck with the code, I am sure it can be beneficial to many users. With kind regards, Koos On 15-9-2015 1:21, Barry Smith wrote: > I have created a branch with your contribution barry/xml-nested-logging and will see what needs to be done to incorporate it into the PETSc repository. > > Barry > >> On Sep 14, 2015, at 7:45 AM, Koos Huijssen <koos.huijssen(a)vortech.nl> wrote: >> >> Dear PETSc development team, >> >> We have developed an extension of the PETSc event logging facilities that has the following advanced features: >> >> - It allows logging of events in the form of a nested tree. So if some function is called from multiple locations in the code, these instances are distinguished. This in contrast with the standard event logger, which only logs the amount of total call time. >> - It allows the output report to be formatted in XML format. This output can then be viewed in a human-friendly form in a web browser >> with the use of the XSL Transformation script performance_xml2html.xsl. The html features an nested timings tree that can be expanded and collapsed as desired. >> >> This tool has been very useful for us to analyze the code and pinpoint performance bottle necks. We think that it can be useful for others as well, and therefore we are providing the code here for integration in the open source distribution of PETSc. >> >> For more information I refer to the included manual. We have also provided a test program and a makefile for convenience. The test program can be run using MPI with for instance 3-6 processes. >> >> I apologize for not using the git repo to submit the developed code. I also apologize for not adhering to the PETSc coding standards (or at least not as far as I know), but I hope that it is not too far off.. Apart from the whole capital/underscore standardization stuff one issue may require special attention, namely the (ab)use of the format PETSc_VIEWER_ASCII_IMPL for signaling the XML format in XMLViewer.c. I couldn't find an already existing and better fitting format, but it could be necessary to add a new format here for this purpose. >> >> Can you take it up from here and realize the integration of the code in the PETSc distribution? >> >> With kind regards, >> >> Koos Huijssen >> >> -- >> ____________________________________________________________________ >> >> VORtech BV - Scientific software engineers >> ____________________________________________________________________ >> >> Dr.ir. Koos Huijssen >> >> P.O. Box 260 >> 2600 AG Delft >> The Netherlands >> >> phone +31(0)15-285 0125 >> mobile +31(0)6-3333 0803 >> email koos.huijssen(a)vortech.nl >> web www.vortech.nl >> ____________________________________________________________________ >> >> <timers.tar.gz> -- ____________________________________________________________________ VORtech BV - Scientific software engineers ____________________________________________________________________ Dr.ir. Koos Huijssen P.O. Box 260 2600 AG Delft The Netherlands phone +31(0)15-285 0125 mobile +31(0)6-3333 0803 email koos.huijssen(a)vortech.nl web www.vortech.nl ____________________________________________________________________

1 0

Re: [petsc-dev] Nested event logging and human friendly output
by Barry Smith 14 Sep '15

14 Sep '15

I have created a branch with your contribution barry/xml-nested-logging and will see what needs to be done to incorporate it into the PETSc repository. Barry > On Sep 14, 2015, at 7:45 AM, Koos Huijssen <koos.huijssen(a)vortech.nl> wrote: > > Dear PETSc development team, > > We have developed an extension of the PETSc event logging facilities that has the following advanced features: > > - It allows logging of events in the form of a nested tree. So if some function is called from multiple locations in the code, these instances are distinguished. This in contrast with the standard event logger, which only logs the amount of total call time. > - It allows the output report to be formatted in XML format. This output can then be viewed in a human-friendly form in a web browser > with the use of the XSL Transformation script performance_xml2html.xsl. The html features an nested timings tree that can be expanded and collapsed as desired. > > This tool has been very useful for us to analyze the code and pinpoint performance bottle necks. We think that it can be useful for others as well, and therefore we are providing the code here for integration in the open source distribution of PETSc. > > For more information I refer to the included manual. We have also provided a test program and a makefile for convenience. The test program can be run using MPI with for instance 3-6 processes. > > I apologize for not using the git repo to submit the developed code. I also apologize for not adhering to the PETSc coding standards (or at least not as far as I know), but I hope that it is not too far off.. Apart from the whole capital/underscore standardization stuff one issue may require special attention, namely the (ab)use of the format PETSc_VIEWER_ASCII_IMPL for signaling the XML format in XMLViewer.c. I couldn't find an already existing and better fitting format, but it could be necessary to add a new format here for this purpose. > > Can you take it up from here and realize the integration of the code in the PETSc distribution? > > With kind regards, > > Koos Huijssen > > -- > ____________________________________________________________________ > > VORtech BV - Scientific software engineers > ____________________________________________________________________ > > Dr.ir. Koos Huijssen > > P.O. Box 260 > 2600 AG Delft > The Netherlands > > phone +31(0)15-285 0125 > mobile +31(0)6-3333 0803 > email koos.huijssen(a)vortech.nl > web www.vortech.nl > ____________________________________________________________________ > > <timers.tar.gz>

1 0

Re: [petsc-dev] Nested event logging and human friendly output
by Matthew Knepley 14 Sep '15

14 Sep '15

On Mon, Sep 14, 2015 at 8:14 AM, Koos Huijssen <koos.huijssen(a)vortech.nl> wrote: > Dear Matt, > > On 14-9-2015 14:50, Matthew Knepley wrote: > > On Mon, Sep 14, 2015 at 7:45 AM, Koos Huijssen <koos.huijssen(a)vortech.nl> > wrote: > >> Dear PETSc development team, >> >> We have developed an extension of the PETSc event logging facilities that >> has the following advanced features: >> >> - It allows logging of events in the form of a nested tree. So if some >> function is called from multiple locations in the code, these instances are >> distinguished. This in contrast with the standard event logger, which only >> logs the amount of total call time. >> > > How is this different from using stages? > > Stages have to be set up explicitly, and there can only be 10 stages. The > nested event facility automatically provides a 'staged' appearance, as it > keeps track of the whole tree of parent routines. As a user you don't have > to bother about it, you just do your LogEventBegin - LogEventEnd and the > rest is taken care by the system. Yet, the instrumentation is not heavy, so > it doesn't introduce huge overhead in the code. > Okay, so this is automatic staging anytime an event is used in a different place in the call chain? That sounds nice. It would be good if it could be overridden to identify events since sometimes the output can get complex. Thanks, Matt > > > - It allows the output report to be formatted in XML format. This output >> can then be viewed in a human-friendly form in a web browser >> with the use of the XSL Transformation script performance_xml2html.xsl. >> The html features an nested timings tree that can be expanded and collapsed >> as desired. >> > > This sounds fine and useful. We will look at the code. > > Great! Let me hear if you need further clarification. > > Kind regards, > > Koos > > > > Thanks, > > Matt > > >> This tool has been very useful for us to analyze the code and pinpoint >> performance bottle necks. We think that it can be useful for others as >> well, and therefore we are providing the code here for integration in the >> open source distribution of PETSc. >> >> For more information I refer to the included manual. We have also >> provided a test program and a makefile for convenience. The test program >> can be run using MPI with for instance 3-6 processes. >> >> I apologize for not using the git repo to submit the developed code. I >> also apologize for not adhering to the PETSc coding standards (or at least >> not as far as I know), but I hope that it is not too far off.. Apart from >> the whole capital/underscore standardization stuff one issue may require >> special attention, namely the (ab)use of the format PETSc_VIEWER_ASCII_IMPL >> for signaling the XML format in XMLViewer.c. I couldn't find an already >> existing and better fitting format, but it could be necessary to add a new >> format here for this purpose. >> >> Can you take it up from here and realize the integration of the code in >> the PETSc distribution? >> >> With kind regards, >> >> Koos Huijssen >> >> -- >> ____________________________________________________________________ >> >> VORtech BV - Scientific software engineers >> ____________________________________________________________________ >> >> Dr.ir. Koos Huijssen >> >> P.O. Box 260 >> 2600 AG Delft >> The Netherlands >> >> phone +31(0)15-285 0125 >> mobile +31(0)6-3333 0803 >> email koos.huijssen(a)vortech.nl >> web www.vortech.nl >> ____________________________________________________________________ >> >> > > > -- > What most experimenters take for granted before they begin their > experiments is infinitely more interesting than any results to which their > experiments lead. > -- Norbert Wiener > > > -- > ____________________________________________________________________ > > VORtech BV - Scientific software engineers > ____________________________________________________________________ > > Dr.ir. Koos Huijssen > > P.O. Box 260 > 2600 AG Delft > The Netherlands > > phone +31(0)15-285 0125 > mobile +31(0)6-3333 0803 > email koos.huijssen(a)vortech.nl > web www.vortech.nl > ____________________________________________________________________ > > -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener

1 0

Re: [petsc-dev] Nested event logging and human friendly output
by Matthew Knepley 14 Sep '15

14 Sep '15

On Mon, Sep 14, 2015 at 7:45 AM, Koos Huijssen <koos.huijssen(a)vortech.nl> wrote: > Dear PETSc development team, > > We have developed an extension of the PETSc event logging facilities that > has the following advanced features: > > - It allows logging of events in the form of a nested tree. So if some > function is called from multiple locations in the code, these instances are > distinguished. This in contrast with the standard event logger, which only > logs the amount of total call time. > How is this different from using stages? > - It allows the output report to be formatted in XML format. This output > can then be viewed in a human-friendly form in a web browser > with the use of the XSL Transformation script performance_xml2html.xsl. > The html features an nested timings tree that can be expanded and collapsed > as desired. > This sounds fine and useful. We will look at the code. Thanks, Matt > This tool has been very useful for us to analyze the code and pinpoint > performance bottle necks. We think that it can be useful for others as > well, and therefore we are providing the code here for integration in the > open source distribution of PETSc. > > For more information I refer to the included manual. We have also provided > a test program and a makefile for convenience. The test program can be run > using MPI with for instance 3-6 processes. > > I apologize for not using the git repo to submit the developed code. I > also apologize for not adhering to the PETSc coding standards (or at least > not as far as I know), but I hope that it is not too far off.. Apart from > the whole capital/underscore standardization stuff one issue may require > special attention, namely the (ab)use of the format PETSc_VIEWER_ASCII_IMPL > for signaling the XML format in XMLViewer.c. I couldn't find an already > existing and better fitting format, but it could be necessary to add a new > format here for this purpose. > > Can you take it up from here and realize the integration of the code in > the PETSc distribution? > > With kind regards, > > Koos Huijssen > > -- > ____________________________________________________________________ > > VORtech BV - Scientific software engineers > ____________________________________________________________________ > > Dr.ir. Koos Huijssen > > P.O. Box 260 > 2600 AG Delft > The Netherlands > > phone +31(0)15-285 0125 > mobile +31(0)6-3333 0803 > email koos.huijssen(a)vortech.nl > web www.vortech.nl > ____________________________________________________________________ > > -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener

1 0

Nested event logging and human friendly output
by Koos Huijssen 14 Sep '15

14 Sep '15

Dear PETSc development team, We have developed an extension of the PETSc event logging facilities that has the following advanced features: - It allows logging of events in the form of a nested tree. So if some function is called from multiple locations in the code, these instances are distinguished. This in contrast with the standard event logger, which only logs the amount of total call time. - It allows the output report to be formatted in XML format. This output can then be viewed in a human-friendly form in a web browser with the use of the XSL Transformation script performance_xml2html.xsl. The html features an nested timings tree that can be expanded and collapsed as desired. This tool has been very useful for us to analyze the code and pinpoint performance bottle necks. We think that it can be useful for others as well, and therefore we are providing the code here for integration in the open source distribution of PETSc. For more information I refer to the included manual. We have also provided a test program and a makefile for convenience. The test program can be run using MPI with for instance 3-6 processes. I apologize for not using the git repo to submit the developed code. I also apologize for not adhering to the PETSc coding standards (or at least not as far as I know), but I hope that it is not too far off.. Apart from the whole capital/underscore standardization stuff one issue may require special attention, namely the (ab)use of the format PETSc_VIEWER_ASCII_IMPL for signaling the XML format in XMLViewer.c. I couldn't find an already existing and better fitting format, but it could be necessary to add a new format here for this purpose. Can you take it up from here and realize the integration of the code in the PETSc distribution? With kind regards, Koos Huijssen -- ____________________________________________________________________ VORtech BV - Scientific software engineers ____________________________________________________________________ Dr.ir. Koos Huijssen P.O. Box 260 2600 AG Delft The Netherlands phone +31(0)15-285 0125 mobile +31(0)6-3333 0803 email koos.huijssen(a)vortech.nl web www.vortech.nl ____________________________________________________________________

1 0

added crude parallel palltests for quicker alltests
by Barry Smith 10 Sep '15

10 Sep '15

I've added a crude new make rule palltests that runs multiple tests in different directories at the same time and gathers all results (at the end) into alltests.log in branches master and next. It reduced a basic debug alltests on my laptop from 25 minutes to 7 1/2 minutes. Now less excuse for not running some full testing before merging to next. Barry

1 0

[issue1342] another hypre memory corruption problem
by Ulrike Yang hypre Tracker 10 Sep '15

10 Sep '15

Ulrike Yang <umyang(a)llnl.gov> added the comment: I fixed this according to Barry's suggestion. ---------- assignedto: -> ulrikey priority: -> bug status: chatting -> resolved _____________________________________________ hypre Issue Tracker <hypre-support(a)llnl.gov> <http://tux273.llnl.gov:8070/hypre/issue1342> _____________________________________________

1 0

Re: [petsc-dev] [petsc-checkbuilds] PETSc blame digest (next) 2015-09-10
by Satish Balay 10 Sep '15

10 Sep '15

Pushed fixes to hzhang/opt-ptap and merged to next. https://bitbucket.org/petsc/petsc/commits/da0a95b209627d6aeffad8c47059db491… [please pull on hzhang/opt-ptap before further changes - or merge to master..] Satish On Thu, 10 Sep 2015, PETSc checkBuilds wrote: > > > Dear PETSc developer, > > This email contains listings of contributions attributed to you by > `git blame` that caused compiler errors or warnings in PETSc automated > testing. Follow the links to see the full log files. Please attempt to fix > the issues promptly or let us know at petsc-dev(a)mcs.anl.gov if you are unable > to resolve the issues. > > Thanks, > The PETSc development team > > ---- > > warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/9516a85 > experiment a new approach to optimize MatPtAPNumeric_MPIAIJ_MPIAIJ() > > src/mat/impls/aij/mpi/mpiptap.c:978 > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/10/build_next_…] > /sandbox/petsc/petsc.clone-2/src/mat/impls/aij/mpi/mpiptap.c:978:33: error: expected expression before '/' token > > ---- > To opt-out from receiving these messages - send a request to petsc-dev(a)mcs.anl.gov. >

1 0

Re: [petsc-dev] [petsc-checkbuilds] PETSc blame digest (next) 2015-09-08
by Barry Smith 10 Sep '15

10 Sep '15

Satish, I've done all this and then made a new series of corrections to the branch that hopefully won't break too much more. Thanks Barry > On Sep 8, 2015, at 11:44 PM, Satish Balay <balay(a)mcs.anl.gov> wrote: > > Barry, > > I amended this commit - and removed that section of code, and pushed > my change. [to pr352/dmay/pctelescope/master and merged to next] > > [I did this ammend - as this commit didn't propogage to next or master] > > [Assuming you haven't added anything else to this branch] Can you do > the following - to get this 'amended' commit cleanly - and discard the > previous commit in your branch. > > git checkout pr352/dmay/pctelescope/master > git fetch > git reset --hard origin/pr352/dmay/pctelescope/master > > Thanks, > Satish > > On Tue, 8 Sep 2015, Barry Smith wrote: > >> >> Satish, >> >> Likely it is wrong. I was forced by git to do some strange merge that produced that result. I can't explain why it happened. >> >> Feel free to fix the branch and master >> >> >> Barry >> >>> On Sep 8, 2015, at 11:25 PM, Satish Balay <balay(a)mcs.anl.gov> wrote: >>> >>> Barry, >>> >>> >>> I don't understand the commit https://bitbucket.org/petsc/petsc/commits/3dcc747d65aa2f2e79d189bef52568da1… >>> >>>>>>>> >>> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v) >>> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v) >>> { >>> PetscTryMethod(pc,"PCTelescopeSetIgnoreDM_C",(PC,PetscBool),(pc,v)); >>> return(0); >>> <<<<<<<< >>> >>> This reverts the change I made earlier - which was required to compile >>> code [otherwise (PetscBool)(PetscInt) is flaged as compiler error] >>> >>> >>>>>>> -PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscInt); >>>>>>> +PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscBool); >>> >>>>>>> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v) >>>>>>> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v) >>> >>> Satish >>> >>> On Tue, 8 Sep 2015, Barry Smith wrote: >>> >>>> >>>> Done. But I may have messed up the history a little >>>> >>>>> On Sep 8, 2015, at 4:28 PM, Satish Balay <balay(a)mcs.anl.gov> wrote: >>>>> >>>>> Barry, >>>>> >>>>> I see you made some changes to pr352/dmay/pctelescope/master and merged to next [and pushed] >>>>> >>>>> However - you did not push pr352/dmay/pctelescope/master. Could you push this branch? >>>>> >>>>> I have fix for the following warnings - and would like to push my changes.. >>>>> >>>>> [Just want to make sure all changes are in sync] >>>>> >>>>> >>>>> thanks, >>>>> Satish >>>>> -------- >>>>> >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetKSP': >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:654: warning: statement with no effect >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetReductionFactor': >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:675: warning: statement with no effect >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeSetReductionFactor': >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:696: warning: statement with no effect >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetIgnoreDM': >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:717: warning: statement with no effect >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeSetIgnoreDM': >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:738: warning: statement with no effect >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCTelescopeGetDM': >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:759: warning: statement with no effect >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c: In function 'PCSetUp_Telescope': >>>>> /home/balay/petsc.test/src/ksp/pc/impls/telescope/telescope.c:352: warning: 'subcomm' may be used uninitialized in this function >>>>> >>>>> On Tue, 8 Sep 2015, Satish Balay wrote: >>>>> >>>>>> Ok - pushed to pr352/dmay/pctelescope/master - and merged to next >>>>>> >>>>>> https://bitbucket.org/petsc/petsc/commits/bfd6bcc6ac8e2f0022fa8b00b8cd29f3a… >>>>>> >>>>>> [please before further changes - or merge to master] >>>>>> >>>>>> Satish >>>>>> >>>>>> On Tue, 8 Sep 2015, Satish Balay wrote: >>>>>> >>>>>>> I haven't check the examples - but I have the following fix for the build. Will push now >>>>>>> >>>>>>> Satish >>>>>>> >>>>>>> diff --git a/include/petscpc.h b/include/petscpc.h >>>>>>> index 7e583b8..0cddc86 100644 >>>>>>> --- a/include/petscpc.h >>>>>>> +++ b/include/petscpc.h >>>>>>> @@ -324,7 +324,7 @@ PETSC_EXTERN PetscErrorCode PCMGResidualDefault(Mat,Vec,Vec,Vec); >>>>>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetReductionFactor(PC,PetscInt*); >>>>>>> PETSC_EXTERN PetscErrorCode PCTelescopeSetReductionFactor(PC,PetscInt); >>>>>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetIgnoreDM(PC,PetscBool*); >>>>>>> -PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscInt); >>>>>>> +PETSC_EXTERN PetscErrorCode PCTelescopeSetIgnoreDM(PC,PetscBool); >>>>>>> PETSC_EXTERN PetscErrorCode PCTelescopeGetDM(PC,DM*); >>>>>>> >>>>>>> #endif /* __PETSCPC_H */ >>>>>>> diff --git a/src/ksp/pc/impls/telescope/telescope.c b/src/ksp/pc/impls/telescope/telescope.c >>>>>>> index 5e899de..fe75c46 100644 >>>>>>> --- a/src/ksp/pc/impls/telescope/telescope.c >>>>>>> +++ b/src/ksp/pc/impls/telescope/telescope.c >>>>>>> @@ -207,7 +207,7 @@ PetscErrorCode PCTelescopeMatCreate_default(PC pc,PC_Telescope sred,MatReuse reu >>>>>>> if (reuse != MAT_INITIAL_MATRIX) { Bred = *A; } >>>>>>> >>>>>>> ierr = MatGetSize(Blocal,&mm,NULL);CHKERRQ(ierr); >>>>>>> - //ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); >>>>>>> + /* ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); */ >>>>>>> ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,mm,reuse,&Bred);CHKERRQ(ierr); >>>>>>> } >>>>>>> *A = Bred; >>>>>>> @@ -734,7 +734,7 @@ PetscErrorCode PCTelescopeGetIgnoreDM(PC pc,PetscBool *v) >>>>>>> >>>>>>> .keywords: PC, telescoping solve >>>>>>> @*/ >>>>>>> -PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscInt v) >>>>>>> +PetscErrorCode PCTelescopeSetIgnoreDM(PC pc,PetscBool v) >>>>>>> { >>>>>>> PetscTryMethod(pc,"PCTelescopeSetIgnoreDM_C",(PC,PetscBool),(pc,v)); >>>>>>> return(0); >>>>>>> diff --git a/src/ksp/pc/impls/telescope/telescope_dmda.c b/src/ksp/pc/impls/telescope/telescope_dmda.c >>>>>>> index edd1708..98d0c7f 100644 >>>>>>> --- a/src/ksp/pc/impls/telescope/telescope_dmda.c >>>>>>> +++ b/src/ksp/pc/impls/telescope/telescope_dmda.c >>>>>>> @@ -757,7 +757,7 @@ PetscErrorCode PCTelescopeMatCreate_dmda(PC pc,PC_Telescope sred,MatReuse reuse, >>>>>>> >>>>>>> if (reuse != MAT_INITIAL_MATRIX) {Bred = *A;} >>>>>>> ierr = MatGetSize(Blocal,&mm,NULL);CHKERRQ(ierr); >>>>>>> - //ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); >>>>>>> + /* ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,PETSC_DECIDE,reuse,&Bred);CHKERRQ(ierr); */ >>>>>>> ierr = MatCreateMPIMatConcatenateSeqMat(subcomm,Blocal,mm,reuse,&Bred);CHKERRQ(ierr); >>>>>>> } >>>>>>> *A = Bred; >>>>>>> >>>>>>> >>>>>>> On Tue, 8 Sep 2015, Barry Smith wrote: >>>>>>> >>>>>>>> >>>>>>>> Dave, >>>>>>>> >>>>>>>> I'll be fixing these. >>>>>>>> >>>>>>>> Barry >>>>>>>> >>>>>>>>> On Sep 8, 2015, at 9:00 AM, PETSc checkBuilds <petsc-checkbuilds(a)mcs.anl.gov> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Dear PETSc developer, >>>>>>>>> >>>>>>>>> This email contains listings of contributions attributed to you by >>>>>>>>> `git blame` that caused compiler errors or warnings in PETSc automated >>>>>>>>> testing. Follow the links to see the full log files. Please attempt to fix >>>>>>>>> the issues promptly or let us know at petsc-dev(a)mcs.anl.gov if you are unable >>>>>>>>> to resolve the issues. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> The PETSc development team >>>>>>>>> >>>>>>>>> ---- >>>>>>>>> >>>>>>>>> warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/6ab51f8 >>>>>>>>> PCSemiRedundant: >>>>>>>>> >>>>>>>>> src/ksp/pc/impls/telescope/telescope.c:116 >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope.c:116:3: warning: 'subdm' may be used uninitialized in this function [-Wmaybe-uninitialized] >>>>>>>>> >>>>>>>>> src/ksp/pc/impls/telescope/telescope.c:210 >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope.c:210:5: error: expected expression before '/' token >>>>>>>>> >>>>>>>>> src/ksp/pc/impls/telescope/telescope.c:380 >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope.c:380:12: warning: 'subcomm' may be used uninitialized in this function [-Wmaybe-uninitialized] >>>>>>>>> >>>>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:112 >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:112:18: warning: 'start_IJK' may be used uninitialized in this function [-Wmaybe-uninitialized] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:112:7: warning: 'start_IJK' may be used uninitialized in this function [-Wmaybe-uninitialized] >>>>>>>>> >>>>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:535 >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/balay/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /home/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/balay/petsc.clone-4/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/balay/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:535:54: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> >>>>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:609 >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/balay/petsc.clone-4/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/balay/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /home/balay/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-3/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/balay/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:609:49: warning: variable 'natural_ijk' set but not used [-Wunused-but-set-variable] >>>>>>>>> >>>>>>>>> src/ksp/pc/impls/telescope/telescope_dmda.c:760 >>>>>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/09/08/build_next_…] >>>>>>>>> /sandbox/petsc/petsc.clone-2/src/ksp/pc/impls/telescope/telescope_dmda.c:760:5: error: expected expression before '/' token >>>>>>>>> >>>>>>>>> ---- >>>>>>>>> To opt-out from receiving these messages - send a request to petsc-dev(a)mcs.anl.gov. >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>> >> >> >

1 0