March 2021 - petsc-dev - mailman3.cels.anl.gov

Re: [petsc-dev] configureLibrary fails for c++11 projects
by Patrick Sanan 23 Mar '21

23 Mar '21

I had a related (I think) issue trying to build with Kokkos. Those headers throw an #error if they're expecting OpenMP and the compiler doesn't have the OpenMP flag. I have an open MR here (number 60^2!) which thus adds the OpenMP flag to the CXXPPFLAGS: https://gitlab.com/petsc/petsc/-/merge_requests/3600 <https://gitlab.com/petsc/petsc/-/merge_requests/3600> My collaborator at CSCS was testing with the latest Kokkos and ran into an even hairier version of this problem trying to use CUDA - the Kokkos headers now apparently check that you're using nvcc. He has some workaround which I'll review and hopefully be able to submit. > Am 23.03.2021 um 17:04 schrieb Stefano Zampini <stefano.zampini(a)gmail.com>: > > The check fails within buildsystem when running mpicc -E (which uses CXXPPFLAGS) The package header needs c++11 to be included properly. C++11 is also needed at preprocessing time > > Il Mar 23 Mar 2021, 18:59 Satish Balay <balay(a)mcs.anl.gov <mailto:[email protected]>> ha scritto: > -std=cxx11 for sure is a compile flag. But don't really know if its > also needed at pre-process stage and/or at link stage. > > And for compile stage both CXXFLAGS and CXXPPFLAGS should get > used. [PETSc makefiles make sure this is the case] > > And for link stage CXXFLAGS and LDFLAGS get used [but then sometimes > we have CLINKER, and FLINKER - and they certainly don't use CXXFLAGS - > so -std=cxx11 isn't really needed at link time? > > So the previous default of CXXPPFLAGS=-std=cxx11 looks reasonable to me. > > However if this project is not using PETSc makefiles - it should make sure all compile flags are grabbed. > > # lib/petsc/conf/variables > PETSC_CXXCPPFLAGS = ${PETSC_CC_INCLUDES} ${PETSCFLAGS} ${CXXPP_FLAGS} ${CXXPPFLAGS} > CXXCPPFLAGS = ${PETSC_CXXCPPFLAGS} > PETSC_CXXCOMPILE_SINGLE = ${CXX} -o $*.o -c ${CXX_FLAGS} ${CXXFLAGS} ${CXXCPPFLAGS} > > # lib/petsc/conf/rules > .cpp.o .cxx.o .cc.o .C.o: > ${PETSC_CXXCOMPILE_SINGLE} `pwd`/$< > > # gmakefile.test > PETSC_COMPILE.cxx = $(call quiet,CXX) -c $(CXX_FLAGS) $(CXXFLAGS) $(CXXCPPFLAGS) $(CXX_DEPFLAGS) > > # lib/petsc/conf/test > LINK.cc = $(CXXLINKER) $(CXX_FLAGS) $(CXXFLAGS) $(CXXCPPFLAGS) $(LDFLAGS) > > Satish > > > On Tue, 23 Mar 2021, Junchao Zhang wrote: > > > I would rather directly change the project to use CXXFLAGS instead of > > CXXPPFLAGS. > > > > --Junchao Zhang > > > > > > On Tue, Mar 23, 2021 at 10:01 AM Satish Balay via petsc-dev < > > petsc-dev(a)mcs.anl.gov <mailto:[email protected]>> wrote: > > > > > On Tue, 23 Mar 2021, Stefano Zampini wrote: > > > > > > > Just tried out of main, and and the include tests of a c++11 project fail > > > > Below my fix, if we agree on, I'll make a MR > > > > > > > > diff --git a/config/BuildSystem/config/compilers.py > > > > b/config/BuildSystem/config/compilers.py > > > > index c96967e..44e4657 100644 > > > > --- a/config/BuildSystem/config/compilers.py > > > > +++ b/config/BuildSystem/config/compilers.py > > > > @@ -527,6 +527,8 @@ class Configure(config.base.Configure): > > > > if self.setCompilers.checkCompilerFlag(flag, includes, > > > > body+body14): > > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > > > flag # > > > > append flag to the old > > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' + > > > flag > > > > # append flag to the old > > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > > > > > > > > > https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c… <https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c…> > > > > > > self.setCompilers.CXXPPFLAGS += ' ' + flag > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + flag # > > > append flag to the old > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > > > > > So the old code was setting 'PPFLAGS' - but this commit changed to > > > 'FLAGS'. Maybe this flag is needed at both compile time and link time? > > > > > > So this project is somehow using CXXPPFLAGS - but not CXXFLAGS? > > > > > > I'm fine with adding it to PPFLAGS - duplicate listing hopefully shouldn't > > > cause grief. > > > > > > Satish > > > > > > > cxxdialect = 'C++14' > > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) > > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > > > > @@ -546,6 +548,8 @@ class Configure(config.base.Configure): > > > > if self.setCompilers.checkCompilerFlag(flag, includes, body): > > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > > > flag # > > > > append flag to the old > > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' + > > > flag > > > > # append flag to the old > > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > > > > cxxdialect = 'C++11' > > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > > > > break > > > > > > > > > > > > > > > > > > > > >

1 0

Re: [petsc-dev] configureLibrary fails for c++11 projects
by Stefano Zampini 23 Mar '21

23 Mar '21

The check fails within buildsystem when running mpicc -E (which uses CXXPPFLAGS) The package header needs c++11 to be included properly. C++11 is also needed at preprocessing time Il Mar 23 Mar 2021, 18:59 Satish Balay <balay(a)mcs.anl.gov> ha scritto: > -std=cxx11 for sure is a compile flag. But don't really know if its > also needed at pre-process stage and/or at link stage. > > And for compile stage both CXXFLAGS and CXXPPFLAGS should get > used. [PETSc makefiles make sure this is the case] > > And for link stage CXXFLAGS and LDFLAGS get used [but then sometimes > we have CLINKER, and FLINKER - and they certainly don't use CXXFLAGS - > so -std=cxx11 isn't really needed at link time? > > So the previous default of CXXPPFLAGS=-std=cxx11 looks reasonable to me. > > However if this project is not using PETSc makefiles - it should make sure > all compile flags are grabbed. > > # lib/petsc/conf/variables > PETSC_CXXCPPFLAGS = ${PETSC_CC_INCLUDES} ${PETSCFLAGS} > ${CXXPP_FLAGS} ${CXXPPFLAGS} > CXXCPPFLAGS = ${PETSC_CXXCPPFLAGS} > PETSC_CXXCOMPILE_SINGLE = ${CXX} -o $*.o -c ${CXX_FLAGS} ${CXXFLAGS} > ${CXXCPPFLAGS} > > # lib/petsc/conf/rules > .cpp.o .cxx.o .cc.o .C.o: > ${PETSC_CXXCOMPILE_SINGLE} `pwd`/$< > > # gmakefile.test > PETSC_COMPILE.cxx = $(call quiet,CXX) -c $(CXX_FLAGS) $(CXXFLAGS) > $(CXXCPPFLAGS) $(CXX_DEPFLAGS) > > # lib/petsc/conf/test > LINK.cc = $(CXXLINKER) $(CXX_FLAGS) $(CXXFLAGS) $(CXXCPPFLAGS) $(LDFLAGS) > > Satish > > > On Tue, 23 Mar 2021, Junchao Zhang wrote: > > > I would rather directly change the project to use CXXFLAGS instead of > > CXXPPFLAGS. > > > > --Junchao Zhang > > > > > > On Tue, Mar 23, 2021 at 10:01 AM Satish Balay via petsc-dev < > > petsc-dev(a)mcs.anl.gov> wrote: > > > > > On Tue, 23 Mar 2021, Stefano Zampini wrote: > > > > > > > Just tried out of main, and and the include tests of a c++11 project > fail > > > > Below my fix, if we agree on, I'll make a MR > > > > > > > > diff --git a/config/BuildSystem/config/compilers.py > > > > b/config/BuildSystem/config/compilers.py > > > > index c96967e..44e4657 100644 > > > > --- a/config/BuildSystem/config/compilers.py > > > > +++ b/config/BuildSystem/config/compilers.py > > > > @@ -527,6 +527,8 @@ class Configure(config.base.Configure): > > > > if self.setCompilers.checkCompilerFlag(flag, includes, > > > > body+body14): > > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > > > flag # > > > > append flag to the old > > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' > + > > > flag > > > > # append flag to the old > > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > > > > > > > > > > https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c… > > > > > > self.setCompilers.CXXPPFLAGS += ' ' + flag > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > flag # > > > append flag to the old > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > > > > > So the old code was setting 'PPFLAGS' - but this commit changed to > > > 'FLAGS'. Maybe this flag is needed at both compile time and link time? > > > > > > So this project is somehow using CXXPPFLAGS - but not CXXFLAGS? > > > > > > I'm fine with adding it to PPFLAGS - duplicate listing hopefully > shouldn't > > > cause grief. > > > > > > Satish > > > > > > > cxxdialect = 'C++14' > > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) > > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > > > > @@ -546,6 +548,8 @@ class Configure(config.base.Configure): > > > > if self.setCompilers.checkCompilerFlag(flag, includes, > body): > > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > > > flag # > > > > append flag to the old > > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' > + > > > flag > > > > # append flag to the old > > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > > > > cxxdialect = 'C++11' > > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > > > > break > > > > > > > > > > > > > > > > > > > > > >

1 0

Re: [petsc-dev] configureLibrary fails for c++11 projects
by Satish Balay 23 Mar '21

23 Mar '21

-std=cxx11 for sure is a compile flag. But don't really know if its also needed at pre-process stage and/or at link stage. And for compile stage both CXXFLAGS and CXXPPFLAGS should get used. [PETSc makefiles make sure this is the case] And for link stage CXXFLAGS and LDFLAGS get used [but then sometimes we have CLINKER, and FLINKER - and they certainly don't use CXXFLAGS - so -std=cxx11 isn't really needed at link time? So the previous default of CXXPPFLAGS=-std=cxx11 looks reasonable to me. However if this project is not using PETSc makefiles - it should make sure all compile flags are grabbed. # lib/petsc/conf/variables PETSC_CXXCPPFLAGS = ${PETSC_CC_INCLUDES} ${PETSCFLAGS} ${CXXPP_FLAGS} ${CXXPPFLAGS} CXXCPPFLAGS = ${PETSC_CXXCPPFLAGS} PETSC_CXXCOMPILE_SINGLE = ${CXX} -o $*.o -c ${CXX_FLAGS} ${CXXFLAGS} ${CXXCPPFLAGS} # lib/petsc/conf/rules .cpp.o .cxx.o .cc.o .C.o: ${PETSC_CXXCOMPILE_SINGLE} `pwd`/$< # gmakefile.test PETSC_COMPILE.cxx = $(call quiet,CXX) -c $(CXX_FLAGS) $(CXXFLAGS) $(CXXCPPFLAGS) $(CXX_DEPFLAGS) # lib/petsc/conf/test LINK.cc = $(CXXLINKER) $(CXX_FLAGS) $(CXXFLAGS) $(CXXCPPFLAGS) $(LDFLAGS) Satish On Tue, 23 Mar 2021, Junchao Zhang wrote: > I would rather directly change the project to use CXXFLAGS instead of > CXXPPFLAGS. > > --Junchao Zhang > > > On Tue, Mar 23, 2021 at 10:01 AM Satish Balay via petsc-dev < > petsc-dev(a)mcs.anl.gov> wrote: > > > On Tue, 23 Mar 2021, Stefano Zampini wrote: > > > > > Just tried out of main, and and the include tests of a c++11 project fail > > > Below my fix, if we agree on, I'll make a MR > > > > > > diff --git a/config/BuildSystem/config/compilers.py > > > b/config/BuildSystem/config/compilers.py > > > index c96967e..44e4657 100644 > > > --- a/config/BuildSystem/config/compilers.py > > > +++ b/config/BuildSystem/config/compilers.py > > > @@ -527,6 +527,8 @@ class Configure(config.base.Configure): > > > if self.setCompilers.checkCompilerFlag(flag, includes, > > > body+body14): > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > > flag # > > > append flag to the old > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' + > > flag > > > # append flag to the old > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > > > > > > https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c… > > > > self.setCompilers.CXXPPFLAGS += ' ' + flag > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + flag # > > append flag to the old > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > > > So the old code was setting 'PPFLAGS' - but this commit changed to > > 'FLAGS'. Maybe this flag is needed at both compile time and link time? > > > > So this project is somehow using CXXPPFLAGS - but not CXXFLAGS? > > > > I'm fine with adding it to PPFLAGS - duplicate listing hopefully shouldn't > > cause grief. > > > > Satish > > > > > cxxdialect = 'C++14' > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > > > @@ -546,6 +548,8 @@ class Configure(config.base.Configure): > > > if self.setCompilers.checkCompilerFlag(flag, includes, body): > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > > flag # > > > append flag to the old > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' + > > flag > > > # append flag to the old > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > > > cxxdialect = 'C++11' > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > > > break > > > > > > > > > > > > > >

1 0

Re: [petsc-dev] configureLibrary fails for c++11 projects
by Junchao Zhang 23 Mar '21

23 Mar '21

I would rather directly change the project to use CXXFLAGS instead of CXXPPFLAGS. --Junchao Zhang On Tue, Mar 23, 2021 at 10:01 AM Satish Balay via petsc-dev < petsc-dev(a)mcs.anl.gov> wrote: > On Tue, 23 Mar 2021, Stefano Zampini wrote: > > > Just tried out of main, and and the include tests of a c++11 project fail > > Below my fix, if we agree on, I'll make a MR > > > > diff --git a/config/BuildSystem/config/compilers.py > > b/config/BuildSystem/config/compilers.py > > index c96967e..44e4657 100644 > > --- a/config/BuildSystem/config/compilers.py > > +++ b/config/BuildSystem/config/compilers.py > > @@ -527,6 +527,8 @@ class Configure(config.base.Configure): > > if self.setCompilers.checkCompilerFlag(flag, includes, > > body+body14): > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > flag # > > append flag to the old > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' + > flag > > # append flag to the old > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > > > https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c… > > self.setCompilers.CXXPPFLAGS += ' ' + flag > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + flag # > append flag to the old > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > So the old code was setting 'PPFLAGS' - but this commit changed to > 'FLAGS'. Maybe this flag is needed at both compile time and link time? > > So this project is somehow using CXXPPFLAGS - but not CXXFLAGS? > > I'm fine with adding it to PPFLAGS - duplicate listing hopefully shouldn't > cause grief. > > Satish > > > cxxdialect = 'C++14' > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > > @@ -546,6 +548,8 @@ class Configure(config.base.Configure): > > if self.setCompilers.checkCompilerFlag(flag, includes, body): > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > flag # > > append flag to the old > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' + > flag > > # append flag to the old > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > > cxxdialect = 'C++11' > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > > break > > > > > > > >

1 0

Re: [petsc-dev] configureLibrary fails for c++11 projects
by Satish Balay 23 Mar '21

23 Mar '21

On Tue, 23 Mar 2021, Stefano Zampini wrote: > Just tried out of main, and and the include tests of a c++11 project fail > Below my fix, if we agree on, I'll make a MR > > diff --git a/config/BuildSystem/config/compilers.py > b/config/BuildSystem/config/compilers.py > index c96967e..44e4657 100644 > --- a/config/BuildSystem/config/compilers.py > +++ b/config/BuildSystem/config/compilers.py > @@ -527,6 +527,8 @@ class Configure(config.base.Configure): > if self.setCompilers.checkCompilerFlag(flag, includes, > body+body14): > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + flag # > append flag to the old > setattr(self.setCompilers,LANG+'FLAGS',newflag) > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' + flag > # append flag to the old > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c… self.setCompilers.CXXPPFLAGS += ' ' + flag newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + flag # append flag to the old setattr(self.setCompilers,LANG+'FLAGS',newflag) So the old code was setting 'PPFLAGS' - but this commit changed to 'FLAGS'. Maybe this flag is needed at both compile time and link time? So this project is somehow using CXXPPFLAGS - but not CXXFLAGS? I'm fine with adding it to PPFLAGS - duplicate listing hopefully shouldn't cause grief. Satish > cxxdialect = 'C++14' > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > @@ -546,6 +548,8 @@ class Configure(config.base.Configure): > if self.setCompilers.checkCompilerFlag(flag, includes, body): > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + flag # > append flag to the old > setattr(self.setCompilers,LANG+'FLAGS',newflag) > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' + flag > # append flag to the old > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > cxxdialect = 'C++11' > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > break > > >

1 0

configureLibrary fails for c++11 projects
by Stefano Zampini 23 Mar '21

23 Mar '21

Just tried out of main, and and the include tests of a c++11 project fail Below my fix, if we agree on, I'll make a MR diff --git a/config/BuildSystem/config/compilers.py b/config/BuildSystem/config/compilers.py index c96967e..44e4657 100644 --- a/config/BuildSystem/config/compilers.py +++ b/config/BuildSystem/config/compilers.py @@ -527,6 +527,8 @@ class Configure(config.base.Configure): if self.setCompilers.checkCompilerFlag(flag, includes, body+body14): newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + flag # append flag to the old setattr(self.setCompilers,LANG+'FLAGS',newflag) + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' + flag # append flag to the old + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) cxxdialect = 'C++14' self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) @@ -546,6 +548,8 @@ class Configure(config.base.Configure): if self.setCompilers.checkCompilerFlag(flag, includes, body): newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + flag # append flag to the old setattr(self.setCompilers,LANG+'FLAGS',newflag) + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' ' + flag # append flag to the old + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) cxxdialect = 'C++11' self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) break -- Stefano

1 0

Re: [petsc-dev] Test harness + PETSC_HAVE_DEFINED
by Pierre Jolivet 22 Mar '21

22 Mar '21

> On 22 Mar 2021, at 10:15 PM, Scott Kruger <kruger(a)txcorp.com> wrote: > > > It keys off of $PETSC_ARCH/include/petscconf.h so is a configure/build > time configuration not a runtime configuration. Right, and since 3.12, <li>The ./configure option --with-avx512-kernels defaults to true now so the manually optimized AVX-512 kernels are used by default</li>. So instead of having a single worker with: config/examples/arch-ci-linux-knl.py: '--with-avx512-kernels=1', There should probably have been some workers with the flag --with-avx512-kernels=0, I guess. ksp_ksp_tests-ex6_3_skip_pipegcr is in fact skipped by all workers now. Thanks, Pierre > Scott > > > > On 2021-03-22 21:40, Pierre Jolivet did write: >> >> >>> On 22 Mar 2021, at 9:24 PM, Pierre Jolivet <pierre(a)joliv.et> wrote: >>> >>> Hello, >>> My make check is skipping tests which have a “requires: defined(PETSC_USE_SHARED_LIBRARIES)” with the message "SKIP PETSC_HAVE_DEFINED(PETSC_USE_SHARED_LIBRARIES) requirement not met" even though in configure.log I have: >>> 2021-03-22T16:17:43.1626452Z #define PETSC_USE_SHARED_LIBRARIES 1 >>> Is this expected? >> >> Sorry for the double send, I’m now realizing it should read define, not defined. >> >>> Here is an ever more puzzling behavior. >>> https://gitlab.com/petsc/petsc/-/jobs/1118286502/artifacts/browse/arch-ci-f… <https://gitlab.com/petsc/petsc/-/jobs/1118286502/artifacts/browse/arch-ci-f…><https://gitlab.com/petsc/petsc/-/jobs/1118286502/artifacts/browse/arch-ci-f… <https://gitlab.com/petsc/petsc/-/jobs/1118286502/artifacts/browse/arch-ci-f…>> >>> ok ksp_ksp_tests-ex6_3_skip_pipegcr # SKIP Null requirement not met: define(PETSC_USE_AVX512_KERNELS) >>> #PIPEGCR generates nans on linux-knl >>> test: >>> requires: !define(PETSC_USE_AVX512_KERNELS) >>> suffix: 3_skip_pipegcr >> >> I’ve also realized that PETSC_USE_AVX512_KERNELS is defined on that worker, which seems a little weird to me (is it defined for all workers, even those which are not AVX512-capable?). >> >> Thanks, >> Pierre >> >>> Why is this test skipped (on a worker other than linux-knl)? >>> Thanks, >>> Pierre >> > > -- > Scott Kruger > Tech-X Corporation kruger(a)txcorp.com <mailto:[email protected]> > 5621 Arapahoe Ave, Suite A Phone: (720) 466-3196 > Boulder, CO 80303 Fax: (303) 448-7756

1 0

Re: [petsc-dev] Test harness + PETSC_HAVE_DEFINED
by Scott Kruger 22 Mar '21

22 Mar '21

It keys off of $PETSC_ARCH/include/petscconf.h so is a configure/build time configuration not a runtime configuration. Scott On 2021-03-22 21:40, Pierre Jolivet did write: > > > > On 22 Mar 2021, at 9:24 PM, Pierre Jolivet <pierre(a)joliv.et> wrote: > > > > Hello, > > My make check is skipping tests which have a “requires: defined(PETSC_USE_SHARED_LIBRARIES)” with the message "SKIP PETSC_HAVE_DEFINED(PETSC_USE_SHARED_LIBRARIES) requirement not met" even though in configure.log I have: > > 2021-03-22T16:17:43.1626452Z #define PETSC_USE_SHARED_LIBRARIES 1 > > Is this expected? > > Sorry for the double send, I’m now realizing it should read define, not defined. > > > Here is an ever more puzzling behavior. > > https://gitlab.com/petsc/petsc/-/jobs/1118286502/artifacts/browse/arch-ci-f… <https://gitlab.com/petsc/petsc/-/jobs/1118286502/artifacts/browse/arch-ci-f…> > > ok ksp_ksp_tests-ex6_3_skip_pipegcr # SKIP Null requirement not met: define(PETSC_USE_AVX512_KERNELS) > > #PIPEGCR generates nans on linux-knl > > test: > > requires: !define(PETSC_USE_AVX512_KERNELS) > > suffix: 3_skip_pipegcr > > I’ve also realized that PETSC_USE_AVX512_KERNELS is defined on that worker, which seems a little weird to me (is it defined for all workers, even those which are not AVX512-capable?). > > Thanks, > Pierre > > > Why is this test skipped (on a worker other than linux-knl)? > > Thanks, > > Pierre > -- Scott Kruger Tech-X Corporation kruger(a)txcorp.com 5621 Arapahoe Ave, Suite A Phone: (720) 466-3196 Boulder, CO 80303 Fax: (303) 448-7756

1 0

Re: [petsc-dev] Test harness + PETSC_HAVE_DEFINED
by Pierre Jolivet 22 Mar '21

22 Mar '21

> On 22 Mar 2021, at 9:24 PM, Pierre Jolivet <pierre(a)joliv.et> wrote: > > Hello, > My make check is skipping tests which have a “requires: defined(PETSC_USE_SHARED_LIBRARIES)” with the message "SKIP PETSC_HAVE_DEFINED(PETSC_USE_SHARED_LIBRARIES) requirement not met" even though in configure.log I have: > 2021-03-22T16:17:43.1626452Z #define PETSC_USE_SHARED_LIBRARIES 1 > Is this expected? Sorry for the double send, I’m now realizing it should read define, not defined. > Here is an ever more puzzling behavior. > https://gitlab.com/petsc/petsc/-/jobs/1118286502/artifacts/browse/arch-ci-f… <https://gitlab.com/petsc/petsc/-/jobs/1118286502/artifacts/browse/arch-ci-f…> > ok ksp_ksp_tests-ex6_3_skip_pipegcr # SKIP Null requirement not met: define(PETSC_USE_AVX512_KERNELS) > #PIPEGCR generates nans on linux-knl > test: > requires: !define(PETSC_USE_AVX512_KERNELS) > suffix: 3_skip_pipegcr I’ve also realized that PETSC_USE_AVX512_KERNELS is defined on that worker, which seems a little weird to me (is it defined for all workers, even those which are not AVX512-capable?). Thanks, Pierre > Why is this test skipped (on a worker other than linux-knl)? > Thanks, > Pierre

1 0

Test harness + PETSC_HAVE_DEFINED
by Pierre Jolivet 22 Mar '21

22 Mar '21

Hello, My make check is skipping tests which have a “requires: defined(PETSC_USE_SHARED_LIBRARIES)” with the message "SKIP PETSC_HAVE_DEFINED(PETSC_USE_SHARED_LIBRARIES) requirement not met" even though in configure.log I have: 2021-03-22T16:17:43.1626452Z #define PETSC_USE_SHARED_LIBRARIES 1 Is this expected? Here is an ever more puzzling behavior. https://gitlab.com/petsc/petsc/-/jobs/1118286502/artifacts/browse/arch-ci-f… <https://gitlab.com/petsc/petsc/-/jobs/1118286502/artifacts/browse/arch-ci-f…> ok ksp_ksp_tests-ex6_3_skip_pipegcr # SKIP Null requirement not met: define(PETSC_USE_AVX512_KERNELS) #PIPEGCR generates nans on linux-knl test: requires: !define(PETSC_USE_AVX512_KERNELS) suffix: 3_skip_pipegcr Why is this test skipped (on a worker other than linux-knl)? Thanks, Pierre

1 0