March 2021 - petsc-dev - mailman3.cels.anl.gov

Re: [petsc-dev] mpi.mod --with-fortran-interfaces=0
by Pierre Jolivet 24 Mar '21

24 Mar '21

For now, I’ve merely removed the runtime error from there https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec… <https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec…> And configure seems to be happy (for now… my Windows VM is way to slow…) http://joliv.et/configure_msmpi.log <http://joliv.et/configure_msmpi.log> I will try your diff as well (in about one hour and a half when the first build is through). Thanks, Pierre > On 24 Mar 2021, at 3:10 PM, Satish Balay <balay(a)mcs.anl.gov> wrote: > > On Wed, 24 Mar 2021, Pierre Jolivet wrote: > >> >> >>> On 24 Mar 2021, at 2:55 PM, Matthew Knepley <knepley(a)gmail.com> wrote: >>> >>> On Wed, Mar 24, 2021 at 9:37 AM Pierre Jolivet <pierre(a)joliv.et <mailto:[email protected]>> wrote: >>> Hello, >>> It seems mpi.mod is now mandatory https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec… <https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec…>. >>> mpi.mod is not shipped by MS-MPI. >>> I want to build MUMPS through PETSc and don’t really care about the Fortran PETSc interface on our Windows boxes (--with-fortran-interfaces=0). >>> >>> I think you want --with-fc=0, which should turn off this check. >> >> No, I have gfortran, I want to compile MUMPS with PETSc, that won’t work --with-fc=0. >> Also, the error message in the configure is wrong, it should read "PETSc Fortran bindings” (not “fortran interface”), and in my email, one should replace --with-fortran-interfaces by --with-fortran-bindings, sorry about that. >> I guess there is a missing check before raise RuntimeError('mpi.mod not found! PETSc fortran interface requires a working mpi.mod'), like if self.argDB['with-fortran-interfaces'] >> But I don’t know if that makes sense. > > I guess you mean: > > diff --git a/config/BuildSystem/config/packages/MPI.py b/config/BuildSystem/config/packages/MPI.py > index 7ea2716cc5..5a1baff9f9 100644 > --- a/config/BuildSystem/config/packages/MPI.py > +++ b/config/BuildSystem/config/packages/MPI.py > @@ -497,7 +497,7 @@ Unable to run hostname to check the network') > > def FortranMPICheck(self): > '''Make sure fortran include [mpif.h] and library symbols are found''' > - if not hasattr(self.compilers, 'FC'): > + if not hasattr(self.compilers, 'FC') or not self.argDB['with-fortran-bindings']: > return 0 > # Fortran compiler is being used - so make sure mpif.h exists > self.libraries.pushLanguage('FC') > > If MS-MPI is missing mpi.mod - I guess we'll have to revert this requirement. For some reason the tests in CI don't error out. I'll have to check. > > I can add back mpif.h usage [without the extra complex code we had for handling some corner cases - in this mode] > > Satish > >> >> Thanks, >> Pierre >> >>> Thanks, >>> >>> Matt >>> >>> Yet, I’m now hit by: >>> ******************************************************************************* >>> UNABLE to CONFIGURE with GIVEN OPTIONS (see configure.log for details): >>> ------------------------------------------------------------------------------- >>> mpi.mod not found! PETSc fortran interface requires a working mpi.mod >>> ******************************************************************************* >>> Could this be fixed somehow, please? >>> Thanks, >>> Pierre >>> >>> >>> -- >>> What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. >>> -- Norbert Wiener >>> >>> https://www.cse.buffalo.edu/~knepley/ <http://www.cse.buffalo.edu/~knepley/>

1 0

Re: [petsc-dev] mpi.mod --with-fortran-interfaces=0
by Satish Balay 24 Mar '21

24 Mar '21

On Wed, 24 Mar 2021, Pierre Jolivet wrote: > > > > On 24 Mar 2021, at 2:55 PM, Matthew Knepley <knepley(a)gmail.com> wrote: > > > > On Wed, Mar 24, 2021 at 9:37 AM Pierre Jolivet <pierre(a)joliv.et <mailto:[email protected]>> wrote: > > Hello, > > It seems mpi.mod is now mandatory https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec… <https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec…>. > > mpi.mod is not shipped by MS-MPI. > > I want to build MUMPS through PETSc and don’t really care about the Fortran PETSc interface on our Windows boxes (--with-fortran-interfaces=0). > > > > I think you want --with-fc=0, which should turn off this check. > > No, I have gfortran, I want to compile MUMPS with PETSc, that won’t work --with-fc=0. > Also, the error message in the configure is wrong, it should read "PETSc Fortran bindings” (not “fortran interface”), and in my email, one should replace --with-fortran-interfaces by --with-fortran-bindings, sorry about that. > I guess there is a missing check before raise RuntimeError('mpi.mod not found! PETSc fortran interface requires a working mpi.mod'), like if self.argDB['with-fortran-interfaces'] > But I don’t know if that makes sense. I guess you mean: diff --git a/config/BuildSystem/config/packages/MPI.py b/config/BuildSystem/config/packages/MPI.py index 7ea2716cc5..5a1baff9f9 100644 --- a/config/BuildSystem/config/packages/MPI.py +++ b/config/BuildSystem/config/packages/MPI.py @@ -497,7 +497,7 @@ Unable to run hostname to check the network') def FortranMPICheck(self): '''Make sure fortran include [mpif.h] and library symbols are found''' - if not hasattr(self.compilers, 'FC'): + if not hasattr(self.compilers, 'FC') or not self.argDB['with-fortran-bindings']: return 0 # Fortran compiler is being used - so make sure mpif.h exists self.libraries.pushLanguage('FC') If MS-MPI is missing mpi.mod - I guess we'll have to revert this requirement. For some reason the tests in CI don't error out. I'll have to check. I can add back mpif.h usage [without the extra complex code we had for handling some corner cases - in this mode] Satish > > Thanks, > Pierre > > > Thanks, > > > > Matt > > > > Yet, I’m now hit by: > > ******************************************************************************* > > UNABLE to CONFIGURE with GIVEN OPTIONS (see configure.log for details): > > ------------------------------------------------------------------------------- > > mpi.mod not found! PETSc fortran interface requires a working mpi.mod > > ******************************************************************************* > > Could this be fixed somehow, please? > > Thanks, > > Pierre > > > > > > -- > > What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. > > -- Norbert Wiener > > > > https://www.cse.buffalo.edu/~knepley/ <http://www.cse.buffalo.edu/~knepley/> >

1 0

Re: [petsc-dev] mpi.mod --with-fortran-interfaces=0
by Pierre Jolivet 24 Mar '21

24 Mar '21

> On 24 Mar 2021, at 2:55 PM, Matthew Knepley <knepley(a)gmail.com> wrote: > > On Wed, Mar 24, 2021 at 9:37 AM Pierre Jolivet <pierre(a)joliv.et <mailto:[email protected]>> wrote: > Hello, > It seems mpi.mod is now mandatory https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec… <https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec…>. > mpi.mod is not shipped by MS-MPI. > I want to build MUMPS through PETSc and don’t really care about the Fortran PETSc interface on our Windows boxes (--with-fortran-interfaces=0). > > I think you want --with-fc=0, which should turn off this check. No, I have gfortran, I want to compile MUMPS with PETSc, that won’t work --with-fc=0. Also, the error message in the configure is wrong, it should read "PETSc Fortran bindings” (not “fortran interface”), and in my email, one should replace --with-fortran-interfaces by --with-fortran-bindings, sorry about that. I guess there is a missing check before raise RuntimeError('mpi.mod not found! PETSc fortran interface requires a working mpi.mod'), like if self.argDB['with-fortran-interfaces'] But I don’t know if that makes sense. Thanks, Pierre > Thanks, > > Matt > > Yet, I’m now hit by: > ******************************************************************************* > UNABLE to CONFIGURE with GIVEN OPTIONS (see configure.log for details): > ------------------------------------------------------------------------------- > mpi.mod not found! PETSc fortran interface requires a working mpi.mod > ******************************************************************************* > Could this be fixed somehow, please? > Thanks, > Pierre > > > -- > What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. > -- Norbert Wiener > > https://www.cse.buffalo.edu/~knepley/ <http://www.cse.buffalo.edu/~knepley/>

1 0

Re: [petsc-dev] mpi.mod --with-fortran-interfaces=0
by Matthew Knepley 24 Mar '21

24 Mar '21

On Wed, Mar 24, 2021 at 9:37 AM Pierre Jolivet <pierre(a)joliv.et> wrote: > Hello, > It seems mpi.mod is now mandatory > https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec… > . > mpi.mod is not shipped by MS-MPI. > I want to build MUMPS through PETSc and don’t really care about the > Fortran PETSc interface on our Windows boxes (--with-fortran-interfaces=0). > I think you want --with-fc=0, which should turn off this check. Thanks, Matt > Yet, I’m now hit by: > > ******************************************************************************* > UNABLE to CONFIGURE with GIVEN OPTIONS (see configure.log for > details): > > ------------------------------------------------------------------------------- > mpi.mod not found! PETSc fortran interface requires a working mpi.mod > > ******************************************************************************* > Could this be fixed somehow, please? > Thanks, > Pierre > -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener https://www.cse.buffalo.edu/~knepley/ <http://www.cse.buffalo.edu/~knepley/>

1 0

mpi.mod --with-fortran-interfaces=0
by Pierre Jolivet 24 Mar '21

24 Mar '21

Hello, It seems mpi.mod is now mandatory https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec… <https://gitlab.com/petsc/petsc/-/commit/68bd534a466d12bdec28b4c298b715271ec…>. mpi.mod is not shipped by MS-MPI. I want to build MUMPS through PETSc and don’t really care about the Fortran PETSc interface on our Windows boxes (--with-fortran-interfaces=0). Yet, I’m now hit by: ******************************************************************************* UNABLE to CONFIGURE with GIVEN OPTIONS (see configure.log for details): ------------------------------------------------------------------------------- mpi.mod not found! PETSc fortran interface requires a working mpi.mod ******************************************************************************* Could this be fixed somehow, please? Thanks, Pierre

1 0

Re: [petsc-dev] configureLibrary fails for c++11 projects
by Stefano Zampini 24 Mar '21

24 Mar '21

I will open an MR then Il giorno mar 23 mar 2021 alle ore 22:42 Matthew Knepley <knepley(a)gmail.com> ha scritto: > > On Tue, Mar 23, 2021 at 1:15 PM Junchao Zhang <junchao.zhang(a)gmail.com> > wrote: > >> Can we combine CXXPPFLAGS and CXXFLAGS into one CXXFLAGS? >> > > No. There are compiler-only flags. > > Matt > > >> --Junchao Zhang >> >> >> On Tue, Mar 23, 2021 at 11:38 AM Patrick Sanan <patrick.sanan(a)gmail.com> >> wrote: >> >>> I had a related (I think) issue trying to build with Kokkos. Those >>> headers throw an #error if they're expecting OpenMP and the compiler >>> doesn't have the OpenMP flag. I have an open MR here (number 60^2!) which >>> thus adds the OpenMP flag to the CXXPPFLAGS: >>> https://gitlab.com/petsc/petsc/-/merge_requests/3600 >>> >>> >>> My collaborator at CSCS was testing with the latest Kokkos and ran into >>> an even hairier version of this problem trying to use CUDA - the Kokkos >>> headers now apparently check that you're using nvcc. He has some workaround >>> which I'll review and hopefully be able to submit. >>> >>> >>> Am 23.03.2021 um 17:04 schrieb Stefano Zampini < >>> stefano.zampini(a)gmail.com>: >>> >>> The check fails within buildsystem when running mpicc -E (which uses >>> CXXPPFLAGS) The package header needs c++11 to be included properly. >>> C++11 is also needed at preprocessing time >>> >>> Il Mar 23 Mar 2021, 18:59 Satish Balay <balay(a)mcs.anl.gov> ha scritto: >>> >>>> -std=cxx11 for sure is a compile flag. But don't really know if its >>>> also needed at pre-process stage and/or at link stage. >>>> >>>> And for compile stage both CXXFLAGS and CXXPPFLAGS should get >>>> used. [PETSc makefiles make sure this is the case] >>>> >>>> And for link stage CXXFLAGS and LDFLAGS get used [but then sometimes >>>> we have CLINKER, and FLINKER - and they certainly don't use CXXFLAGS - >>>> so -std=cxx11 isn't really needed at link time? >>>> >>>> So the previous default of CXXPPFLAGS=-std=cxx11 looks reasonable to me. >>>> >>>> However if this project is not using PETSc makefiles - it should make >>>> sure all compile flags are grabbed. >>>> >>>> # lib/petsc/conf/variables >>>> PETSC_CXXCPPFLAGS = ${PETSC_CC_INCLUDES} ${PETSCFLAGS} >>>> ${CXXPP_FLAGS} ${CXXPPFLAGS} >>>> CXXCPPFLAGS = ${PETSC_CXXCPPFLAGS} >>>> PETSC_CXXCOMPILE_SINGLE = ${CXX} -o $*.o -c ${CXX_FLAGS} ${CXXFLAGS} >>>> ${CXXCPPFLAGS} >>>> >>>> # lib/petsc/conf/rules >>>> .cpp.o .cxx.o .cc.o .C.o: >>>> ${PETSC_CXXCOMPILE_SINGLE} `pwd`/$< >>>> >>>> # gmakefile.test >>>> PETSC_COMPILE.cxx = $(call quiet,CXX) -c $(CXX_FLAGS) $(CXXFLAGS) >>>> $(CXXCPPFLAGS) $(CXX_DEPFLAGS) >>>> >>>> # lib/petsc/conf/test >>>> LINK.cc = $(CXXLINKER) $(CXX_FLAGS) $(CXXFLAGS) $(CXXCPPFLAGS) >>>> $(LDFLAGS) >>>> >>>> Satish >>>> >>>> >>>> On Tue, 23 Mar 2021, Junchao Zhang wrote: >>>> >>>> > I would rather directly change the project to use CXXFLAGS instead of >>>> > CXXPPFLAGS. >>>> > >>>> > --Junchao Zhang >>>> > >>>> > >>>> > On Tue, Mar 23, 2021 at 10:01 AM Satish Balay via petsc-dev < >>>> > petsc-dev(a)mcs.anl.gov> wrote: >>>> > >>>> > > On Tue, 23 Mar 2021, Stefano Zampini wrote: >>>> > > >>>> > > > Just tried out of main, and and the include tests of a c++11 >>>> project fail >>>> > > > Below my fix, if we agree on, I'll make a MR >>>> > > > >>>> > > > diff --git a/config/BuildSystem/config/compilers.py >>>> > > > b/config/BuildSystem/config/compilers.py >>>> > > > index c96967e..44e4657 100644 >>>> > > > --- a/config/BuildSystem/config/compilers.py >>>> > > > +++ b/config/BuildSystem/config/compilers.py >>>> > > > @@ -527,6 +527,8 @@ class Configure(config.base.Configure): >>>> > > > if self.setCompilers.checkCompilerFlag(flag, includes, >>>> > > > body+body14): >>>> > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' >>>> ' + >>>> > > flag # >>>> > > > append flag to the old >>>> > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) >>>> > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + >>>> ' ' + >>>> > > flag >>>> > > > # append flag to the old >>>> > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) >>>> > > >>>> > > >>>> > > >>>> https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c… >>>> > > >>>> > > self.setCompilers.CXXPPFLAGS += ' ' + flag >>>> > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + >>>> flag # >>>> > > append flag to the old >>>> > > setattr(self.setCompilers,LANG+'FLAGS',newflag) >>>> > > >>>> > > So the old code was setting 'PPFLAGS' - but this commit changed to >>>> > > 'FLAGS'. Maybe this flag is needed at both compile time and link >>>> time? >>>> > > >>>> > > So this project is somehow using CXXPPFLAGS - but not CXXFLAGS? >>>> > > >>>> > > I'm fine with adding it to PPFLAGS - duplicate listing hopefully >>>> shouldn't >>>> > > cause grief. >>>> > > >>>> > > Satish >>>> > > >>>> > > > cxxdialect = 'C++14' >>>> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) >>>> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) >>>> > > > @@ -546,6 +548,8 @@ class Configure(config.base.Configure): >>>> > > > if self.setCompilers.checkCompilerFlag(flag, includes, >>>> body): >>>> > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' >>>> ' + >>>> > > flag # >>>> > > > append flag to the old >>>> > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) >>>> > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + >>>> ' ' + >>>> > > flag >>>> > > > # append flag to the old >>>> > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) >>>> > > > cxxdialect = 'C++11' >>>> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) >>>> > > > break >>>> > > > >>>> > > > >>>> > > > >>>> > > >>>> > > >>>> > >>>> >>>> >>> > > -- > What most experimenters take for granted before they begin their > experiments is infinitely more interesting than any results to which their > experiments lead. > -- Norbert Wiener > > https://www.cse.buffalo.edu/~knepley/ > <http://www.cse.buffalo.edu/~knepley/> > -- Stefano

1 0

Re: [petsc-dev] configureLibrary fails for c++11 projects
by Matthew Knepley 23 Mar '21

23 Mar '21

On Tue, Mar 23, 2021 at 1:15 PM Junchao Zhang <junchao.zhang(a)gmail.com> wrote: > Can we combine CXXPPFLAGS and CXXFLAGS into one CXXFLAGS? > No. There are compiler-only flags. Matt > --Junchao Zhang > > > On Tue, Mar 23, 2021 at 11:38 AM Patrick Sanan <patrick.sanan(a)gmail.com> > wrote: > >> I had a related (I think) issue trying to build with Kokkos. Those >> headers throw an #error if they're expecting OpenMP and the compiler >> doesn't have the OpenMP flag. I have an open MR here (number 60^2!) which >> thus adds the OpenMP flag to the CXXPPFLAGS: >> https://gitlab.com/petsc/petsc/-/merge_requests/3600 >> >> >> My collaborator at CSCS was testing with the latest Kokkos and ran into >> an even hairier version of this problem trying to use CUDA - the Kokkos >> headers now apparently check that you're using nvcc. He has some workaround >> which I'll review and hopefully be able to submit. >> >> >> Am 23.03.2021 um 17:04 schrieb Stefano Zampini <stefano.zampini(a)gmail.com >> >: >> >> The check fails within buildsystem when running mpicc -E (which uses >> CXXPPFLAGS) The package header needs c++11 to be included properly. >> C++11 is also needed at preprocessing time >> >> Il Mar 23 Mar 2021, 18:59 Satish Balay <balay(a)mcs.anl.gov> ha scritto: >> >>> -std=cxx11 for sure is a compile flag. But don't really know if its >>> also needed at pre-process stage and/or at link stage. >>> >>> And for compile stage both CXXFLAGS and CXXPPFLAGS should get >>> used. [PETSc makefiles make sure this is the case] >>> >>> And for link stage CXXFLAGS and LDFLAGS get used [but then sometimes >>> we have CLINKER, and FLINKER - and they certainly don't use CXXFLAGS - >>> so -std=cxx11 isn't really needed at link time? >>> >>> So the previous default of CXXPPFLAGS=-std=cxx11 looks reasonable to me. >>> >>> However if this project is not using PETSc makefiles - it should make >>> sure all compile flags are grabbed. >>> >>> # lib/petsc/conf/variables >>> PETSC_CXXCPPFLAGS = ${PETSC_CC_INCLUDES} ${PETSCFLAGS} >>> ${CXXPP_FLAGS} ${CXXPPFLAGS} >>> CXXCPPFLAGS = ${PETSC_CXXCPPFLAGS} >>> PETSC_CXXCOMPILE_SINGLE = ${CXX} -o $*.o -c ${CXX_FLAGS} ${CXXFLAGS} >>> ${CXXCPPFLAGS} >>> >>> # lib/petsc/conf/rules >>> .cpp.o .cxx.o .cc.o .C.o: >>> ${PETSC_CXXCOMPILE_SINGLE} `pwd`/$< >>> >>> # gmakefile.test >>> PETSC_COMPILE.cxx = $(call quiet,CXX) -c $(CXX_FLAGS) $(CXXFLAGS) >>> $(CXXCPPFLAGS) $(CXX_DEPFLAGS) >>> >>> # lib/petsc/conf/test >>> LINK.cc = $(CXXLINKER) $(CXX_FLAGS) $(CXXFLAGS) $(CXXCPPFLAGS) >>> $(LDFLAGS) >>> >>> Satish >>> >>> >>> On Tue, 23 Mar 2021, Junchao Zhang wrote: >>> >>> > I would rather directly change the project to use CXXFLAGS instead of >>> > CXXPPFLAGS. >>> > >>> > --Junchao Zhang >>> > >>> > >>> > On Tue, Mar 23, 2021 at 10:01 AM Satish Balay via petsc-dev < >>> > petsc-dev(a)mcs.anl.gov> wrote: >>> > >>> > > On Tue, 23 Mar 2021, Stefano Zampini wrote: >>> > > >>> > > > Just tried out of main, and and the include tests of a c++11 >>> project fail >>> > > > Below my fix, if we agree on, I'll make a MR >>> > > > >>> > > > diff --git a/config/BuildSystem/config/compilers.py >>> > > > b/config/BuildSystem/config/compilers.py >>> > > > index c96967e..44e4657 100644 >>> > > > --- a/config/BuildSystem/config/compilers.py >>> > > > +++ b/config/BuildSystem/config/compilers.py >>> > > > @@ -527,6 +527,8 @@ class Configure(config.base.Configure): >>> > > > if self.setCompilers.checkCompilerFlag(flag, includes, >>> > > > body+body14): >>> > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' >>> + >>> > > flag # >>> > > > append flag to the old >>> > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) >>> > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' >>> ' + >>> > > flag >>> > > > # append flag to the old >>> > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) >>> > > >>> > > >>> > > >>> https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c… >>> > > >>> > > self.setCompilers.CXXPPFLAGS += ' ' + flag >>> > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + >>> flag # >>> > > append flag to the old >>> > > setattr(self.setCompilers,LANG+'FLAGS',newflag) >>> > > >>> > > So the old code was setting 'PPFLAGS' - but this commit changed to >>> > > 'FLAGS'. Maybe this flag is needed at both compile time and link >>> time? >>> > > >>> > > So this project is somehow using CXXPPFLAGS - but not CXXFLAGS? >>> > > >>> > > I'm fine with adding it to PPFLAGS - duplicate listing hopefully >>> shouldn't >>> > > cause grief. >>> > > >>> > > Satish >>> > > >>> > > > cxxdialect = 'C++14' >>> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) >>> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) >>> > > > @@ -546,6 +548,8 @@ class Configure(config.base.Configure): >>> > > > if self.setCompilers.checkCompilerFlag(flag, includes, >>> body): >>> > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' >>> + >>> > > flag # >>> > > > append flag to the old >>> > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) >>> > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' >>> ' + >>> > > flag >>> > > > # append flag to the old >>> > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) >>> > > > cxxdialect = 'C++11' >>> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) >>> > > > break >>> > > > >>> > > > >>> > > > >>> > > >>> > > >>> > >>> >>> >> -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener https://www.cse.buffalo.edu/~knepley/ <http://www.cse.buffalo.edu/~knepley/>

1 0

Re: [petsc-dev] configureLibrary fails for c++11 projects
by Satish Balay 23 Mar '21

23 Mar '21

And I think there are some flags that can't be used at link time [so they have to go into CPPFLAGS and not CFLAGS - as CFLAGS gets used with CLINKER aswell] Satish On Tue, 23 Mar 2021, Satish Balay via petsc-dev wrote: > I'm not sure if we can eliminate preprocessing. [mpi.h detection is > one place where its used - don't remember others - perhaps detection > of most includes? - some externalpacakges need them listed > separately?] > > And as long as we need preprocessing as a separate step [and some > compile flags give errors when used with processor] - we'll need > separate PPFLAGS. > > > Satish > > On Tue, 23 Mar 2021, Junchao Zhang wrote: > > > Can we combine CXXPPFLAGS and CXXFLAGS into one CXXFLAGS? > > --Junchao Zhang > > > > > > On Tue, Mar 23, 2021 at 11:38 AM Patrick Sanan <patrick.sanan(a)gmail.com> > > wrote: > > > > > I had a related (I think) issue trying to build with Kokkos. Those headers > > > throw an #error if they're expecting OpenMP and the compiler doesn't have > > > the OpenMP flag. I have an open MR here (number 60^2!) which thus adds the > > > OpenMP flag to the CXXPPFLAGS: > > > https://gitlab.com/petsc/petsc/-/merge_requests/3600 > > > > > > > > > My collaborator at CSCS was testing with the latest Kokkos and ran into an > > > even hairier version of this problem trying to use CUDA - the Kokkos > > > headers now apparently check that you're using nvcc. He has some workaround > > > which I'll review and hopefully be able to submit. > > > > > > > > > Am 23.03.2021 um 17:04 schrieb Stefano Zampini <stefano.zampini(a)gmail.com > > > >: > > > > > > The check fails within buildsystem when running mpicc -E (which uses > > > CXXPPFLAGS) The package header needs c++11 to be included properly. > > > C++11 is also needed at preprocessing time > > > > > > Il Mar 23 Mar 2021, 18:59 Satish Balay <balay(a)mcs.anl.gov> ha scritto: > > > > > >> -std=cxx11 for sure is a compile flag. But don't really know if its > > >> also needed at pre-process stage and/or at link stage. > > >> > > >> And for compile stage both CXXFLAGS and CXXPPFLAGS should get > > >> used. [PETSc makefiles make sure this is the case] > > >> > > >> And for link stage CXXFLAGS and LDFLAGS get used [but then sometimes > > >> we have CLINKER, and FLINKER - and they certainly don't use CXXFLAGS - > > >> so -std=cxx11 isn't really needed at link time? > > >> > > >> So the previous default of CXXPPFLAGS=-std=cxx11 looks reasonable to me. > > >> > > >> However if this project is not using PETSc makefiles - it should make > > >> sure all compile flags are grabbed. > > >> > > >> # lib/petsc/conf/variables > > >> PETSC_CXXCPPFLAGS = ${PETSC_CC_INCLUDES} ${PETSCFLAGS} > > >> ${CXXPP_FLAGS} ${CXXPPFLAGS} > > >> CXXCPPFLAGS = ${PETSC_CXXCPPFLAGS} > > >> PETSC_CXXCOMPILE_SINGLE = ${CXX} -o $*.o -c ${CXX_FLAGS} ${CXXFLAGS} > > >> ${CXXCPPFLAGS} > > >> > > >> # lib/petsc/conf/rules > > >> .cpp.o .cxx.o .cc.o .C.o: > > >> ${PETSC_CXXCOMPILE_SINGLE} `pwd`/$< > > >> > > >> # gmakefile.test > > >> PETSC_COMPILE.cxx = $(call quiet,CXX) -c $(CXX_FLAGS) $(CXXFLAGS) > > >> $(CXXCPPFLAGS) $(CXX_DEPFLAGS) > > >> > > >> # lib/petsc/conf/test > > >> LINK.cc = $(CXXLINKER) $(CXX_FLAGS) $(CXXFLAGS) $(CXXCPPFLAGS) $(LDFLAGS) > > >> > > >> Satish > > >> > > >> > > >> On Tue, 23 Mar 2021, Junchao Zhang wrote: > > >> > > >> > I would rather directly change the project to use CXXFLAGS instead of > > >> > CXXPPFLAGS. > > >> > > > >> > --Junchao Zhang > > >> > > > >> > > > >> > On Tue, Mar 23, 2021 at 10:01 AM Satish Balay via petsc-dev < > > >> > petsc-dev(a)mcs.anl.gov> wrote: > > >> > > > >> > > On Tue, 23 Mar 2021, Stefano Zampini wrote: > > >> > > > > >> > > > Just tried out of main, and and the include tests of a c++11 > > >> project fail > > >> > > > Below my fix, if we agree on, I'll make a MR > > >> > > > > > >> > > > diff --git a/config/BuildSystem/config/compilers.py > > >> > > > b/config/BuildSystem/config/compilers.py > > >> > > > index c96967e..44e4657 100644 > > >> > > > --- a/config/BuildSystem/config/compilers.py > > >> > > > +++ b/config/BuildSystem/config/compilers.py > > >> > > > @@ -527,6 +527,8 @@ class Configure(config.base.Configure): > > >> > > > if self.setCompilers.checkCompilerFlag(flag, includes, > > >> > > > body+body14): > > >> > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > > >> > > flag # > > >> > > > append flag to the old > > >> > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > >> > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' > > >> ' + > > >> > > flag > > >> > > > # append flag to the old > > >> > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > > >> > > > > >> > > > > >> > > > > >> https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c… > > >> > > > > >> > > self.setCompilers.CXXPPFLAGS += ' ' + flag > > >> > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > > >> flag # > > >> > > append flag to the old > > >> > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > >> > > > > >> > > So the old code was setting 'PPFLAGS' - but this commit changed to > > >> > > 'FLAGS'. Maybe this flag is needed at both compile time and link time? > > >> > > > > >> > > So this project is somehow using CXXPPFLAGS - but not CXXFLAGS? > > >> > > > > >> > > I'm fine with adding it to PPFLAGS - duplicate listing hopefully > > >> shouldn't > > >> > > cause grief. > > >> > > > > >> > > Satish > > >> > > > > >> > > > cxxdialect = 'C++14' > > >> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) > > >> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > > >> > > > @@ -546,6 +548,8 @@ class Configure(config.base.Configure): > > >> > > > if self.setCompilers.checkCompilerFlag(flag, includes, > > >> body): > > >> > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > > >> > > flag # > > >> > > > append flag to the old > > >> > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > > >> > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' > > >> ' + > > >> > > flag > > >> > > > # append flag to the old > > >> > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > > >> > > > cxxdialect = 'C++11' > > >> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > > >> > > > break > > >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > > > >> > > > >> > > >> > > > > > >

1 0

Re: [petsc-dev] configureLibrary fails for c++11 projects
by Satish Balay 23 Mar '21

23 Mar '21

I'm not sure if we can eliminate preprocessing. [mpi.h detection is one place where its used - don't remember others - perhaps detection of most includes? - some externalpacakges need them listed separately?] And as long as we need preprocessing as a separate step [and some compile flags give errors when used with processor] - we'll need separate PPFLAGS. Satish On Tue, 23 Mar 2021, Junchao Zhang wrote: > Can we combine CXXPPFLAGS and CXXFLAGS into one CXXFLAGS? > --Junchao Zhang > > > On Tue, Mar 23, 2021 at 11:38 AM Patrick Sanan <patrick.sanan(a)gmail.com> > wrote: > > > I had a related (I think) issue trying to build with Kokkos. Those headers > > throw an #error if they're expecting OpenMP and the compiler doesn't have > > the OpenMP flag. I have an open MR here (number 60^2!) which thus adds the > > OpenMP flag to the CXXPPFLAGS: > > https://gitlab.com/petsc/petsc/-/merge_requests/3600 > > > > > > My collaborator at CSCS was testing with the latest Kokkos and ran into an > > even hairier version of this problem trying to use CUDA - the Kokkos > > headers now apparently check that you're using nvcc. He has some workaround > > which I'll review and hopefully be able to submit. > > > > > > Am 23.03.2021 um 17:04 schrieb Stefano Zampini <stefano.zampini(a)gmail.com > > >: > > > > The check fails within buildsystem when running mpicc -E (which uses > > CXXPPFLAGS) The package header needs c++11 to be included properly. > > C++11 is also needed at preprocessing time > > > > Il Mar 23 Mar 2021, 18:59 Satish Balay <balay(a)mcs.anl.gov> ha scritto: > > > >> -std=cxx11 for sure is a compile flag. But don't really know if its > >> also needed at pre-process stage and/or at link stage. > >> > >> And for compile stage both CXXFLAGS and CXXPPFLAGS should get > >> used. [PETSc makefiles make sure this is the case] > >> > >> And for link stage CXXFLAGS and LDFLAGS get used [but then sometimes > >> we have CLINKER, and FLINKER - and they certainly don't use CXXFLAGS - > >> so -std=cxx11 isn't really needed at link time? > >> > >> So the previous default of CXXPPFLAGS=-std=cxx11 looks reasonable to me. > >> > >> However if this project is not using PETSc makefiles - it should make > >> sure all compile flags are grabbed. > >> > >> # lib/petsc/conf/variables > >> PETSC_CXXCPPFLAGS = ${PETSC_CC_INCLUDES} ${PETSCFLAGS} > >> ${CXXPP_FLAGS} ${CXXPPFLAGS} > >> CXXCPPFLAGS = ${PETSC_CXXCPPFLAGS} > >> PETSC_CXXCOMPILE_SINGLE = ${CXX} -o $*.o -c ${CXX_FLAGS} ${CXXFLAGS} > >> ${CXXCPPFLAGS} > >> > >> # lib/petsc/conf/rules > >> .cpp.o .cxx.o .cc.o .C.o: > >> ${PETSC_CXXCOMPILE_SINGLE} `pwd`/$< > >> > >> # gmakefile.test > >> PETSC_COMPILE.cxx = $(call quiet,CXX) -c $(CXX_FLAGS) $(CXXFLAGS) > >> $(CXXCPPFLAGS) $(CXX_DEPFLAGS) > >> > >> # lib/petsc/conf/test > >> LINK.cc = $(CXXLINKER) $(CXX_FLAGS) $(CXXFLAGS) $(CXXCPPFLAGS) $(LDFLAGS) > >> > >> Satish > >> > >> > >> On Tue, 23 Mar 2021, Junchao Zhang wrote: > >> > >> > I would rather directly change the project to use CXXFLAGS instead of > >> > CXXPPFLAGS. > >> > > >> > --Junchao Zhang > >> > > >> > > >> > On Tue, Mar 23, 2021 at 10:01 AM Satish Balay via petsc-dev < > >> > petsc-dev(a)mcs.anl.gov> wrote: > >> > > >> > > On Tue, 23 Mar 2021, Stefano Zampini wrote: > >> > > > >> > > > Just tried out of main, and and the include tests of a c++11 > >> project fail > >> > > > Below my fix, if we agree on, I'll make a MR > >> > > > > >> > > > diff --git a/config/BuildSystem/config/compilers.py > >> > > > b/config/BuildSystem/config/compilers.py > >> > > > index c96967e..44e4657 100644 > >> > > > --- a/config/BuildSystem/config/compilers.py > >> > > > +++ b/config/BuildSystem/config/compilers.py > >> > > > @@ -527,6 +527,8 @@ class Configure(config.base.Configure): > >> > > > if self.setCompilers.checkCompilerFlag(flag, includes, > >> > > > body+body14): > >> > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > >> > > flag # > >> > > > append flag to the old > >> > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > >> > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' > >> ' + > >> > > flag > >> > > > # append flag to the old > >> > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > >> > > > >> > > > >> > > > >> https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c… > >> > > > >> > > self.setCompilers.CXXPPFLAGS += ' ' + flag > >> > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > >> flag # > >> > > append flag to the old > >> > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > >> > > > >> > > So the old code was setting 'PPFLAGS' - but this commit changed to > >> > > 'FLAGS'. Maybe this flag is needed at both compile time and link time? > >> > > > >> > > So this project is somehow using CXXPPFLAGS - but not CXXFLAGS? > >> > > > >> > > I'm fine with adding it to PPFLAGS - duplicate listing hopefully > >> shouldn't > >> > > cause grief. > >> > > > >> > > Satish > >> > > > >> > > > cxxdialect = 'C++14' > >> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) > >> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > >> > > > @@ -546,6 +548,8 @@ class Configure(config.base.Configure): > >> > > > if self.setCompilers.checkCompilerFlag(flag, includes, > >> body): > >> > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + > >> > > flag # > >> > > > append flag to the old > >> > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) > >> > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' > >> ' + > >> > > flag > >> > > > # append flag to the old > >> > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) > >> > > > cxxdialect = 'C++11' > >> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) > >> > > > break > >> > > > > >> > > > > >> > > > > >> > > > >> > > > >> > > >> > >> > > >

1 0

Re: [petsc-dev] configureLibrary fails for c++11 projects
by Junchao Zhang 23 Mar '21

23 Mar '21

Can we combine CXXPPFLAGS and CXXFLAGS into one CXXFLAGS? --Junchao Zhang On Tue, Mar 23, 2021 at 11:38 AM Patrick Sanan <patrick.sanan(a)gmail.com> wrote: > I had a related (I think) issue trying to build with Kokkos. Those headers > throw an #error if they're expecting OpenMP and the compiler doesn't have > the OpenMP flag. I have an open MR here (number 60^2!) which thus adds the > OpenMP flag to the CXXPPFLAGS: > https://gitlab.com/petsc/petsc/-/merge_requests/3600 > > > My collaborator at CSCS was testing with the latest Kokkos and ran into an > even hairier version of this problem trying to use CUDA - the Kokkos > headers now apparently check that you're using nvcc. He has some workaround > which I'll review and hopefully be able to submit. > > > Am 23.03.2021 um 17:04 schrieb Stefano Zampini <stefano.zampini(a)gmail.com > >: > > The check fails within buildsystem when running mpicc -E (which uses > CXXPPFLAGS) The package header needs c++11 to be included properly. > C++11 is also needed at preprocessing time > > Il Mar 23 Mar 2021, 18:59 Satish Balay <balay(a)mcs.anl.gov> ha scritto: > >> -std=cxx11 for sure is a compile flag. But don't really know if its >> also needed at pre-process stage and/or at link stage. >> >> And for compile stage both CXXFLAGS and CXXPPFLAGS should get >> used. [PETSc makefiles make sure this is the case] >> >> And for link stage CXXFLAGS and LDFLAGS get used [but then sometimes >> we have CLINKER, and FLINKER - and they certainly don't use CXXFLAGS - >> so -std=cxx11 isn't really needed at link time? >> >> So the previous default of CXXPPFLAGS=-std=cxx11 looks reasonable to me. >> >> However if this project is not using PETSc makefiles - it should make >> sure all compile flags are grabbed. >> >> # lib/petsc/conf/variables >> PETSC_CXXCPPFLAGS = ${PETSC_CC_INCLUDES} ${PETSCFLAGS} >> ${CXXPP_FLAGS} ${CXXPPFLAGS} >> CXXCPPFLAGS = ${PETSC_CXXCPPFLAGS} >> PETSC_CXXCOMPILE_SINGLE = ${CXX} -o $*.o -c ${CXX_FLAGS} ${CXXFLAGS} >> ${CXXCPPFLAGS} >> >> # lib/petsc/conf/rules >> .cpp.o .cxx.o .cc.o .C.o: >> ${PETSC_CXXCOMPILE_SINGLE} `pwd`/$< >> >> # gmakefile.test >> PETSC_COMPILE.cxx = $(call quiet,CXX) -c $(CXX_FLAGS) $(CXXFLAGS) >> $(CXXCPPFLAGS) $(CXX_DEPFLAGS) >> >> # lib/petsc/conf/test >> LINK.cc = $(CXXLINKER) $(CXX_FLAGS) $(CXXFLAGS) $(CXXCPPFLAGS) $(LDFLAGS) >> >> Satish >> >> >> On Tue, 23 Mar 2021, Junchao Zhang wrote: >> >> > I would rather directly change the project to use CXXFLAGS instead of >> > CXXPPFLAGS. >> > >> > --Junchao Zhang >> > >> > >> > On Tue, Mar 23, 2021 at 10:01 AM Satish Balay via petsc-dev < >> > petsc-dev(a)mcs.anl.gov> wrote: >> > >> > > On Tue, 23 Mar 2021, Stefano Zampini wrote: >> > > >> > > > Just tried out of main, and and the include tests of a c++11 >> project fail >> > > > Below my fix, if we agree on, I'll make a MR >> > > > >> > > > diff --git a/config/BuildSystem/config/compilers.py >> > > > b/config/BuildSystem/config/compilers.py >> > > > index c96967e..44e4657 100644 >> > > > --- a/config/BuildSystem/config/compilers.py >> > > > +++ b/config/BuildSystem/config/compilers.py >> > > > @@ -527,6 +527,8 @@ class Configure(config.base.Configure): >> > > > if self.setCompilers.checkCompilerFlag(flag, includes, >> > > > body+body14): >> > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + >> > > flag # >> > > > append flag to the old >> > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) >> > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' >> ' + >> > > flag >> > > > # append flag to the old >> > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) >> > > >> > > >> > > >> https://gitlab.com/petsc/petsc/commit/ead1aa4045d7bca177e78933b9ca25145fc3c… >> > > >> > > self.setCompilers.CXXPPFLAGS += ' ' + flag >> > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + >> flag # >> > > append flag to the old >> > > setattr(self.setCompilers,LANG+'FLAGS',newflag) >> > > >> > > So the old code was setting 'PPFLAGS' - but this commit changed to >> > > 'FLAGS'. Maybe this flag is needed at both compile time and link time? >> > > >> > > So this project is somehow using CXXPPFLAGS - but not CXXFLAGS? >> > > >> > > I'm fine with adding it to PPFLAGS - duplicate listing hopefully >> shouldn't >> > > cause grief. >> > > >> > > Satish >> > > >> > > > cxxdialect = 'C++14' >> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX14',1) >> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) >> > > > @@ -546,6 +548,8 @@ class Configure(config.base.Configure): >> > > > if self.setCompilers.checkCompilerFlag(flag, includes, >> body): >> > > > newflag = getattr(self.setCompilers,LANG+'FLAGS') + ' ' + >> > > flag # >> > > > append flag to the old >> > > > setattr(self.setCompilers,LANG+'FLAGS',newflag) >> > > > + newflag = getattr(self.setCompilers,LANG+'PPFLAGS') + ' >> ' + >> > > flag >> > > > # append flag to the old >> > > > + setattr(self.setCompilers,LANG+'PPFLAGS',newflag) >> > > > cxxdialect = 'C++11' >> > > > self.addDefine('HAVE_'+LANG+'_DIALECT_CXX11',1) >> > > > break >> > > > >> > > > >> > > > >> > > >> > > >> > >> >> >

1 0