February 2011 - cgma-dev - mailman3.cels.anl.gov

Re: [cgma-dev] Large OCC subtraction time
by Jiangtao Hu 26 Feb '11

26 Feb '11

Hi, Rajeev: Thank you for providing the testcase. OCC did have a reputation of getting much slower with larger models and more operations. I'll have a look on Monday to see if there's anything I can do on cgm side that can speed it up. Have a nice weekend! Jane --- On Fri, 2/25/11, Rajeev Jain <jain(a)mcs.anl.gov> wrote: From: Rajeev Jain <jain(a)mcs.anl.gov> Subject: [cgma-dev] Large OCC subtraction time To: cgma-dev(a)mcs.anl.gov Date: Friday, February 25, 2011, 4:21 PM When subtracting 325 pins from a block, OCC takes a lot more time than the corresponding ACIS model. I'm attaching the assygen .inp that can be run as MeshKit/rgg>assygen 7. This file is for OCC version of MeshKit. For ACIS change the geometry engine to ACIS in the .inp file and run ACIS version. RGG o/p: ACIS: Normal Termination. Geometry file: 7.sat saved. Schemes file created: 7.template.jou Cubit journal file created: 7.jou Ending at : Fri Feb 25 15:10:31 2011 Elapsed wall clock time: 8 seconds or 0.133333 mins OCC: Exported: 327 OCC Bodies to 7.stp Normal Termination. Geometry file: 7.stp saved. Schemes file created: 7.template.jou Cubit journal file created: 7.jou Ending at : Fri Feb 25 14:59:51 2011 Elapsed wall clock time: 3173 seconds or 52.8833 mins The geometry files can be found at /homes/jain/MeshKit-all/trunk/rgg/test/geometry_parallel_meshing/7.stp and 7.sat Rajeev

1 0

Large OCC subtraction time
by Rajeev Jain 25 Feb '11

25 Feb '11

When subtracting 325 pins from a block, OCC takes a lot more time than the corresponding ACIS model. I'm attaching the assygen .inp that can be run as MeshKit/rgg>assygen 7. This file is for OCC version of MeshKit. For ACIS change the geometry engine to ACIS in the .inp file and run ACIS version. RGG o/p: ACIS: Normal Termination. Geometry file: 7.sat saved. Schemes file created: 7.template.jou Cubit journal file created: 7.jou Ending at : Fri Feb 25 15:10:31 2011 Elapsed wall clock time: 8 seconds or 0.133333 mins OCC: Exported: 327 OCC Bodies to 7.stp Normal Termination. Geometry file: 7.stp saved. Schemes file created: 7.template.jou Cubit journal file created: 7.jou Ending at : Fri Feb 25 14:59:51 2011 Elapsed wall clock time: 3173 seconds or 52.8833 mins The geometry files can be found at /homes/jain/MeshKit-all/trunk/rgg/test/geometry_parallel_meshing/7.stp and 7.sat Rajeev

1 0

r4519 - cgm/branches/merge-cubit12/geom/testing
by kraftche＠cae.wisc.edu 23 Feb '11

23 Feb '11

Author: kraftche Date: 2011-02-23 11:15:12 -0600 (Wed, 23 Feb 2011) New Revision: 4519 Modified: cgm/branches/merge-cubit12/geom/testing/Makefile.am Log: fix occ test build Modified: cgm/branches/merge-cubit12/geom/testing/Makefile.am =================================================================== --- cgm/branches/merge-cubit12/geom/testing/Makefile.am 2011-02-22 06:01:04 UTC (rev 4518) +++ cgm/branches/merge-cubit12/geom/testing/Makefile.am 2011-02-23 17:15:12 UTC (rev 4519) @@ -10,7 +10,7 @@ endif if build_OCC TESTS += $(BASE_TESTS:.engine=.occ) - AM_CPPFLAGS += -DCGM_OCC -I$(srcdir)/../OCC + AM_CPPFLAGS += -DCGM_OCC -I$(srcdir)/../OCC $(OCC_INC_FLAG) endif AM_CPPFLAGS += -I$(top_srcdir)/util -I$(top_srcdir)/geom -I.

1 0

Re: [cgma-dev] iGeom_getErrorType
by James Porter 21 Feb '11

21 Feb '11

On Sun, 2011-02-20 at 23:10 -0600, Iulian Grindeanu wrote: > Actually, we are using it in > iBase.hpp, line 209 > PFX(_getErrorType)( mInstance, &err1, &err2 ); > (it expands to iGeom_getErrorType), when ITAPS_PREFIX is iGeom > I am wondering how is this compiling. Presumably, it works because no one is actually calling that function in MeshKit. - Jim

1 0

r4515 - cgm/branches/merge-cubit12/geom/OCC
by jiangtao_ma＠yahoo.com 21 Feb '11

21 Feb '11

Author: janehu Date: 2011-02-21 12:55:25 -0600 (Mon, 21 Feb 2011) New Revision: 4515 Modified: cgm/branches/merge-cubit12/geom/OCC/OCCBody.cpp cgm/branches/merge-cubit12/geom/OCC/OCCModifyEngine.cpp cgm/branches/merge-cubit12/geom/OCC/OCCModifyEngine.hpp cgm/branches/merge-cubit12/geom/OCC/OCCSurface.cpp cgm/branches/merge-cubit12/geom/OCC/OCCSurface.hpp Log: Added 2 create_surface functions for merge_cubit12 specific requirement. Added in imprint functions to get new_tbs for history track and att_tbs for composite track . Added in OCCSurface get_points and get_hardpoints functions with are also recently added in CGM branch. Some misc. formatting. Modified: cgm/branches/merge-cubit12/geom/OCC/OCCBody.cpp =================================================================== --- cgm/branches/merge-cubit12/geom/OCC/OCCBody.cpp 2011-02-17 17:49:29 UTC (rev 4514) +++ cgm/branches/merge-cubit12/geom/OCC/OCCBody.cpp 2011-02-21 18:55:25 UTC (rev 4515) @@ -903,5 +903,13 @@ if (occ_point) points.append_unique(occ_point); } + + DLIList<OCCSurface*> surfaces; + this->get_all_surfaces(surfaces); + for(int i = 0; i < surfaces.size(); i++) + { + OCCSurface* occ_surf = surfaces.get_and_step(); + points += occ_surf->get_hardpoints(); + } } Modified: cgm/branches/merge-cubit12/geom/OCC/OCCModifyEngine.cpp =================================================================== --- cgm/branches/merge-cubit12/geom/OCC/OCCModifyEngine.cpp 2011-02-17 17:49:29 UTC (rev 4514) +++ cgm/branches/merge-cubit12/geom/OCC/OCCModifyEngine.cpp 2011-02-21 18:55:25 UTC (rev 4515) @@ -3476,12 +3476,26 @@ DLIList<TopoDS_Face*> face_list; DLIList<TopoDS_Shape*> shape_list; DLIList<TopoDS_Shape*> shape_list_all; - + DLIList<OCCSurface*> surfaces; + DLIList<OCCCurve*> curves; + DLIList<OCCPoint*> points; + assert (surface_list.size() == curve_lists_list.size()); + DLIList<OCCBody*> bodies; for(int j = 0; j < surface_list.size(); j++) { Surface* surface = surface_list.get_and_step(); + + //keep record of old bodies, surfaces, curves and points + OCCSurface* occ_surface = CAST_TO(surface, OCCSurface); + occ_surface->get_bodies(bodies); + if(j == 0) + { + bodies.get()->get_all_surfaces(surfaces); + bodies.get()->get_all_curves(curves); + bodies.get()->get_all_points(points); + } DLIList<Surface*> ref_face_list; ref_face_list.append(surface); DLIList<Curve*> *edge_list = curve_lists_list.get_and_step();

1 0

Re: [cgma-dev] iGeom_getErrorType
by Iulian Grindeanu 20 Feb '11

20 Feb '11

Actually, we are using it in iBase.hpp, line 209 PFX(_getErrorType)( mInstance, &err1, &err2 ); (it expands to iGeom_getErrorType), when ITAPS_PREFIX is iGeom I am wondering how is this compiling. Iulian ----- Original Message ----- > Hi, > I have a question about > void iGeom_getErrorType( iGeom_Instance instance, > /*out*/ int *error_type, > int *err ); > It is part of iGeom.h, but we do not implement it in iGeom_CGMA.cc > Is that intentional? It seems that we do not use it in our > applications. > (I checked merge cubit 12 branch too) > > Thanks, > Iulian

1 0

iGeom_getErrorType
by Iulian Grindeanu 20 Feb '11

20 Feb '11

Hi, I have a question about void iGeom_getErrorType( iGeom_Instance instance, /*out*/ int *error_type, int *err ); It is part of iGeom.h, but we do not implement it in iGeom_CGMA.cc Is that intentional? It seems that we do not use it in our applications. (I checked merge cubit 12 branch too) Thanks, Iulian

1 0

r4504 - cgm/trunk/geom/OCC
by jiangtao_ma＠yahoo.com 16 Feb '11

16 Feb '11

Author: janehu Date: 2011-02-16 12:21:16 -0600 (Wed, 16 Feb 2011) New Revision: 4504 Modified: cgm/trunk/geom/OCC/OCCSurface.cpp cgm/trunk/geom/OCC/OCCSurface.hpp Log: Added get_hardpoints function for OCCSurface. Modified: cgm/trunk/geom/OCC/OCCSurface.cpp =================================================================== --- cgm/trunk/geom/OCC/OCCSurface.cpp 2011-02-16 18:17:46 UTC (rev 4503) +++ cgm/trunk/geom/OCC/OCCSurface.cpp 2011-02-16 18:21:16 UTC (rev 4504) @@ -816,6 +816,7 @@ OCCCurve* curve = curves.get_and_step(); curve->get_points(points); } + points += get_hardpoints(); return points.size(); } Modified: cgm/trunk/geom/OCC/OCCSurface.hpp =================================================================== --- cgm/trunk/geom/OCC/OCCSurface.hpp 2011-02-16 18:17:46 UTC (rev 4503) +++ cgm/trunk/geom/OCC/OCCSurface.hpp 2011-02-16 18:21:16 UTC (rev 4504) @@ -75,6 +75,7 @@ void add_hardpoint(OCCPoint* HardPoint){myHardPoints.append(HardPoint);} void remove_hardpoint(OCCPoint* HardPoint){myHardPoints.remove(HardPoint);} + DLIList<OCCPoint*> get_hardpoints() {return myHardPoints;}; virtual void append_simple_attribute_virt(CubitSimpleAttrib*); //R void

1 0

r4502 - cgm/trunk/geom/OCC
by jiangtao_ma＠yahoo.com 16 Feb '11

16 Feb '11

Author: janehu Date: 2011-02-16 12:15:03 -0600 (Wed, 16 Feb 2011) New Revision: 4502 Modified: cgm/trunk/geom/OCC/OCCSurface.cpp cgm/trunk/geom/OCC/OCCSurface.hpp Log: Added get_points function for OCCSurface. Modified: cgm/trunk/geom/OCC/OCCSurface.cpp =================================================================== --- cgm/trunk/geom/OCC/OCCSurface.cpp 2011-02-16 16:10:48 UTC (rev 4501) +++ cgm/trunk/geom/OCC/OCCSurface.cpp 2011-02-16 18:15:03 UTC (rev 4502) @@ -808,6 +808,17 @@ return result_list.size(); } +int OCCSurface::get_points(DLIList<OCCPoint*>& points) +{ + DLIList<OCCCurve*> curves; + for(int i = 0; i < curves.size(); i++) + { + OCCCurve* curve = curves.get_and_step(); + curve->get_points(points); + } + return points.size(); +} + //---------------------------------------------------------------- // Function: to update the core Surface // for any movement or Boolean operation of the body. Modified: cgm/trunk/geom/OCC/OCCSurface.hpp =================================================================== --- cgm/trunk/geom/OCC/OCCSurface.hpp 2011-02-16 16:10:48 UTC (rev 4501) +++ cgm/trunk/geom/OCC/OCCSurface.hpp 2011-02-16 18:15:03 UTC (rev 4502) @@ -316,6 +316,8 @@ int get_curves(DLIList<OCCCurve*>&); + int get_points(DLIList<OCCPoint*>&); + void set_shell(OCCShell* shell) { myShell = shell;}

1 0

r4495 - cgm/branches/merge-cubit12/geom/OCC
by jiangtao_ma＠yahoo.com 15 Feb '11

15 Feb '11

Author: janehu Date: 2011-02-15 13:11:11 -0600 (Tue, 15 Feb 2011) New Revision: 4495 Modified: cgm/branches/merge-cubit12/geom/OCC/OCCLoop.cpp cgm/branches/merge-cubit12/geom/OCC/OCCLoop.hpp cgm/branches/merge-cubit12/geom/OCC/OCCModifyEngine.cpp cgm/branches/merge-cubit12/geom/OCC/OCCModifyEngine.hpp Log: Added split_curve function for merge_cubit12 specific requirement. Added update_OCC_entity function in OCCLoop for split curve operation. Added a check for clean_up_slivers opetion for split_body with vectors. Consolidate function split_shape_by_location for both split body and split curve funtions Modified: cgm/branches/merge-cubit12/geom/OCC/OCCLoop.cpp =================================================================== --- cgm/branches/merge-cubit12/geom/OCC/OCCLoop.cpp 2011-02-15 16:59:02 UTC (rev 4494) +++ cgm/branches/merge-cubit12/geom/OCC/OCCLoop.cpp 2011-02-15 19:11:11 UTC (rev 4495) @@ -36,6 +36,8 @@ #include "BRepBuilderAPI_GTransform.hxx" #include "BRepBuilderAPI_ModifyShape.hxx" #include "BRepAlgoAPI_BooleanOperation.hxx" +#include "LocOpe_SplitShape.hxx" +#include "BRepTools_WireExplorer.hxx" // ********** END CUBIT INCLUDES ********** // ********** BEGIN STATIC DECLARATIONS ********** @@ -267,3 +269,40 @@ return CUBIT_SUCCESS; } +//---------------------------------------------------------------- +// Function: TopoDS_Shape level function to update the core Loop +// for split Boolean operation of the body. +// Author: Jane Hu +//---------------------------------------------------------------- +CubitStatus OCCLoop::update_OCC_entity(TopoDS_Wire & old_loop, + LocOpe_SplitShape* sp) +{ + TopTools_ListOfShape shapes; + shapes.Assign(sp->DescendantShapes(old_loop)); + assert(shapes.Extent() == 1); + TopoDS_Shape new_loop = shapes.First(); + TopoDS_Shape shape_edge; + + //set curves + BRepTools_WireExplorer Ex; + for(Ex.Init(old_loop); Ex.More();Ex.Next()) + { + TopoDS_Edge edge = Ex.Current(); + shapes.Assign(sp->DescendantShapes(edge)); + if(shapes.Extent() > 1) + { + //update all attributes first. + TopTools_ListIteratorOfListOfShape it; + it.Initialize(shapes); + for(; it.More(); it.Next()) + { + shape_edge = it.Value(); + OCCQueryEngine::instance()->copy_attributes(edge, shape_edge); + } + OCCQueryEngine::instance()->update_OCC_map(edge, shape_edge); + } + } +

1 0