September 2012 - cgma-dev - mailman3.cels.anl.gov

Re: [cgma-dev] Make check errors...
by Iulian Grindeanu 27 Sep '12

27 Sep '12

1 0

r5759 - in cgm/trunk: cgm_apps/examples/facetdriver geom/testing test
by iulian＠mcs.anl.gov 27 Sep '12

27 Sep '12

Author: iulian Date: 2012-09-27 18:28:29 -0500 (Thu, 27 Sep 2012) New Revision: 5759 Modified: cgm/trunk/cgm_apps/examples/facetdriver/Makefile.am cgm/trunk/geom/testing/Makefile.am cgm/trunk/test/Makefile.am Log: ubuntu 12 (gcc 463) is more explicit about linking. This is the so called golden rule, which allows for faster optimizations, because the libraries to be linked with, have to be explicitly defined. Modified: cgm/trunk/cgm_apps/examples/facetdriver/Makefile.am =================================================================== --- cgm/trunk/cgm_apps/examples/facetdriver/Makefile.am 2012-09-27 20:29:19 UTC (rev 5758) +++ cgm/trunk/cgm_apps/examples/facetdriver/Makefile.am 2012-09-27 23:28:29 UTC (rev 5759) @@ -11,4 +11,4 @@ -I$(top_srcdir)/geom/Cholla \ -I$(top_srcdir)/geom/facet -LDADD = $(top_builddir)/libcgm.la $(CGM_EXT_LDFLAGS) $(CGM_EXT_LTFLAGS) +LDADD = $(top_builddir)/libcgm.la $(CGM_EXT_LDFLAGS) $(CGM_EXT_LTFLAGS) $(CGM_EXT_LIBS) Modified: cgm/trunk/geom/testing/Makefile.am =================================================================== --- cgm/trunk/geom/testing/Makefile.am 2012-09-27 20:29:19 UTC (rev 5758) +++ cgm/trunk/geom/testing/Makefile.am 2012-09-27 23:28:29 UTC (rev 5759) @@ -14,7 +14,7 @@ endif AM_CPPFLAGS += -I$(top_srcdir)/util -I$(top_srcdir)/geom -I. -LDADD = libcgm_test.la ../../libcgm.la $(CGM_EXT_LDFLAGS) $(CGM_EXT_LTFLAGS) +LDADD = libcgm_test.la ../../libcgm.la $(CGM_EXT_LDFLAGS) $(CGM_EXT_LTFLAGS) $(CGM_EXT_LIBS) check_PROGRAMS = $(BASE_TESTS:.engine=) check_SCRIPT = $(TESTS) Modified: cgm/trunk/test/Makefile.am =================================================================== --- cgm/trunk/test/Makefile.am 2012-09-27 20:29:19 UTC (rev 5758) +++ cgm/trunk/test/Makefile.am 2012-09-27 23:28:29 UTC (rev 5759) @@ -27,7 +27,7 @@ check_PROGRAMS = $(TESTS) -LDADD = ../libcgm.la +LDADD = ../libcgm.la $(CGM_EXT_LIBS) AM_LDFLAGS += $(CGM_EXT_LDFLAGS) $(CGM_EXT_LTFLAGS) webcut_SOURCES = webcut.cpp

1 0

Re: [cgma-dev] Make check errors...
by Tim Tautges 27 Sep '12

27 Sep '12

It could, but would make inserting new tests just a bit harder. The right way to do it is to tweak the dependencies to account for all the other external libs; Iulian has a fix which does that which he'll commit shortly. - tim On 09/27/2012 05:29 PM, Paul Wilson wrote: > > On 09/27/2012 04:31 PM, Tim Tautges wrote: >> Anyway, Paul, cgm.make is for applications built outside the cgm autotools setup, while make check is for things >> inside that setup. > But if the cgm.make methodology works for built apps, couldn't a similar paradigm - maybe just a different file - be > invoked for the make check. > > Paul > -- ================================================================ "You will keep in perfect peace him whose mind is steadfast, because he trusts in you." Isaiah 26:3 Tim Tautges Argonne National Laboratory (tautges(a)mcs.anl.gov) (telecommuting from UW-Madison) phone (gvoice): (608) 354-1459 1500 Engineering Dr. fax: (608) 263-4499 Madison, WI 53706

1 0

Re: [cgma-dev] Make check errors...
by Paul Wilson 27 Sep '12

27 Sep '12

On 09/27/2012 04:31 PM, Tim Tautges wrote: > Anyway, Paul, cgm.make is for applications built outside the cgm > autotools setup, while make check is for things inside that setup. But if the cgm.make methodology works for built apps, couldn't a similar paradigm - maybe just a different file - be invoked for the make check. Paul -- -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ -- Paul Wilson ~ UW-Madison ~ 608-263-0807 ~ cal: http://bit.ly/pphw-cal Associate Professor, Engineering Physics. ~ http://cnerg.engr.wisc.edu Chair, Energy Analysis & Policy Program ~ http://nelson.wisc.edu/eap

1 0

Re: [cgma-dev] Make check errors...
by Tim Tautges 27 Sep '12

27 Sep '12

Yeah, this has to do with libtool picking up the dependencies correctly. I've wrestled with that in the past (and in the past few days, trying to figure out how to get ipopt into meshkit), but I definitely haven't mastered it. Anyway, Paul, cgm.make is for applications built outside the cgm autotools setup, while make check is for things inside that setup. - tim On 09/27/2012 11:13 AM, Iulian Grindeanu wrote: > > > Hello all, > > LPATH didn't seem to work. Stuart - have you had success with that? A related question is: what do we expect > developers to do when writing their own apps? Is it sufficient to just include cgm,make? Shouldn't we just be able > to do the same thing in our tests? > > Paul > > I think that is the idea. But cgm.make is part of the install, in a way, while make check should be part of the build > test, before you do the install. > > What I still don't understand in libtool, is that moab and meshkit "make check"s are fine in ubuntu 12, shared build, > while cgm and lasso need the changes that I sent earlier. > > Somebody who knows more about autotools should be able to figure the right solution. (mine I consider a hack :( ) > > Iulian > -- ================================================================ "You will keep in perfect peace him whose mind is steadfast, because he trusts in you." Isaiah 26:3 Tim Tautges Argonne National Laboratory (tautges(a)mcs.anl.gov) (telecommuting from UW-Madison) phone (gvoice): (608) 354-1459 1500 Engineering Dr. fax: (608) 263-4499 Madison, WI 53706

1 0

r5757 - cgm/trunk/geom/OCC
by janehu＠mcs.anl.gov 27 Sep '12

27 Sep '12

Author: janehu Date: 2012-09-27 11:41:29 -0500 (Thu, 27 Sep 2012) New Revision: 5757 Modified: cgm/trunk/geom/OCC/OCCCurve.cpp cgm/trunk/geom/OCC/OCCModifyEngine.cpp cgm/trunk/geom/OCC/OCCQueryEngine.cpp Log: Back port changes in merge-cubit13.1 to cgm trunk, passed cgm check, now still double check on mcnp2cad, already passed 33. Modified: cgm/trunk/geom/OCC/OCCCurve.cpp =================================================================== --- cgm/trunk/geom/OCC/OCCCurve.cpp 2012-09-27 02:22:30 UTC (rev 5756) +++ cgm/trunk/geom/OCC/OCCCurve.cpp 2012-09-27 16:41:29 UTC (rev 5757) @@ -462,14 +462,12 @@ double sqr_dist = CUBIT_DBL_MAX; double pparam; for (int i = 1; i <= ext.NbExt(); ++i) { - if (ext.IsMin(i)) { double new_sqr_dist = p.SquareDistance( ext.Point(i).Value() ); if (new_sqr_dist < sqr_dist) { sqr_dist = new_sqr_dist; newP = ext.Point(i).Value(); pparam = ext.Point(i).Parameter(); } - } } // if we didn't find any minimum... Modified: cgm/trunk/geom/OCC/OCCModifyEngine.cpp =================================================================== --- cgm/trunk/geom/OCC/OCCModifyEngine.cpp 2012-09-27 02:22:30 UTC (rev 5756) +++ cgm/trunk/geom/OCC/OCCModifyEngine.cpp 2012-09-27 16:41:29 UTC (rev 5757) @@ -2363,13 +2363,16 @@ &cutter, keep_old); else { +/* if(!keep_old) OCCQueryEngine::instance()->delete_solid_model_entities(from_body); from_shape->Nullify(); +*/ + from_shape = NULL; } int stat; - if(!has_changed && !from_shape->IsNull()) + if(!has_changed && from_shape && !from_shape->IsNull()) { //Add imprint code here DLIList<TopoDS_Face*> face_list; @@ -2387,9 +2390,9 @@ } //ok, we're done with all cuts, construct new Body' - if (count < tool_bodies_copy.size() && !from_shape->IsNull()) + if (count < tool_bodies_copy.size() && from_shape && !from_shape->IsNull()) tbs += OCCQueryEngine::instance()->populate_topology_bridge(*from_shape); - else if (!from_shape->IsNull()) + else if (from_shape && !from_shape->IsNull())

1 0

Re: [cgma-dev] Make check errors...
by Iulian Grindeanu 27 Sep '12

27 Sep '12

| Hello all, | LPATH didn't seem to work. Stuart - have you had success with that? A | related question is: what do we expect developers to do when writing | their own apps? Is it sufficient to just include cgm,make? Shouldn't | we just be able to do the same thing in our tests? | Paul I think that is the idea. But cgm.make is part of the install, in a way, while make check should be part of the build test, before you do the install. What I still don't understand in libtool, is that moab and meshkit "make check"s are fine in ubuntu 12, shared build, while cgm and lasso need the changes that I sent earlier. Somebody who knows more about autotools should be able to figure the right solution. (mine I consider a hack :( ) Iulian

1 0

Re: [cgma-dev] Make check errors...
by Paul Wilson 27 Sep '12

27 Sep '12

On 09/26/2012 03:20 PM, Iulian Grindeanu wrote: > On 09/26/2012 01:57 PM, Paul Wilson wrote: > > Hi everyone, > > Sorry if I've missed this discussed elsewhere (or forgotten > the answer that once knew).... > > I get the following errors when I try to "make check" on CGM > built against cubit 12.2: > > wilsonp@todlaw ~/UW/research/fathom/cgm/dagmc_bld/test > > LD_LIBRARY_PATH=/opt/cubit/12.2/bin make check > make init sheet webcut brick_acis merge_acis > make[1]: Entering directory > `/home/wilsonp/UW/research/fathom/cgm/dagmc_bld/test' > make[1]: `init' is up to date. > /bin/bash ../libtool --tag=CXX --mode=link g++ -Wall > -pipe -pedantic -O2 -DNDEBUG -L/opt/cubit/12.2/bin > -R/opt/cubit/12.2/bin -o sheet sheet.o ../libcgm.la -lm > libtool: link: g++ -Wall -pipe -pedantic -O2 -DNDEBUG -o > .libs/sheet sheet.o -L/opt/cubit/12.2/bin > ../.libs/libcgm.so -lm -Wl,-rpath > -Wl,/home/wilsonp/opt/lib -Wl,-rpath -Wl,/opt/cubit/12.2/bin > /usr/bin/ld: sheet.o: undefined reference to symbol > 'Body::is_sheet_body()' > /usr/bin/ld: note: 'Body::is_sheet_body()' is defined in > DSO /opt/cubit/12.2/bin/libcubiti19.so so try adding it to > the linker command line > /opt/cubit/12.2/bin/libcubiti19.so: could not read > symbols: Invalid operation > collect2: ld returned 1 exit status > make[1]: *** [sheet] Error 1 > make[1]: Leaving directory > `/home/wilsonp/UW/research/fathom/cgm/dagmc_bld/test' > make: *** [check-am] Error 2 > > I've configured with: --enable-optimize --disable-debug > --enable-shared --with-cubit=/opt/cubit/12.2 > --prefix=/home/wilsonp/opt > > Should there be a -lcubit19 in the linker flags here? > > Hi Paul > > Try adding cubit to your LPATH as well as your LD_LIBRARY_PATH. > > Stuart > > > hello, > This is my patch needed for cgm to pass make check on ubuntu 12 > (shared build) > I didn't try setting LPATH. Hello all, LPATH didn't seem to work. Stuart - have you had success with that? A related question is: what do we expect developers to do when writing their own apps? Is it sufficient to just include cgm,make? Shouldn't we just be able to do the same thing in our tests? Paul -- -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ -- Paul Wilson ~ UW-Madison ~ 608-263-0807 ~ cal: http://bit.ly/pphw-cal Associate Professor, Engineering Physics. ~ http://cnerg.engr.wisc.edu Chair, Energy Analysis & Policy Program ~ http://nelson.wisc.edu/eap

1 0

Re: [cgma-dev] Make check errors...
by Iulian Grindeanu 26 Sep '12

26 Sep '12

and these are modifications needed for lasso, in the same context (ubuntu 12, shared build) It should not affect other builds, but I am still reluctant to commit them to repository, until I understand why are they needed; and maybe there is a better solution; LPATH could be one solution, but I do not really like it. Iulian ----- Original Message ----- | ----- Original Message ----- | | On 09/26/2012 01:57 PM, Paul Wilson wrote: | | | Hi everyone, | | | Sorry if I've missed this discussed elsewhere (or forgotten the | | | answer | | | that once knew).... | | | I get the following errors when I try to "make check" on CGM built | | | against cubit 12.2: | | | | wilsonp@todlaw ~/UW/research/fathom/cgm/dagmc_bld/test > | | | | LD_LIBRARY_PATH=/opt/cubit/12.2/bin make check | | | | make init sheet webcut brick_acis merge_acis | | | | make[1]: Entering directory | | | | `/home/wilsonp/UW/research/fathom/cgm/dagmc_bld/test' | | | | make[1]: `init' is up to date. | | | | /bin/bash ../libtool --tag=CXX --mode=link g++ -Wall -pipe | | | | -pedantic | | | | -O2 -DNDEBUG -L/opt/cubit/12.2/bin -R/opt/cubit/12.2/bin -o | | | | sheet | | | | sheet.o ../libcgm.la -lm | | | | libtool: link: g++ -Wall -pipe -pedantic -O2 -DNDEBUG -o | | | | .libs/sheet | | | | sheet.o -L/opt/cubit/12.2/bin ../.libs/libcgm.so -lm -Wl,-rpath | | | | -Wl,/home/wilsonp/opt/lib -Wl,-rpath -Wl,/opt/cubit/12.2/bin | | | | /usr/bin/ld: sheet.o: undefined reference to symbol | | | | 'Body::is_sheet_body()' | | | | /usr/bin/ld: note: 'Body::is_sheet_body()' is defined in DSO | | | | /opt/cubit/12.2/bin/libcubiti19.so so try adding it to the | | | | linker | | | | command line | | | | /opt/cubit/12.2/bin/libcubiti19.so: could not read symbols: | | | | Invalid | | | | operation | | | | collect2: ld returned 1 exit status | | | | make[1]: *** [sheet] Error 1 | | | | make[1]: Leaving directory | | | | `/home/wilsonp/UW/research/fathom/cgm/dagmc_bld/test' | | | | make: *** [check-am] Error 2 | | | I've configured with: --enable-optimize --disable-debug | | | --enable-shared --with-cubit=/opt/cubit/12.2 | | | --prefix=/home/wilsonp/opt | | | Should there be a -lcubit19 in the linker flags here? | | | Paul | | | -- | | | -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ | | | ~ | | | -- | | | Paul Wilson ~ UW-Madison ~ 608-263-0807 ~ cal: | | | http://bit.ly/pphw-cal | | | Associate Professor, Engineering Physics. ~ | | | http://cnerg.engr.wisc.edu | | | Chair, Energy Analysis & Policy Program ~ | | | http://nelson.wisc.edu/eap | | Hi Paul | | Try adding cubit to your LPATH as well as your LD_LIBRARY_PATH. | | Stuart | | -- | | Stuart Slattery | | Nuclear Regulatory Commission Fellow | | Computational Nuclear Engineering Research Group | | Department of Engineering Physics | | University of Wisconsin - Madison | | 434 Engineering Research Building | | 1500 Engineering Drive | | Madison, WI 53706 | | email : sslattery(a)wisc.edu cell : 608.843.5871 | | url : http://cnerg.engr.wisc.edu | hello, | This is my patch needed for cgm to pass make check on ubuntu 12 | (shared build) | I didn't try setting LPATH.

1 0

Re: [cgma-dev] Make check errors...
by Iulian Grindeanu 26 Sep '12

26 Sep '12

1 0