June 2014 - cgma-dev - mailman3.cels.anl.gov

commit/CGM: iulian07: add a doxygen file for cgm
by Bitbucket 24 Jun '14

24 Jun '14

1 new commit in CGM: https://bitbucket.org/fathomteam/cgm/commits/e811ebecc606/ Changeset: e811ebecc606 Branch: master User: iulian07 Date: 2014-06-24 08:49:32 Summary: add a doxygen file for cgm Affected #: 2 files Repository URL: https://bitbucket.org/fathomteam/cgm/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

Re: [cgma-dev] Inconsistency in getEntities for iGeom interface. Causes problems in iRel.
by Paul Wilson 23 Jun '14

23 Jun '14

Hi everyone, Patrick and I have discussed this and have come up with the following proposal for a revision of how iGeom_CGMA handles RefVolumes and Body's. 1. All references to iBase_REGION will refer only to entities of type RefVolume in CGM. 2. All entities that are returned by iGeom will be RefEntities and not CubitEntities 3. At the time of loading file, based on an option based to iGeom_load(), all entities of type Body in CGM that contain more than a single volume, will be converted to RefGroup's and tagged to distinguish them from the original RefGroup's The last of these may be subject to the most conversation, but it seemed like a useful approach to use because it: * had little to no effect on the API of iGeom * preserves access to CGM/ACIS bodies * is the least intrusive in the implementation of iGeom_CGMA If a user does NOT pass in the option (e.g. "CONVERT_BODY_TO_GROUP"), then no bodies will be accessible through iGeom. If a user does pass in this option, any call to iGeom_getEntSets will return both the original RefGroups and the additional RefGroups that were generated automatically from Bodies. It will be up to the user to filter between them using the available tag. Finally, since every RefVolume in ACIS always has a Body in which it is a member, it seems best to only convert Bodies that contain >1 RefVolume to avoid creating far more RefGroups than necessary. We'd like to embark on these changes soon, but welcome any comments or feedback. I'm sure we've missed something! Paul On 06/17/2014 09:00 AM, Jane Hu wrote: > So, I will add RefVolume to the return list > of iGeom_get_adjacent_entities() as the result of the discussion. > > CubitEntity only has derived classes of RefEntity > and CubitCoordinateSystem, iGeom_CGMA.cc only uses RefEntity as > instance of the object. > > Jane > > > On Mon, Jun 16, 2014 at 11:35 AM, Jane Hu <janejhu(a)gmail.com > <mailto:[email protected]>> wrote: > > See comments below... > > > On Mon, Jun 16, 2014 at 10:22 AM, Paul Wilson > <wilsonp(a)engr.wisc.edu <mailto:[email protected]>> wrote: > > Hi Jane, > > I think this needs a thorough review! Patrick and I hunted > through iGeom_CGMA and found some inconsistencies in a few places. > > First, there is an inconsistency between returning pointers to > RefEntity and pointers to CubitEntity. This is probably less > important, but should probably be resolved in any change. > > I see RefEntity is inherited from CubitEntity, and CubitEntity is > a pure virtual class. So even you got pointers to CubitEntity, you > have to instantiate it to RefEntity objects. > > > Second, there are places where the geometry is queried for > entities of dimension=3 (returning RefVolumes) and places > where the geometry is queried for entities of > type=iGeom_REGION (== Body). > > > In this case, I can return both bodies and refvolumes, so after > user gets the refentity list back, he can cast to see if they are > bodies or refvolumes, and choose to keep what ever he needs. > > > This means that 2 calls into the interface that should resolve > to the same entity may not do so for both reasons. > > All of this is related to the fundamental difference between > the iGeom types (equivalent to vertex, edge, face, volume) and > the CGM/ACIS types (equiavlent to vertex, edge, face, volume, > body). I think Tim's suggestion is the best, but will require > some substantial effort. > > Paul > > > On 06/16/2014 10:14 AM, Jane Hu wrote: >> I see in iGeom_CGMA.cc file, >> function iGeom_get_adjacent_entities, if asks for 3-D >> refentities, it returns body list. In CGM, bodies are not >> necessary to be 3-D entities, it may contain single surface >> or shell. Should we change the return to be only refvolumes >> which are 3-D entities (I prefer this, makes more sense)? Or >> I can return both bodies and refvolumes in the returned >> refentity list. Depending on your user case, I can return one >> of the two choices. >> >> Jane >> >> >> On Mon, Jun 16, 2014 at 9:32 AM, Jane Hu <janejhu(a)gmail.com >> <mailto:[email protected]>> wrote: >> >> Yes, it returns a list of refVolume's which are RefEntities. >> >> Jane >> >> >> On Sun, Jun 15, 2014 at 11:55 PM, Patrick Shriwise >> <shriwise(a)wisc.edu <mailto:[email protected]>> wrote: >> >> Hi Jane, >> >> Will the ref_volumes() method return RefEntities? >> >> Patrick >> >> On Jun 15, 2014, at 3:56 PM, Jane Hu >> <janejhu(a)gmail.com <mailto:[email protected]>> wrote: >> >>> Look at line 6454, if you have body's pointer, >>> directly call ref_volumes() will work. It's not an >>> iGeom interface function, but you can access it in >>> iGeom. >>> >>> Good luck! >>> >>> Jane >>> >>> >>> On Sat, Jun 14, 2014 at 8:55 AM, Patrick Shriwise >>> <shriwise(a)wisc.edu <mailto:[email protected]>> wrote: >>> >>> Hi Jane, >>> >>> I looked around for this but didn't see it, is >>> there a specific line/function you were thinking >>> of? Good to know the ref_volume information is >>> so easy to get to, but it doesn't seem that its >>> part of the iGeom interface. The issue being >>> that there's no way to access a body's volumes >>> via iGeom. >>> >>> Cheers, >>> >>> Patrick >>> On 06/13/2014 11:26 PM, Jane Hu wrote: >>>> >>>> >>>> >>>> >>>> Is there a way to get volumes within >>>> bodies via iGeom? >>>> >>>> >>>> See example in iGeom_CGMA.cc, >>>> body->ref_volumes(volumes). >>>> >>>> Jane >>>> >>>> >>>> -- >>>> Patrick C. Shriwise >>>> Research Assistant >>>> University of Wisconsin - Madison >>>> Engineering Research Building - Rm. 428 >>>> 1500 Engineering Drive >>>> Madison, WI 53706 >>>> (608) 446-8173 <tel:%28608%29%20446-8173> >>>> >>>> >>>> >>>> >>>> -- >>>> Jane Hu >>>> >>>> Asst. Researcher >>>> Dept. of Engineering Physics >>>> UW @ Madison >>>> >>>> "And we know that for those who love God, that >>>> is, for those who are called according to his >>>> purpose, all things are working together for >>>> good." (Romans 8:28) >>> >>> >>> >>> >>> -- >>> Jane Hu >>> >>> Asst. Researcher >>> Dept. of Engineering Physics >>> UW @ Madison >>> >>> "And we know that for those who love God, that is, >>> for those who are called according to his purpose, >>> all things are working together for good." (Romans >>> 8:28) >> >> >> >> >> -- >> Jane Hu >> >> Asst. Researcher >> Dept. of Engineering Physics >> UW @ Madison >> >> "And we know that for those who love God, that is, for >> those who are called according to his purpose, all things >> are working together for good." (Romans 8:28) >> >> >> >> >> -- >> Jane Hu >> >> Asst. Researcher >> Dept. of Engineering Physics >> UW @ Madison >> >> "And we know that for those who love God, that is, for those >> who are called according to his purpose, all things are >> working together for good." (Romans 8:28) > > -- > -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ -- > Paul Wilson ~ UW-Madison ~608-263-0807 <tel:608-263-0807> ~ cal:http://bit.ly/pphw-cal > Professor, Engineering Physics. ~http://cnerg.engr.wisc.edu > Faculty Director, Advanced Computing Infrastructure > > > > > -- > Jane Hu > > Asst. Researcher > Dept. of Engineering Physics > UW @ Madison > > "And we know that for those who love God, that is, for those who > are called according to his purpose, all things are working > together for good." (Romans 8:28) > > > > > -- > Jane Hu > > Asst. Researcher > Dept. of Engineering Physics > UW @ Madison > > "And we know that for those who love God, that is, for those who are > called according to his purpose, all things are working together for > good." (Romans 8:28) -- -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ -- Paul Wilson ~ UW-Madison ~ 608-263-0807 ~ cal: http://bit.ly/pphw-cal Professor, Engineering Physics. ~ http://cnerg.engr.wisc.edu Faculty Director, Advanced Computing Infrastructure

1 0

commit/CGM: danwu: Added -fstack-protector-all option to CGM gcc debug build, to detect possible stack smashing bugs.
by Bitbucket 23 Jun '14

23 Jun '14

1 new commit in CGM: https://bitbucket.org/fathomteam/cgm/commits/3cd54f57f4eb/ Changeset: 3cd54f57f4eb Branch: master User: danwu Date: 2014-06-23 20:41:40 Summary: Added -fstack-protector-all option to CGM gcc debug build, to detect possible stack smashing bugs. Affected #: 1 file Repository URL: https://bitbucket.org/fathomteam/cgm/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

commit/CGM: iulian07: disable on master branch the tests that fail on occ builds
by Bitbucket 22 Jun '14

22 Jun '14

1 new commit in CGM: https://bitbucket.org/fathomteam/cgm/commits/ac698bccc106/ Changeset: ac698bccc106 Branch: master User: iulian07 Date: 2014-06-23 06:37:59 Summary: disable on master branch the tests that fail on occ builds this is to let buildbot do its course (there are dependent builds on cgm master + occ) Affected #: 1 file Repository URL: https://bitbucket.org/fathomteam/cgm/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

commit/CGM: rajeeja: Fix stack smashing issue found on intel builds while loading using function: iGeom_load_cub_geometry
by Bitbucket 20 Jun '14

20 Jun '14

1 new commit in CGM: https://bitbucket.org/fathomteam/cgm/commits/6bfba6be9f4d/ Changeset: 6bfba6be9f4d Branch: master User: rajeeja Date: 2014-06-21 06:13:27 Summary: Fix stack smashing issue found on intel builds while loading using function: iGeom_load_cub_geometry Affected #: 1 file Repository URL: https://bitbucket.org/fathomteam/cgm/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

commit/CGM: Jane Hu: Reverse changes to the ref_volume part, need to take care of other consistancy issues first.
by Bitbucket 17 Jun '14

17 Jun '14

1 new commit in CGM: https://bitbucket.org/fathomteam/cgm/commits/20fe457fc049/ Changeset: 20fe457fc049 Branch: cgm13.1 User: Jane Hu Date: 2014-06-18 00:07:03 Summary: Reverse changes to the ref_volume part, need to take care of other consistancy issues first. Affected #: 1 file Repository URL: https://bitbucket.org/fathomteam/cgm/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

commit/CGM: Jane Hu: Reverse changes to the ref_volume part, need to take care of other consistancy issues first.
by Bitbucket 17 Jun '14

17 Jun '14

1 new commit in CGM: https://bitbucket.org/fathomteam/cgm/commits/dffbffe9eb9e/ Changeset: dffbffe9eb9e Branch: trunk User: Jane Hu Date: 2014-06-18 00:03:34 Summary: Reverse changes to the ref_volume part, need to take care of other consistancy issues first. Affected #: 1 file Repository URL: https://bitbucket.org/fathomteam/cgm/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

Re: [cgma-dev] commit/CGM: Jane Hu: Removed duplicate declaration for iGeom_get_adjacent_entities; Added RefVolume to the list for getting dimension 3 or region info for any RefEntity, per Paul's request. Didn't affect make or make check.
by janejhu＠gmail.com 17 Jun '14

17 Jun '14

Agreed. I'll check on other locations to adjust this behaviour change. Jane Sent from my Virgin Mobile Android-Powered Device ----- Reply message ----- From: "Tim Tautges" <timothy.tautges(a)cd-adapco.com> To: "Jane Hu" <janejhu(a)gmail.com> Cc: "CGMA Development" <cgma-dev(a)mcs.anl.gov> Subject: [cgma-dev] commit/CGM: Jane Hu: Removed duplicate declaration for iGeom_get_adjacent_entities; Added RefVolume to the list for getting dimension 3 or region info for any RefEntity, per Paul's request. Didn't affect make or make check. Date: Tue, Jun 17, 2014 12:59 pm Well, if that's the case, why didn't any other code change in this file? With this change, I expect some of the behavior that uses this function will change, and these changes will be visible to outside apps. So you've changed behavior to some other arbitrary state, apparently to satisfy one application. I don't think that's justified. - tim On 06/17/2014 11:40 AM, Jane Hu wrote: > This is to provide an interface to access ref-volumes in iGeom, it's not supposed to solve the inconsistency issue which > Paul agreed that your suggestions will be the best solution. As Paul mentioned, it should be a through discussion about it. > > Jane > > > On Tue, Jun 17, 2014 at 11:01 AM, Tim Tautges <timothy.tautges(a)cd-adapco.com <mailto:[email protected]>> wrote: > > Wait a minute - how is this solving the general problem? This looks like a hack to get one application working as > that app desires, with no improvement in consistency. What's the reasoning for this change? > > - tim > > > On 06/17/2014 10:30 AM, Bitbucket wrote: > > 1 new commit in CGM: > > https://bitbucket.org/__fathomteam/cgm/commits/__73512689d31c/ > <https://bitbucket.org/fathomteam/cgm/commits/73512689d31c/> > Changeset: 73512689d31c > Branch: trunk > User: Jane Hu > Date: 2014-06-17 17:30:00 > Summary: Removed duplicate declaration for iGeom_get_adjacent_entities; Added RefVolume to the list for > getting dimension 3 or region info for any RefEntity, per Paul's request. Didn't affect make or make check. > > Affected #: 1 file > > Repository URL: https://bitbucket.org/__fathomteam/cgm/ <https://bitbucket.org/fathomteam/cgm/> > > -- > > This is a commit notification from bitbucket.org <http://bitbucket.org>. You are receiving > this because you have the service enabled, addressing the recipient of > this email. > > > -- > Timothy J. Tautges > Manager, Directed Meshing, CD-adapco > Phone: 608-354-1459 <tel:608-354-1459> > timothy.tautges(a)cd-adapco.com <mailto:[email protected]> > > > > > -- > Jane Hu > > Asst. Researcher > Dept. of Engineering Physics > UW @ Madison > > "And we know that for those who love God, that is, for those who are called according to his purpose, all things are > working together for good." (Romans 8:28) -- Timothy J. Tautges Manager, Directed Meshing, CD-adapco Phone: 608-354-1459 timothy.tautges(a)cd-adapco.com

1 0

Re: [cgma-dev] commit/CGM: Jane Hu: Removed duplicate declaration for iGeom_get_adjacent_entities; Added RefVolume to the list for getting dimension 3 or region info for any RefEntity, per Paul's request. Didn't affect make or make check.
by Tim Tautges 17 Jun '14

17 Jun '14

Well, if that's the case, why didn't any other code change in this file? With this change, I expect some of the behavior that uses this function will change, and these changes will be visible to outside apps. So you've changed behavior to some other arbitrary state, apparently to satisfy one application. I don't think that's justified. - tim On 06/17/2014 11:40 AM, Jane Hu wrote: > This is to provide an interface to access ref-volumes in iGeom, it's not supposed to solve the inconsistency issue which > Paul agreed that your suggestions will be the best solution. As Paul mentioned, it should be a through discussion about it. > > Jane > > > On Tue, Jun 17, 2014 at 11:01 AM, Tim Tautges <timothy.tautges(a)cd-adapco.com <mailto:[email protected]>> wrote: > > Wait a minute - how is this solving the general problem? This looks like a hack to get one application working as > that app desires, with no improvement in consistency. What's the reasoning for this change? > > - tim > > > On 06/17/2014 10:30 AM, Bitbucket wrote: > > 1 new commit in CGM: > > https://bitbucket.org/__fathomteam/cgm/commits/__73512689d31c/ > <https://bitbucket.org/fathomteam/cgm/commits/73512689d31c/> > Changeset: 73512689d31c > Branch: trunk > User: Jane Hu > Date: 2014-06-17 17:30:00 > Summary: Removed duplicate declaration for iGeom_get_adjacent_entities; Added RefVolume to the list for > getting dimension 3 or region info for any RefEntity, per Paul's request. Didn't affect make or make check. > > Affected #: 1 file > > Repository URL: https://bitbucket.org/__fathomteam/cgm/ <https://bitbucket.org/fathomteam/cgm/> > > -- > > This is a commit notification from bitbucket.org <http://bitbucket.org>. You are receiving > this because you have the service enabled, addressing the recipient of > this email. > > > -- > Timothy J. Tautges > Manager, Directed Meshing, CD-adapco > Phone: 608-354-1459 <tel:608-354-1459> > timothy.tautges(a)cd-adapco.com <mailto:[email protected]> > > > > > -- > Jane Hu > > Asst. Researcher > Dept. of Engineering Physics > UW @ Madison > > "And we know that for those who love God, that is, for those who are called according to his purpose, all things are > working together for good." (Romans 8:28) -- Timothy J. Tautges Manager, Directed Meshing, CD-adapco Phone: 608-354-1459 timothy.tautges(a)cd-adapco.com

1 0

Re: [cgma-dev] commit/CGM: Jane Hu: Removed duplicate declaration for iGeom_get_adjacent_entities; Added RefVolume to the list for getting dimension 3 or region info for any RefEntity, per Paul's request. Didn't affect make or make check.
by Jane Hu 17 Jun '14

17 Jun '14

This is to provide an interface to access ref-volumes in iGeom, it's not supposed to solve the inconsistency issue which Paul agreed that your suggestions will be the best solution. As Paul mentioned, it should be a through discussion about it. Jane On Tue, Jun 17, 2014 at 11:01 AM, Tim Tautges <timothy.tautges(a)cd-adapco.com > wrote: > Wait a minute - how is this solving the general problem? This looks like > a hack to get one application working as that app desires, with no > improvement in consistency. What's the reasoning for this change? > > - tim > > > On 06/17/2014 10:30 AM, Bitbucket wrote: > >> 1 new commit in CGM: >> >> https://bitbucket.org/fathomteam/cgm/commits/73512689d31c/ >> Changeset: 73512689d31c >> Branch: trunk >> User: Jane Hu >> Date: 2014-06-17 17:30:00 >> Summary: Removed duplicate declaration for >> iGeom_get_adjacent_entities; Added RefVolume to the list for getting >> dimension 3 or region info for any RefEntity, per Paul's request. Didn't >> affect make or make check. >> >> Affected #: 1 file >> >> Repository URL: https://bitbucket.org/fathomteam/cgm/ >> >> -- >> >> This is a commit notification from bitbucket.org. You are receiving >> this because you have the service enabled, addressing the recipient of >> this email. >> >> > -- > Timothy J. Tautges > Manager, Directed Meshing, CD-adapco > Phone: 608-354-1459 > timothy.tautges(a)cd-adapco.com > -- Jane Hu Asst. Researcher Dept. of Engineering Physics UW @ Madison "And we know that for those who love God, that is, for those who are called according to his purpose, all things are working together for good." (Romans 8:28)

1 0