June 2011 - cgma-dev - mailman3.cels.anl.gov

r4981 - cgm/trunk/itaps
by hongjun＠mcs.anl.gov 09 Jun '11

09 Jun '11

Author: hongjun Date: 2011-06-09 12:02:02 -0500 (Thu, 09 Jun 2011) New Revision: 4981 Modified: cgm/trunk/itaps/testgeom.cc Log: o faceting_test is excluded for OCC geometry Modified: cgm/trunk/itaps/testgeom.cc =================================================================== --- cgm/trunk/itaps/testgeom.cc 2011-06-09 16:51:52 UTC (rev 4980) +++ cgm/trunk/itaps/testgeom.cc 2011-06-09 17:02:02 UTC (rev 4981) @@ -260,7 +260,6 @@ number_tests_successful); number_tests++; std::cout << "\n"; -#endif // facet tests std::cout << " faceting: "; @@ -270,6 +269,7 @@ number_tests_successful); number_tests++; std::cout << "\n"; +#endif // shutdown test std::cout << " shutdown: ";

1 0

Re: [cgma-dev] CGM/itaps/testgeom_occ
by Jane Hu 09 Jun '11

09 Jun '11

Ok, I didn't update the testcase, now it did fail, and your change looks proper. please go ahead to add it . Thanks. Jane On Thu, Jun 9, 2011 at 10:52 AM, Hong-Jun Kim <hongjun(a)mcs.anl.gov> wrote: > By the way, I am curious why you don't fail the test. > Inside "faceting_test", when "size.sat" is imported to OCC geometry kernel, > it looks it must fail. > Am I wrong? > > Hong-Jun > > ----- Original Message ----- > From: "Hong-Jun Kim" <hongjun(a)mcs.anl.gov> > To: "Jane Hu" <janejhu(a)gmail.com> > Cc: cgma-dev(a)mcs.anl.gov > Sent: Thursday, June 9, 2011 10:45:47 AM > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > > Thanks for your reply. > > The test fails in "faceting_test". > I think "faceting_test" also has to be inside "#if defined(HAVE_ACIS) && > !defined(FORCE_OCC)" block as you mentioned, because it is loading > "size.sat" by itself again. > If it is ok for you all, I will change it. > > Hong-Jun > > > ----- Original Message ----- > > From: "Jane Hu" <janejhu(a)gmail.com> > > To: "Hong-Jun Kim" <hongjun(a)mcs.anl.gov> > > Cc: cgma-dev(a)mcs.anl.gov > > Sent: Thursday, June 9, 2011 9:47:12 AM > > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > > Hi, Hong-Jun: > > > > testgeom is using LeverArm.brep for OCC part of testing, and it passed > > in my machine for make check. Only with HAVE_ACIS and without > > FORCE_OCC defined will mesh_size_test test be performed. So it is Acis > > specific. > > > > Jane > > > > > > On Wed, Jun 8, 2011 at 1:25 PM, Hong-Jun Kim < hongjun(a)mcs.anl.gov > > > wrote: > > > > > > Hi > > > > Currently, "CGM/itaps/testgeom_occ" fails for OCC geometry because > > its' input file is "size.sat" for "faceting_test". > > To fix this, can I ask if the test is specific to the input file, > > "size.sat"? > > > > Hong-Jun >

1 0

Re: [cgma-dev] CGM/itaps/testgeom_occ
by Hong-Jun Kim 09 Jun '11

09 Jun '11

I mean "faceting_test" in "testgeom.cc". Hong-Jun ----- Original Message ----- > From: "Jane Hu" <janejhu(a)gmail.com> > To: "Hong-Jun Kim" <hongjun(a)mcs.anl.gov> > Cc: cgma-dev(a)mcs.anl.gov > Sent: Thursday, June 9, 2011 11:48:26 AM > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > I don't have faceting_test in itaps directory, and make check passed > cgm/cgm_apps/examples/facetdriver facets test too. > > Jane > > > On Thu, Jun 9, 2011 at 10:52 AM, Hong-Jun Kim < hongjun(a)mcs.anl.gov > > wrote: > > > By the way, I am curious why you don't fail the test. > Inside "faceting_test", when "size.sat" is imported to OCC geometry > kernel, it looks it must fail. > Am I wrong? > > Hong-Jun > > > ----- Original Message ----- > From: "Hong-Jun Kim" < hongjun(a)mcs.anl.gov > > To: "Jane Hu" < janejhu(a)gmail.com > > Cc: cgma-dev(a)mcs.anl.gov > > > > Sent: Thursday, June 9, 2011 10:45:47 AM > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > > Thanks for your reply. > > The test fails in "faceting_test". > I think "faceting_test" also has to be inside "#if defined(HAVE_ACIS) > && !defined(FORCE_OCC)" block as you mentioned, because it is loading > "size.sat" by itself again. > If it is ok for you all, I will change it. > > Hong-Jun > > > ----- Original Message ----- > > From: "Jane Hu" < janejhu(a)gmail.com > > > To: "Hong-Jun Kim" < hongjun(a)mcs.anl.gov > > > Cc: cgma-dev(a)mcs.anl.gov > > Sent: Thursday, June 9, 2011 9:47:12 AM > > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > > Hi, Hong-Jun: > > > > testgeom is using LeverArm.brep for OCC part of testing, and it > > passed > > in my machine for make check. Only with HAVE_ACIS and without > > FORCE_OCC defined will mesh_size_test test be performed. So it is > > Acis > > specific. > > > > Jane > > > > > > On Wed, Jun 8, 2011 at 1:25 PM, Hong-Jun Kim < hongjun(a)mcs.anl.gov > > > wrote: > > > > > > Hi > > > > Currently, "CGM/itaps/testgeom_occ" fails for OCC geometry because > > its' input file is "size.sat" for "faceting_test". > > To fix this, can I ask if the test is specific to the input file, > > "size.sat"? > > > > Hong-Jun

1 0

Re: [cgma-dev] CGM/itaps/testgeom_occ
by Paul Wilson 09 Jun '11

09 Jun '11

Hello Hong-Jun, Jane, I added the faceting_test method to the testgeom program and it should have had the #ifdef blocks. Sorry. Paul On 06/09/2011 08:48 PM, Jane Hu wrote: > I don't have faceting_test in itaps directory, and make check passed > cgm/cgm_apps/examples/facetdriver facets test too. > > Jane > > On Thu, Jun 9, 2011 at 10:52 AM, Hong-Jun Kim <hongjun(a)mcs.anl.gov > <mailto:[email protected]>> wrote: > > By the way, I am curious why you don't fail the test. > Inside "faceting_test", when "size.sat" is imported to OCC > geometry kernel, it looks it must fail. > Am I wrong? > > Hong-Jun > > ----- Original Message ----- > From: "Hong-Jun Kim" <hongjun(a)mcs.anl.gov > <mailto:[email protected]>> > To: "Jane Hu" <janejhu(a)gmail.com <mailto:[email protected]>> > Cc: cgma-dev(a)mcs.anl.gov <mailto:[email protected]> > Sent: Thursday, June 9, 2011 10:45:47 AM > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > > Thanks for your reply. > > The test fails in "faceting_test". > I think "faceting_test" also has to be inside "#if > defined(HAVE_ACIS) && !defined(FORCE_OCC)" block as you mentioned, > because it is loading "size.sat" by itself again. > If it is ok for you all, I will change it. > > Hong-Jun > > > ----- Original Message ----- > > From: "Jane Hu" <janejhu(a)gmail.com <mailto:[email protected]>> > > To: "Hong-Jun Kim" <hongjun(a)mcs.anl.gov > <mailto:[email protected]>> > > Cc: cgma-dev(a)mcs.anl.gov <mailto:[email protected]> > > Sent: Thursday, June 9, 2011 9:47:12 AM > > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > > Hi, Hong-Jun: > > > > testgeom is using LeverArm.brep for OCC part of testing, and it > passed > > in my machine for make check. Only with HAVE_ACIS and without > > FORCE_OCC defined will mesh_size_test test be performed. So it > is Acis > > specific. > > > > Jane > > > > > > On Wed, Jun 8, 2011 at 1:25 PM, Hong-Jun Kim < > hongjun(a)mcs.anl.gov <mailto:[email protected]> > > > wrote: > > > > > > Hi > > > > Currently, "CGM/itaps/testgeom_occ" fails for OCC geometry because > > its' input file is "size.sat" for "faceting_test". > > To fix this, can I ask if the test is specific to the input file, > > "size.sat"? > > > > Hong-Jun > > -- -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ -- Paul Wilson ~ UW-Madison ~ 608-263-0807 ~ cal: http://bit.ly/pphw-cal Associate Professor, Engineering Physics. ~ http://cnerg.engr.wisc.edu Chair, Energy Analysis& Policy Program ~ http://nelson.wisc.edu/eap Note: I will be on sabbatical for the 2010-2011 academic year.

1 0

Re: [cgma-dev] CGM/itaps/testgeom_occ
by Jane Hu 09 Jun '11

09 Jun '11

I don't have faceting_test in itaps directory, and make check passed cgm/cgm_apps/examples/facetdriver facets test too. Jane On Thu, Jun 9, 2011 at 10:52 AM, Hong-Jun Kim <hongjun(a)mcs.anl.gov> wrote: > By the way, I am curious why you don't fail the test. > Inside "faceting_test", when "size.sat" is imported to OCC geometry kernel, > it looks it must fail. > Am I wrong? > > Hong-Jun > > ----- Original Message ----- > From: "Hong-Jun Kim" <hongjun(a)mcs.anl.gov> > To: "Jane Hu" <janejhu(a)gmail.com> > Cc: cgma-dev(a)mcs.anl.gov > Sent: Thursday, June 9, 2011 10:45:47 AM > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > > Thanks for your reply. > > The test fails in "faceting_test". > I think "faceting_test" also has to be inside "#if defined(HAVE_ACIS) && > !defined(FORCE_OCC)" block as you mentioned, because it is loading > "size.sat" by itself again. > If it is ok for you all, I will change it. > > Hong-Jun > > > ----- Original Message ----- > > From: "Jane Hu" <janejhu(a)gmail.com> > > To: "Hong-Jun Kim" <hongjun(a)mcs.anl.gov> > > Cc: cgma-dev(a)mcs.anl.gov > > Sent: Thursday, June 9, 2011 9:47:12 AM > > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > > Hi, Hong-Jun: > > > > testgeom is using LeverArm.brep for OCC part of testing, and it passed > > in my machine for make check. Only with HAVE_ACIS and without > > FORCE_OCC defined will mesh_size_test test be performed. So it is Acis > > specific. > > > > Jane > > > > > > On Wed, Jun 8, 2011 at 1:25 PM, Hong-Jun Kim < hongjun(a)mcs.anl.gov > > > wrote: > > > > > > Hi > > > > Currently, "CGM/itaps/testgeom_occ" fails for OCC geometry because > > its' input file is "size.sat" for "faceting_test". > > To fix this, can I ask if the test is specific to the input file, > > "size.sat"? > > > > Hong-Jun >

1 0

Re: [cgma-dev] CGM/itaps/testgeom_occ
by Hong-Jun Kim 09 Jun '11

09 Jun '11

By the way, I am curious why you don't fail the test. Inside "faceting_test", when "size.sat" is imported to OCC geometry kernel, it looks it must fail. Am I wrong? Hong-Jun ----- Original Message ----- From: "Hong-Jun Kim" <hongjun(a)mcs.anl.gov> To: "Jane Hu" <janejhu(a)gmail.com> Cc: cgma-dev(a)mcs.anl.gov Sent: Thursday, June 9, 2011 10:45:47 AM Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ Thanks for your reply. The test fails in "faceting_test". I think "faceting_test" also has to be inside "#if defined(HAVE_ACIS) && !defined(FORCE_OCC)" block as you mentioned, because it is loading "size.sat" by itself again. If it is ok for you all, I will change it. Hong-Jun ----- Original Message ----- > From: "Jane Hu" <janejhu(a)gmail.com> > To: "Hong-Jun Kim" <hongjun(a)mcs.anl.gov> > Cc: cgma-dev(a)mcs.anl.gov > Sent: Thursday, June 9, 2011 9:47:12 AM > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > Hi, Hong-Jun: > > testgeom is using LeverArm.brep for OCC part of testing, and it passed > in my machine for make check. Only with HAVE_ACIS and without > FORCE_OCC defined will mesh_size_test test be performed. So it is Acis > specific. > > Jane > > > On Wed, Jun 8, 2011 at 1:25 PM, Hong-Jun Kim < hongjun(a)mcs.anl.gov > > wrote: > > > Hi > > Currently, "CGM/itaps/testgeom_occ" fails for OCC geometry because > its' input file is "size.sat" for "faceting_test". > To fix this, can I ask if the test is specific to the input file, > "size.sat"? > > Hong-Jun

1 0

Re: [cgma-dev] CGM/itaps/testgeom_occ
by Hong-Jun Kim 09 Jun '11

09 Jun '11

Thanks for your reply. The test fails in "faceting_test". I think "faceting_test" also has to be inside "#if defined(HAVE_ACIS) && !defined(FORCE_OCC)" block as you mentioned, because it is loading "size.sat" by itself again. If it is ok for you all, I will change it. Hong-Jun ----- Original Message ----- > From: "Jane Hu" <janejhu(a)gmail.com> > To: "Hong-Jun Kim" <hongjun(a)mcs.anl.gov> > Cc: cgma-dev(a)mcs.anl.gov > Sent: Thursday, June 9, 2011 9:47:12 AM > Subject: Re: [cgma-dev] CGM/itaps/testgeom_occ > Hi, Hong-Jun: > > testgeom is using LeverArm.brep for OCC part of testing, and it passed > in my machine for make check. Only with HAVE_ACIS and without > FORCE_OCC defined will mesh_size_test test be performed. So it is Acis > specific. > > Jane > > > On Wed, Jun 8, 2011 at 1:25 PM, Hong-Jun Kim < hongjun(a)mcs.anl.gov > > wrote: > > > Hi > > Currently, "CGM/itaps/testgeom_occ" fails for OCC geometry because > its' input file is "size.sat" for "faceting_test". > To fix this, can I ask if the test is specific to the input file, > "size.sat"? > > Hong-Jun

1 0

Re: [cgma-dev] CGM/itaps/testgeom_occ
by Jane Hu 09 Jun '11

09 Jun '11

Hi, Hong-Jun: testgeom is using LeverArm.brep for OCC part of testing, and it passed in my machine for make check. Only with HAVE_ACIS and without FORCE_OCC defined will mesh_size_test test be performed. So it is Acis specific. Jane On Wed, Jun 8, 2011 at 1:25 PM, Hong-Jun Kim <hongjun(a)mcs.anl.gov> wrote: > Hi > > Currently, "CGM/itaps/testgeom_occ" fails for OCC geometry because its' > input file is "size.sat" for "faceting_test". > To fix this, can I ask if the test is specific to the input file, > "size.sat"? > > Hong-Jun >

1 0

CGM/itaps/testgeom_occ
by Hong-Jun Kim 08 Jun '11

08 Jun '11

Hi Currently, "CGM/itaps/testgeom_occ" fails for OCC geometry because its' input file is "size.sat" for "faceting_test". To fix this, can I ask if the test is specific to the input file, "size.sat"? Hong-Jun

1 0

r4972 - cgm/trunk/geom/OCC
by jiangtao_ma＠yahoo.com 08 Jun '11

08 Jun '11

Author: janehu Date: 2011-06-08 13:10:31 -0500 (Wed, 08 Jun 2011) New Revision: 4972 Modified: cgm/trunk/geom/OCC/OCCPoint.cpp cgm/trunk/geom/OCC/OCCPoint.hpp cgm/trunk/geom/OCC/OCCQueryEngine.cpp Log: Store point's parent instead of searching for it each time, saves upto 43% of time on mcnp2cad/hexlat2 case. Passed make check. Modified: cgm/trunk/geom/OCC/OCCPoint.cpp =================================================================== --- cgm/trunk/geom/OCC/OCCPoint.cpp 2011-06-08 17:56:28 UTC (rev 4971) +++ cgm/trunk/geom/OCC/OCCPoint.cpp 2011-06-08 18:10:31 UTC (rev 4972) @@ -89,6 +89,18 @@ } } +void OCCPoint::add_curve(OCCCurve* curve) +{ + assert(curve != NULL); + myCurveList.append_unique(curve); +} + +void OCCPoint::remove_curve(OCCCurve* curve) +{ + assert(curve != NULL); + myCurveList.remove(curve); +} + void OCCPoint::set_TopoDS_Vertex(TopoDS_Vertex vertex) { if(vertex.IsEqual(*myTopoDSVertex)) @@ -231,31 +243,7 @@ void OCCPoint::get_parents_virt( DLIList<TopologyBridge*>& parents ) { - OCCQueryEngine* oqe = (OCCQueryEngine*) get_geometry_query_engine(); - OCCCurve * curve = NULL; - DLIList <OCCCurve* > *curves = oqe->CurveList; - TopTools_IndexedDataMapOfShapeListOfShape M; - for(int i = 0; i < curves->size(); i++) - { - curve = curves->get_and_step(); - TopExp::MapShapesAndAncestors(*(curve->get_TopoDS_Edge()), - TopAbs_VERTEX, TopAbs_EDGE, M); - if (!M.Contains(*(get_TopoDS_Vertex()))) - continue; - - const TopTools_ListOfShape& ListOfShapes = - M.FindFromKey(*(get_TopoDS_Vertex())); - if (!ListOfShapes.IsEmpty()) - { - TopTools_ListIteratorOfListOfShape it(ListOfShapes) ; - for (;it.More(); it.Next()) - { - TopoDS_Edge Edge = TopoDS::Edge(it.Value()); - int k = oqe->OCCMap->Find(Edge); - parents.append_unique((OCCPoint*)(oqe->OccToCGM->find(k))->second); - } - }

1 0