January 2012 - cgma-dev - mailman3.cels.anl.gov

Re: [cgma-dev] Create spline curve bug
by Jane Hu 12 Jan '12

12 Jan '12

Ok, I got your point, I double checked Acis, and found it gives all three points in the list. Now I've updated the OCC code to reflect it. Thanks, Boyd. Jane > On Tue, Jan 10, 2012 at 11:08 AM, <boyd(a)elemtech.com> wrote: > >> Howdy Jane, >> >> I double checked the code. "Curve* OCCModifyEngine::make_Curve" gets >> called from GeometryModifyTool::MakeRefEdge with paramaters of the begin >> and end points and a cubit_vector containing all three points (in the order >> first point, mid-point, end point). The values passed in are the same as >> when the ACIS engine is being used. It is in OCCModifyEngine::make_Curve >> that the list of 5 points is built then used in an attempt to make the >> curve. I don't have a good grasp of how the code should work and am unable >> to debug it at this point due to the following: >> >> It has been decided that current state of the CGM/OCC code is good >> enough to give a copy to our customer who is interested in a open source >> geometry engine so I have been given a new assignment. Corey McBride has >> been assigned to work future issues and will be working with you on the >> known problems. The good news is that he has a better grasp of the code >> and will be able to do a very good job of testing/debugging. >> >> Thanks very much for all your help with the OCC code. >> >> Take Care, >> >> -Boyd >> >> >> ----- Original Message ----- >> From: Jane Hu <janejhu(a)gmail.com> >> To: Boyd Tidwell <bktidwell373(a)gmail.com> >> Cc: cgma-dev(a)mcs.anl.gov >> Sent: Tue, 10 Jan 2012 08:49:57 -0700 (MST) >> Subject: Re: [cgma-dev] Create spline curve bug >> >> Hi, Boyd: >> >> The point list should include only 3 points without duplicates. If you >> called GeometryModifyTool::make_RefEdge(), you need to pass in start and >> end vertex besides the mid-point as the list member. Can you double check >> on this? >> >> Thanks. >> >> jane >> >> On Mon, Jan 9, 2012 at 2:29 PM, Boyd Tidwell <bktidwell373(a)gmail.com> >> wrote: >> >> > Jane, >> > >> > After applying your changes I now get an exception raised. Here is >> > the detail, >> > >> > >> > In OCCModifyEngine.cpp, my line 426 (Curve* OCCModifyEngine::make_Curve) >> > >> > //make curve according to the curve type. >> > if(curve_type == SPLINE_CURVE_TYPE) >> > { >> > GeomAPI_Interpolate spline(points, CUBIT_FALSE, TOL); <-- this call >> > >> > which calls: >> > >> > In GeomAPI_Interpolate.cxx: >> > >> > GeomAPI_Interpolate::GeomAPI_Interpolate >> > (const Handle_TColgp_HArray1OfPnt& PointsPtr, >> > const Standard_Boolean PeriodicFlag, >> > const Standard_Real Tolerance) : >> > myTolerance(Tolerance), >> > myPoints(PointsPtr), >> > myIsDone(Standard_False), >> > myPeriodic(PeriodicFlag), >> > myTangentRequest(Standard_False) >> > { >> > Standard_Integer ii ; >> > Standard_Boolean result = >> > CheckPoints(PointsPtr->Array1(), >> > Tolerance) ; >> > myTangents = >> > new TColgp_HArray1OfVec(myPoints->Lower(), >> > myPoints->Upper()) ; >> > myTangentFlags = >> > new TColStd_HArray1OfBoolean(myPoints->Lower(), >> > myPoints->Upper()) ; >> > >> > if (!result) { >> > Standard_ConstructionError::Raise(); <----- hits here >> > } >> > >> > The "Tolerance" passed in is 9.9999999999999995e-008. >> > The "points" variable contains 5 points: >> > 2 with value 0,0,0 >> > 2 with value 1,0,1 >> > 1 with value 2,0,0 >> > >> > and, of course, "result" is zero. >> > >> > Hope this helps. >> > >> > -Boyd >> > >> > >> > >> > >> > >> > >Hi, Boyd >> > >> > >This has been confirmed and fixed in most recent cgm. Thanks. >> > >> > >Jane >> > >> > On Thu, Dec 22, 2011 at 11:23 AM, Boyd Tidwell <boyd at csimsoft.com> >> > wrote: >> > >> > > Jane, >> > > >> > > The following: >> > > >> > > create vertex 0 0 0 >> > > create vertex 1 0 1 >> > > create vertex 2 0 0 >> > > create curve vertex 1 2 3 spline >> > > >> > > should create a curve that includes all three vertices. It does so in >> > > Cubit with the Acis engine but with OCC, the middle vertex (3) gets >> left >> > > out. I looked a bit into the code with debug but I didn't come close >> to >> > > having an idea what the problem may be. >> > > >> > > Thanks, >> > > >> > > - Boyd >> > > >> > >> >> >

1 0

r5314 - cgm/trunk/test
by jiangtao_ma＠yahoo.com 12 Jan '12

12 Jan '12

Author: janehu Date: 2012-01-12 11:49:38 -0600 (Thu, 12 Jan 2012) New Revision: 5314 Modified: cgm/trunk/test/makept.cpp cgm/trunk/test/modify.cpp Log: Changes made for r5313. Modified: cgm/trunk/test/makept.cpp =================================================================== --- cgm/trunk/test/makept.cpp 2012-01-12 17:49:00 UTC (rev 5313) +++ cgm/trunk/test/makept.cpp 2012-01-12 17:49:38 UTC (rev 5314) @@ -537,10 +537,12 @@ CubitVector center_pnt1(5,8,10); CubitVector center_pnt2(1,2,10); CubitVector center_pnt3(-2,-3.5,10); + list.append(&vector1); list.append(&center_pnt1); list.append(&center_pnt2); list.append(&center_pnt); list.append(&center_pnt3); + list.append(&vector2); RefEdge* new_edge_1 = gmti->make_RefEdge(SPLINE_CURVE_TYPE, vertex1, vertex2, list); d = new_edge_1->measure(); @@ -551,11 +553,6 @@ assert(center_pnt2.distance_between(closest_location) < 1.E-6); //Spline with points and tangents - CubitVector* first_v = new CubitVector(vertex1->coordinates()); - CubitVector* last_v = new CubitVector(vertex2->coordinates()); - list.insert_first(first_v); - list.append(last_v); - DLIList<CubitVector*> tangents; for (int i = 0; i< 6; i++) tangents.append(NULL); Modified: cgm/trunk/test/modify.cpp =================================================================== --- cgm/trunk/test/modify.cpp 2012-01-12 17:49:00 UTC (rev 5313) +++ cgm/trunk/test/modify.cpp 2012-01-12 17:49:38 UTC (rev 5314) @@ -1251,11 +1251,14 @@ CubitVector pt7(0,1,-15); RefVertex* vt5 = gmti->make_RefVertex(pt7); DLIList<CubitVector*> vector_list; + vector_list.append(&pt1); vector_list.append(&pt5); - + vector_list.append(&pt4); RefEdge* edge4 = gmti->make_RefEdge( SPLINE_CURVE_TYPE, vt1, vt4, vector_list); vector_list.clean_out(); + vector_list.append(&pt4); vector_list.append(&pt6); + vector_list.append(&pt7); RefEdge* edge5 = gmti->make_RefEdge( SPLINE_CURVE_TYPE, vt4, vt5, vector_list); edges.clean_out(); edges.append(edge4);

1 0

r5313 - cgm/trunk/geom/OCC
by jiangtao_ma＠yahoo.com 12 Jan '12

12 Jan '12

Author: janehu Date: 2012-01-12 11:49:00 -0600 (Thu, 12 Jan 2012) New Revision: 5313 Modified: cgm/trunk/geom/OCC/OCCModifyEngine.cpp Log: Fixed the spline creation inconsistant with Acis version problem. testcase is on cgm/test/modify.cpp and makept.cpp. Modified: cgm/trunk/geom/OCC/OCCModifyEngine.cpp =================================================================== --- cgm/trunk/geom/OCC/OCCModifyEngine.cpp 2012-01-12 16:01:42 UTC (rev 5312) +++ cgm/trunk/geom/OCC/OCCModifyEngine.cpp 2012-01-12 17:49:00 UTC (rev 5313) @@ -389,29 +389,14 @@ occ_face = CAST_TO(face_ptr, OCCSurface); gp_Pnt pt; - int size = 2+vector_list.size(); + int size = vector_list.size(); Handle(TColgp_HArray1OfPnt) points = new TColgp_HArray1OfPnt(1, size); CubitVector vector; CubitVector closest_location; for(int i = 1; i <= size; i++) { - if (i == 1) - { - TopoDS_Vertex *point = occ_point1->get_TopoDS_Vertex(); - pt = BRep_Tool::Pnt(*point); - vector = point1_ptr->coordinates(); - } - else if (i == size) - { - TopoDS_Vertex *point = occ_point2->get_TopoDS_Vertex(); - pt = BRep_Tool::Pnt(*point); - vector = point2_ptr->coordinates(); - } - else - { - vector = *vector_list.get_and_step(); - pt.SetCoord(vector.x(), vector.y(), vector.z()); - } + vector = *vector_list.get_and_step(); + pt.SetCoord(vector.x(), vector.y(), vector.z()); if (occ_face != NULL) { @@ -419,7 +404,7 @@ pt.SetCoord(closest_location.x(), closest_location.y(), closest_location.z()) ; } - points->SetValue(i, pt); + points->SetValue(i, pt); } //make curve according to the curve type.

1 0

r5312 - cgm/trunk/test
by jiangtao_ma＠yahoo.com 12 Jan '12

12 Jan '12

Author: janehu Date: 2012-01-12 10:01:42 -0600 (Thu, 12 Jan 2012) New Revision: 5312 Modified: cgm/trunk/test/point_project.cpp Log: Trying to fix the nightly run fail problem, it's not crashing on mesh machine, but fails on the build machine which might be due to the tolerance issue. Modified: cgm/trunk/test/point_project.cpp =================================================================== --- cgm/trunk/test/point_project.cpp 2012-01-11 22:34:09 UTC (rev 5311) +++ cgm/trunk/test/point_project.cpp 2012-01-12 16:01:42 UTC (rev 5312) @@ -110,13 +110,13 @@ CubitVector point(1,1,-5); CubitVector on_surf; surf->closest_point_trimmed(point, on_surf); - assert (on_surf.z() == -5); + assert (fabs(on_surf.z() + 5) < 0.0001); assert (on_surf.y() < 1.001 && on_surf.y() > 0.999); assert (on_surf.x() < 2.122 && on_surf.x() > 2.121 ); CubitVector p1(0, 1.5, -6 ); surf->closest_point_trimmed(p1, on_surf); - assert (on_surf.z() == -5); + assert (fabs(on_surf.z() + 5) < 0.0001); assert (on_surf.y() < 2.122 && on_surf.y() > 2.121); assert (on_surf.x() < 0.0001 && on_surf.x() > -0.0001 ); return CUBIT_SUCCESS;

1 0

r5307 - cgm/trunk/itaps
by jvporter＠wisc.edu 11 Jan '12

11 Jan '12

Author: jvporter Date: 2012-01-11 13:30:28 -0600 (Wed, 11 Jan 2012) New Revision: 5307 Modified: cgm/trunk/itaps/iGeom.h Log: Remove C++ comment from C header Modified: cgm/trunk/itaps/iGeom.h =================================================================== --- cgm/trunk/itaps/iGeom.h 2012-01-11 19:28:22 UTC (rev 5306) +++ cgm/trunk/itaps/iGeom.h 2012-01-11 19:30:28 UTC (rev 5307) @@ -3972,7 +3972,7 @@ int *err); #ifdef __cplusplus -} // extern "C" +} /* extern "C" */ #endif #endif

1 0

r5301 - cgm/trunk/geom/OCC
by jiangtao_ma＠yahoo.com 10 Jan '12

10 Jan '12

Author: janehu Date: 2012-01-10 12:30:42 -0600 (Tue, 10 Jan 2012) New Revision: 5301 Modified: cgm/trunk/geom/OCC/OCCModifyEngine.cpp Log: Added copy_attribute call to curve copy function. There's no vertex copy function, this is achieved by create vertex on location, so no copy attribute issue here. Modified: cgm/trunk/geom/OCC/OCCModifyEngine.cpp =================================================================== --- cgm/trunk/geom/OCC/OCCModifyEngine.cpp 2012-01-10 10:21:25 UTC (rev 5300) +++ cgm/trunk/geom/OCC/OCCModifyEngine.cpp 2012-01-10 18:30:42 UTC (rev 5301) @@ -221,6 +221,8 @@ TopoDS_Edge newEdge = TopoDS::Edge(newShape); + OCCQueryEngine::instance()->copy_attributes(*theEdge, newEdge); + return OCCQueryEngine::instance()->populate_topology_bridge(newEdge, true); }

1 0

Re: [cgma-dev] Create spline curve bug
by Jane Hu 10 Jan '12

10 Jan '12

To make it clear: the CubitVector list for the points should only contain mid-point, it's a one point list. Thanks. jane On Tue, Jan 10, 2012 at 9:49 AM, Jane Hu <janejhu(a)gmail.com> wrote: > Hi, Boyd: > > The point list should include only 3 points without duplicates. If you > called GeometryModifyTool::make_RefEdge(), you need to pass in start and > end vertex besides the mid-point as the list member. Can you double check > on this? > > Thanks. > > jane > > > On Mon, Jan 9, 2012 at 2:29 PM, Boyd Tidwell <bktidwell373(a)gmail.com>wrote: > >> Jane, >> >> After applying your changes I now get an exception raised. Here is >> the detail, >> >> >> In OCCModifyEngine.cpp, my line 426 (Curve* OCCModifyEngine::make_Curve) >> >> //make curve according to the curve type. >> if(curve_type == SPLINE_CURVE_TYPE) >> { >> GeomAPI_Interpolate spline(points, CUBIT_FALSE, TOL); <-- this call >> >> which calls: >> >> In GeomAPI_Interpolate.cxx: >> >> GeomAPI_Interpolate::GeomAPI_Interpolate >> (const Handle_TColgp_HArray1OfPnt& PointsPtr, >> const Standard_Boolean PeriodicFlag, >> const Standard_Real Tolerance) : >> myTolerance(Tolerance), >> myPoints(PointsPtr), >> myIsDone(Standard_False), >> myPeriodic(PeriodicFlag), >> myTangentRequest(Standard_False) >> { >> Standard_Integer ii ; >> Standard_Boolean result = >> CheckPoints(PointsPtr->Array1(), >> Tolerance) ; >> myTangents = >> new TColgp_HArray1OfVec(myPoints->Lower(), >> myPoints->Upper()) ; >> myTangentFlags = >> new TColStd_HArray1OfBoolean(myPoints->Lower(), >> myPoints->Upper()) ; >> >> if (!result) { >> Standard_ConstructionError::Raise(); <----- hits here >> } >> >> The "Tolerance" passed in is 9.9999999999999995e-008. >> The "points" variable contains 5 points: >> 2 with value 0,0,0 >> 2 with value 1,0,1 >> 1 with value 2,0,0 >> >> and, of course, "result" is zero. >> >> Hope this helps. >> >> -Boyd >> >> >> >> >> >> >Hi, Boyd >> >> >This has been confirmed and fixed in most recent cgm. Thanks. >> >> >Jane >> >> On Thu, Dec 22, 2011 at 11:23 AM, Boyd Tidwell <boyd at csimsoft.com> >> wrote: >> >> > Jane, >> > >> > The following: >> > >> > create vertex 0 0 0 >> > create vertex 1 0 1 >> > create vertex 2 0 0 >> > create curve vertex 1 2 3 spline >> > >> > should create a curve that includes all three vertices. It does so in >> > Cubit with the Acis engine but with OCC, the middle vertex (3) gets left >> > out. I looked a bit into the code with debug but I didn't come close to >> > having an idea what the problem may be. >> > >> > Thanks, >> > >> > - Boyd >> > >> > >

1 0

Re: [cgma-dev] Create spline curve bug
by Jane Hu 10 Jan '12

10 Jan '12

Hi, Boyd: The point list should include only 3 points without duplicates. If you called GeometryModifyTool::make_RefEdge(), you need to pass in start and end vertex besides the mid-point as the list member. Can you double check on this? Thanks. jane On Mon, Jan 9, 2012 at 2:29 PM, Boyd Tidwell <bktidwell373(a)gmail.com> wrote: > Jane, > > After applying your changes I now get an exception raised. Here is > the detail, > > > In OCCModifyEngine.cpp, my line 426 (Curve* OCCModifyEngine::make_Curve) > > //make curve according to the curve type. > if(curve_type == SPLINE_CURVE_TYPE) > { > GeomAPI_Interpolate spline(points, CUBIT_FALSE, TOL); <-- this call > > which calls: > > In GeomAPI_Interpolate.cxx: > > GeomAPI_Interpolate::GeomAPI_Interpolate > (const Handle_TColgp_HArray1OfPnt& PointsPtr, > const Standard_Boolean PeriodicFlag, > const Standard_Real Tolerance) : > myTolerance(Tolerance), > myPoints(PointsPtr), > myIsDone(Standard_False), > myPeriodic(PeriodicFlag), > myTangentRequest(Standard_False) > { > Standard_Integer ii ; > Standard_Boolean result = > CheckPoints(PointsPtr->Array1(), > Tolerance) ; > myTangents = > new TColgp_HArray1OfVec(myPoints->Lower(), > myPoints->Upper()) ; > myTangentFlags = > new TColStd_HArray1OfBoolean(myPoints->Lower(), > myPoints->Upper()) ; > > if (!result) { > Standard_ConstructionError::Raise(); <----- hits here > } > > The "Tolerance" passed in is 9.9999999999999995e-008. > The "points" variable contains 5 points: > 2 with value 0,0,0 > 2 with value 1,0,1 > 1 with value 2,0,0 > > and, of course, "result" is zero. > > Hope this helps. > > -Boyd > > > > > > >Hi, Boyd > > >This has been confirmed and fixed in most recent cgm. Thanks. > > >Jane > > On Thu, Dec 22, 2011 at 11:23 AM, Boyd Tidwell <boyd at csimsoft.com> > wrote: > > > Jane, > > > > The following: > > > > create vertex 0 0 0 > > create vertex 1 0 1 > > create vertex 2 0 0 > > create curve vertex 1 2 3 spline > > > > should create a curve that includes all three vertices. It does so in > > Cubit with the Acis engine but with OCC, the middle vertex (3) gets left > > out. I looked a bit into the code with debug but I didn't come close to > > having an idea what the problem may be. > > > > Thanks, > > > > - Boyd > > >

1 0

Re: [cgma-dev] Create spline curve bug
by Boyd Tidwell 09 Jan '12

09 Jan '12

Jane, After applying your changes I now get an exception raised. Here is the detail, In OCCModifyEngine.cpp, my line 426 (Curve* OCCModifyEngine::make_Curve) //make curve according to the curve type. if(curve_type == SPLINE_CURVE_TYPE) { GeomAPI_Interpolate spline(points, CUBIT_FALSE, TOL); <-- this call which calls: In GeomAPI_Interpolate.cxx: GeomAPI_Interpolate::GeomAPI_Interpolate (const Handle_TColgp_HArray1OfPnt& PointsPtr, const Standard_Boolean PeriodicFlag, const Standard_Real Tolerance) : myTolerance(Tolerance), myPoints(PointsPtr), myIsDone(Standard_False), myPeriodic(PeriodicFlag), myTangentRequest(Standard_False) { Standard_Integer ii ; Standard_Boolean result = CheckPoints(PointsPtr->Array1(), Tolerance) ; myTangents = new TColgp_HArray1OfVec(myPoints->Lower(), myPoints->Upper()) ; myTangentFlags = new TColStd_HArray1OfBoolean(myPoints->Lower(), myPoints->Upper()) ; if (!result) { Standard_ConstructionError::Raise(); <----- hits here } The "Tolerance" passed in is 9.9999999999999995e-008. The "points" variable contains 5 points: 2 with value 0,0,0 2 with value 1,0,1 1 with value 2,0,0 and, of course, "result" is zero. Hope this helps. -Boyd >Hi, Boyd >This has been confirmed and fixed in most recent cgm. Thanks. >Jane On Thu, Dec 22, 2011 at 11:23 AM, Boyd Tidwell <boyd at csimsoft.com> wrote: > Jane, > > The following: > > create vertex 0 0 0 > create vertex 1 0 1 > create vertex 2 0 0 > create curve vertex 1 2 3 spline > > should create a curve that includes all three vertices. It does so in > Cubit with the Acis engine but with OCC, the middle vertex (3) gets left > out. I looked a bit into the code with debug but I didn't come close to > having an idea what the problem may be. > > Thanks, > > - Boyd >

1 0

Re: [cgma-dev] imprint mesh bug
by Boyd Tidwell 09 Jan '12

09 Jan '12

Jane, After applying fix to my code I still get the assert on the same line. But instead of tmp_list.size() returning zero, it now returns 2. I traced through the get_parents_virt( tmp_list ) call that proceeds the assert and it does indeed find and add 2 bodies to the list. I hope this is enough information to allow you to debug the problem. Hopefully we are getting close. -Boyd

1 0