January 2012 - cgma-dev - mailman3.cels.anl.gov

r5331 - cgm/trunk/geom/virtual
by jiangtao_ma＠yahoo.com 20 Jan '12

20 Jan '12

Author: janehu Date: 2012-01-20 14:42:57 -0600 (Fri, 20 Jan 2012) New Revision: 5331 Modified: cgm/trunk/geom/virtual/VirtualQueryEngine.cpp cgm/trunk/geom/virtual/VirtualQueryEngine.hpp Log: Added unit parameter for import/export functions for iges files in OCC engine cgm. Passed cgm/test make check. Modified: cgm/trunk/geom/virtual/VirtualQueryEngine.cpp =================================================================== --- cgm/trunk/geom/virtual/VirtualQueryEngine.cpp 2012-01-20 20:42:35 UTC (rev 5330) +++ cgm/trunk/geom/virtual/VirtualQueryEngine.cpp 2012-01-20 20:42:57 UTC (rev 5331) @@ -1652,6 +1652,7 @@ const char* , const char* , const CubitString &, + const char*, const char* ) { return CUBIT_FAILURE; @@ -1691,7 +1692,8 @@ CubitBoolean , CubitBoolean , CubitBoolean , - CubitBoolean ) + CubitBoolean , + const char* ) { PRINT_INFO("VirtualQueryEngine::import_solid_model\n"); Modified: cgm/trunk/geom/virtual/VirtualQueryEngine.hpp =================================================================== --- cgm/trunk/geom/virtual/VirtualQueryEngine.hpp 2012-01-20 20:42:35 UTC (rev 5330) +++ cgm/trunk/geom/virtual/VirtualQueryEngine.hpp 2012-01-20 20:42:57 UTC (rev 5331) @@ -357,6 +357,7 @@ const char* file_name, const char* file_type, const CubitString &cubit_version, + const char* unit = NULL, const char* logfile_name = NULL ); virtual CubitStatus export_solid_model( DLIList<TopologyBridge*>& bridge_list, @@ -386,7 +387,8 @@ CubitBoolean import_surfaces = CUBIT_TRUE, CubitBoolean import_curves = CUBIT_TRUE, CubitBoolean import_vertices = CUBIT_TRUE, - CubitBoolean free_surfaces = CUBIT_TRUE ); + CubitBoolean free_surfaces = CUBIT_TRUE, + const char* unit = NULL ); virtual CubitStatus import_solid_model(DLIList<TopologyBridge*> &imported_entities, const char* pBuffer,

1 0

r5330 - cgm/trunk/geom/facet
by jiangtao_ma＠yahoo.com 20 Jan '12

20 Jan '12

Author: janehu Date: 2012-01-20 14:42:35 -0600 (Fri, 20 Jan 2012) New Revision: 5330 Modified: cgm/trunk/geom/facet/FacetQueryEngine.cpp cgm/trunk/geom/facet/FacetQueryEngine.hpp Log: Added unit parameter for import/export functions for iges files in OCC engine cgm. Passed cgm/test make check. Modified: cgm/trunk/geom/facet/FacetQueryEngine.cpp =================================================================== --- cgm/trunk/geom/facet/FacetQueryEngine.cpp 2012-01-20 20:42:19 UTC (rev 5329) +++ cgm/trunk/geom/facet/FacetQueryEngine.cpp 2012-01-20 20:42:35 UTC (rev 5330) @@ -702,6 +702,7 @@ const char* file_name, const char* file_type, const CubitString &, + const char*, const char*) { if( strcmp( file_type, "FACET" ) ) @@ -1751,7 +1752,8 @@ CubitBoolean import_surfaces, CubitBoolean import_curves, CubitBoolean import_vertices, - CubitBoolean free_surfaces) + CubitBoolean free_surfaces, + const char* unit) //not used { errno = 0; FILE *file_ptr = fopen(file_name, "rb"); Modified: cgm/trunk/geom/facet/FacetQueryEngine.hpp =================================================================== --- cgm/trunk/geom/facet/FacetQueryEngine.hpp 2012-01-20 20:42:19 UTC (rev 5329) +++ cgm/trunk/geom/facet/FacetQueryEngine.hpp 2012-01-20 20:42:35 UTC (rev 5330) @@ -249,6 +249,7 @@ const char* file_name, const char* file_type, const CubitString &cubit_version, + const char* unit = NULL, const char* logfile_name = NULL ); virtual CubitStatus export_solid_model( DLIList<TopologyBridge*>& bridge_list, @@ -277,7 +278,9 @@ CubitBoolean import_surfaces = CUBIT_TRUE, CubitBoolean import_curves = CUBIT_TRUE, CubitBoolean import_vertices = CUBIT_TRUE, - CubitBoolean free_surfaces = CUBIT_TRUE ); + CubitBoolean free_surfaces = CUBIT_TRUE, + const char* unit = NULL + ); virtual CubitStatus import_solid_model(DLIList<TopologyBridge*> &imported_entities, const char* pBuffer,

1 0

r5329 - cgm/trunk/geom/ACIS_SRC
by jiangtao_ma＠yahoo.com 20 Jan '12

20 Jan '12

Author: janehu Date: 2012-01-20 14:42:19 -0600 (Fri, 20 Jan 2012) New Revision: 5329 Modified: cgm/trunk/geom/ACIS_SRC/AcisQueryEngine.cpp cgm/trunk/geom/ACIS_SRC/AcisQueryEngine.hpp Log: Added unit parameter for import/export functions for iges files in OCC engine cgm. Passed cgm/test make check. Modified: cgm/trunk/geom/ACIS_SRC/AcisQueryEngine.cpp =================================================================== --- cgm/trunk/geom/ACIS_SRC/AcisQueryEngine.cpp 2012-01-20 20:41:45 UTC (rev 5328) +++ cgm/trunk/geom/ACIS_SRC/AcisQueryEngine.cpp 2012-01-20 20:42:19 UTC (rev 5329) @@ -340,6 +340,7 @@ const char* filename, const char* filetype, const CubitString &cubit_version, + const char* unit, const char* logfile_name) { // Check to make sure we are exporting valid types @@ -882,7 +883,8 @@ CubitBoolean import_surfaces, CubitBoolean import_curves, CubitBoolean import_vertices, - CubitBoolean free_surfaces) + CubitBoolean free_surfaces, + const char* unit) //not used here { CpuTimer import_solid_model_timer; CubitBoolean step_import = CUBIT_FALSE; Modified: cgm/trunk/geom/ACIS_SRC/AcisQueryEngine.hpp =================================================================== --- cgm/trunk/geom/ACIS_SRC/AcisQueryEngine.hpp 2012-01-20 20:41:45 UTC (rev 5328) +++ cgm/trunk/geom/ACIS_SRC/AcisQueryEngine.hpp 2012-01-20 20:42:19 UTC (rev 5329) @@ -178,6 +178,7 @@ const char* file_name, const char* file_type, const CubitString &cubit_version, + const char* unit = NULL, const char* logfile_name = NULL ) ; //R CubitStatus //R- CUBIT_SUCCESS/CUBIT_FAILURE @@ -232,7 +233,8 @@ CubitBoolean import_surfaces = CUBIT_TRUE, CubitBoolean import_curves = CUBIT_TRUE, CubitBoolean import_vertices = CUBIT_TRUE, - CubitBoolean free_surfaces = CUBIT_TRUE ) ; + CubitBoolean free_surfaces = CUBIT_TRUE , + const char* unit = NULL); //R CubitStatus //R- CUBIT_SUCCESS/CUBIT_FAILURE //I file_ptr

1 0

r5328 - cgm/trunk/geom
by jiangtao_ma＠yahoo.com 20 Jan '12

20 Jan '12

Author: janehu Date: 2012-01-20 14:41:45 -0600 (Fri, 20 Jan 2012) New Revision: 5328 Modified: cgm/trunk/geom/CubitCompat.cpp cgm/trunk/geom/CubitCompat.hpp cgm/trunk/geom/GeometryQueryTool.hpp Log: Added unit parameter for import/export functions for iges files in OCC engine cgm. Passed cgm/test make check. Modified: cgm/trunk/geom/CubitCompat.cpp =================================================================== --- cgm/trunk/geom/CubitCompat.cpp 2012-01-20 20:38:34 UTC (rev 5327) +++ cgm/trunk/geom/CubitCompat.cpp 2012-01-20 20:41:45 UTC (rev 5328) @@ -49,6 +49,7 @@ CubitCompat_import_solid_model( const char* file_name, const char* file_type, const char* logfile_name, + const char* unit, CubitBoolean heal_step, CubitBoolean import_bodies, CubitBoolean import_surfaces, @@ -70,9 +71,9 @@ free_surfaces, merge_globally, no_assembly_level_features, - logfile_name ? logfile_name : "" }; + logfile_name ? logfile_name : ""}; #else - #define CubitCompat_opts logfile_name, heal_step, \ + #define CubitCompat_opts logfile_name, unit ? unit : "", heal_step, \ import_bodies, import_surfaces, \ import_curves, import_vertices, \ free_surfaces @@ -91,7 +92,8 @@ const char * filetype, int &num_ents_exported, const CubitString &cubit_version, - const char* logfile_name ) + const char* logfile_name, + const char* unit ) { return GeometryQueryTool::instance()->export_solid_model( ref_entity_list, @@ -99,5 +101,6 @@ CubitCompat_file_type(filetype), num_ents_exported, cubit_version, - logfile_name ); + logfile_name, + unit ); } Modified: cgm/trunk/geom/CubitCompat.hpp =================================================================== --- cgm/trunk/geom/CubitCompat.hpp 2012-01-20 20:38:34 UTC (rev 5327) +++ cgm/trunk/geom/CubitCompat.hpp 2012-01-20 20:41:45 UTC (rev 5328) @@ -11,6 +11,7 @@ CubitCompat_import_solid_model( const char* file_name, const char* file_type, const char* logfile_name = NULL,

1 0

r5327 - cgm/trunk/test
by jiangtao_ma＠yahoo.com 20 Jan '12

20 Jan '12

Author: janehu Date: 2012-01-20 14:38:34 -0600 (Fri, 20 Jan 2012) New Revision: 5327 Added: cgm/trunk/test/cduct.igs Modified: cgm/trunk/test/Makefile.am cgm/trunk/test/merge_test.cpp cgm/trunk/test/r_w.cpp Log: Added testcase for import/export iges files with different unit than millimeter. Modified: cgm/trunk/test/Makefile.am =================================================================== --- cgm/trunk/test/Makefile.am 2012-01-20 14:24:05 UTC (rev 5326) +++ cgm/trunk/test/Makefile.am 2012-01-20 20:38:34 UTC (rev 5327) @@ -145,6 +145,9 @@ bricks2.occ \ bricks22.occ \ bricks23.occ \ + cduct_exp.iges \ + diffuser_exp.iges \ + diffuser.occ \ mmgr.log Added: cgm/trunk/test/cduct.igs =================================================================== --- cgm/trunk/test/cduct.igs (rev 0) +++ cgm/trunk/test/cduct.igs 2012-01-20 20:38:34 UTC (rev 5327) @@ -0,0 +1,1217 @@ +Data from Parasolid IGES Translator, Copyright (c) 2006 UGS Corp. All RS 1 +ights Reserved. S 2 +1H,,1H;,6HNoname,9Hcduct.igs,13H By UGS Corp.,22HXPlus GENERIC/IGES 3.0,G 1 +32,38, 6,308,15,6HNoname,1.000,6,1HM,1,1.000,15H20120116.155256,1.0e-08,G 2 +0.00,6HNoname,6HNoname,11,0,15H20120116.155256; G 3 + 128 1 0 1 0 0 0 000010001D 1 + 128 1 0 148 0 0 0 0D 2 + 126 149 0 1 0 0 0 000010501D 3 + 126 1 0 2 0 0 0 0D 4 + 126 151 0 1 0 0 0 000010501D 5 + 126 1 0 2 0 0 0 0D 6 + 126 153 0 1 0 0 0 000010501D 7 + 126 1 0 2 0 0 0 0D 8 + 126 155 0 1 0 0 0 000010501D 9 + 126 1 0 2 0 0 0 0D 10 + 102 157 0 1 0 0 0 000010501D 11 + 102 1 0 1 0 0 0 0D 12 + 126 158 0 1 0 0 0 000010001D 13 + 126 1 0 2 0 0 0 0D 14 + 126 160 0 1 0 0 0 000010001D 15 + 126 1 0 43 0 0 0 0D 16 + 126 203 0 1 0 0 0 000010001D 17 + 126 1 0 2 0 0 0 0D 18 + 126 205 0 1 0 0 0 000010001D 19 + 126 1 0 43 0 0 0 0D 20 + 102 248 0 1 0 0 0 000010001D 21 + 102 1 0 1 0 0 0 0D 22 + 142 249 0 1 0 0 0 000010001D 23 + 142 1 0 1 0 0 0 0D 24 + 144 250 0 1 0 0 0 000000001D 25 + 144 1 0 1 0 0 0 0D 26

1 0

Re: [cgma-dev] question about iges format (to Jane)
by Jane Hu 20 Jan '12

20 Jan '12

On Fri, Jan 20, 2012 at 10:02 AM, Iulian Grindeanu <iulian(a)mcs.anl.gov>wrote: > > > ------------------------------ > > > > I'd think for now, without any GUI connected, the best way is to add in > the iGeom_load function, an unit option in the 'options' which indicate the > unit (Acis will ignore this). This way users of cgm on OCC will have the > control. I'll implement this way then. > > Jane > > Thanks Jane, > I think this is a good solution. So the option will be used only when CGM > is built with OCC? > Yes, all geometry engine will have this unit argument for importing and exporting, just cgm_OCC will actually use this argument. Jane There is still the problem with faceting in MOAB, maybe there is an option > to pass that option from MOAB to CGM loading. Does anybody know? > > Best Regards, > Iulian > >

1 0

Re: [cgma-dev] question about iges format (to Jane)
by Iulian Grindeanu 20 Jan '12

20 Jan '12

----- Original Message ----- | I'd think for now, without any GUI connected, the best way is to add | in the iGeom_load function, an unit option in the 'options' which | indicate the unit (Acis will ignore this). This way users of cgm on | OCC will have the control. I'll implement this way then. | Jane Thanks Jane, I think this is a good solution. So the option will be used only when CGM is built with OCC? There is still the problem with faceting in MOAB, maybe there is an option to pass that option from MOAB to CGM loading. Does anybody know? Best Regards, Iulian

1 0

Re: [cgma-dev] question about iges format (to Jane)
by Jane Hu 20 Jan '12

20 Jan '12

On Wed, Jan 18, 2012 at 9:25 PM, Iulian Grindeanu <iulian(a)mcs.anl.gov>wrote: > Thanks Jane, > It is not urgent from my point of view. > It is better to have a well thought solution. > Are there other geometry formats that have the unit embedded? > I didn't pay a lot attention on this before, but as you said, software usually doesn't support finding the units and do the conversions. Every software has it's own default length unit. When reading the the file, usually only the numbers matter. 'Unit' in commercial softwares is working in this way: Different global unit can be given by users through GUI, and was saved as a static in the code. Here for iges, xstep.cascade.unit is the global static. In cgm, code should just check this static, which is just one call. And use it to read the files. Should we maybe establish an option, for iGeom load file, that will allow > for a conversion (as a last resort?) > I'd think for now, without any GUI connected, the best way is to add in the iGeom_load function, an unit option in the 'options' which indicate the unit (Acis will ignore this). This way users of cgm on OCC will have the control. I'll implement this way then. Jane In general, I don't think we "support" unit conversion anywhere. > > > It is a complicated process, in general, although for geometry / mesh > generation point of view, only length units are needed. > > Thanks, > Iulian > ------------------------------ > > > > --- On *Wed, 1/18/12, Iulian Grindeanu <iulian(a)mcs.anl.gov>* wrote: > > > From: Iulian Grindeanu <iulian(a)mcs.anl.gov> > Subject: Re: [cgma-dev] question about iges format (to Jane) > To: "Jane Hu" <janejhu(a)gmail.com> > Cc: "jiangtao ma" <jiangtao_ma(a)yahoo.com>, "CGMA Development" < > cgma-dev(a)mcs.anl.gov> > Date: Wednesday, January 18, 2012, 2:06 PM > > Hi Jane, > Thank you for looking into this. > So I verified that with this fix, the output coordinates in testgeom_occ > are the same with the one from testgeom. > This is "hardcoded", so all iges files read by occ will be "converted" to > M. > That's why I haven't checked in the code yet. > > What field in igs file shows that the unit is M? Or is MM? I am still > confused who does the conversion to MM, OCC igs reader ? > In the iges file first several lines, with a 'G' in the 73th column, you > can find a 1HM, which shows the unit is one charactor 'M', if it's MM, > it'll be 2HMM. The conversion to MM is done in Opencascade reader, we need > to set up the global unit outside it to prevent the conversion in this > case. > > What I need to do is to add code in cgm to read iges/step file about the > unit, and assign it to the reader, so it won't be hard coded to M. > > I may take tomorrow off since I agreed to give a talk to my son's > preschool about Chinese New Year, I'll try to fix it as soon as possible. > > Jane > > Anyway, this has implications for MOAB too. With the current code, moab > will convert the igs file to a faceted model, and in case of OCC it takes > forever to facet (I think we have a unit issue there, as we use an absolute > value for facet size, not a relative size of model) > > I mean, if you do "mbsize cducts.igs" for mbsize built with OCC, it will > not finish in more than 3 minutes I waited (I had to kill the process). I > need to try after this fix. > While mbsize cducts.igs for moab built with cubit, finishes almost > instantly. > > Again, mbsize <>.igs will do a faceting of geometry first, then will > output the size of the (faceted) mesh. > > Thanks, > Iulian > > ------------------------------ > > I need to code for reading the unit of iges, and set up the unit in the > cgm. > > For now, if you already knows the unit of the iges files, here is meter, > then just add the following lines to OCCQueryEngine.cpp should work. Please > let me know if it temporarily solves your problem. > > --- OCCQueryEngine.cpp (revision 5293) > +++ OCCQueryEngine.cpp (working copy) > @@ -32,6 +32,7 @@ > #include "gp_Ax2.hxx" > #include "Geom_Surface.hxx" > #include "Geom_Curve.hxx" > +#include "Interface_Static.hxx" > #include "BRepBuilderAPI.hxx" > #include "BRepBuilderAPI_Transform.hxx" > #include "BRepBuilderAPI_GTransform.hxx" > @@ -1491,6 +1492,9 @@ > else if(strcmp(file_type, "IGES") == 0) > { > IGESControl_Reader reader; > + char* name = "xstep.cascade.unit"; > + char* val = "M"; > + Interface_Static::SetCVal (name, val); > const Standard_CString string1 = file_name; > IFSelect_ReturnStatus stat = reader.ReadFile( string1); > if (stat != IFSelect_RetDone) > > Thanks. > > Jane > > > On Wed, Jan 18, 2012 at 10:21 AM, Jane Hu <janejhu(a)gmail.com<http://us.mc1616.mail.yahoo.com/mc/[email protected]> > > wrote: > > Hi, Iulian, > > Opencascade internally assumes that OCC models are measured in > millimeters, so if the model is given in unit M (meter), it'll be changed > to 1000times larger and uses MM(millimeter) in OCC. I am now checking on > the code, and see if we can do something on it. > > Jane > > > On Wed, Jan 18, 2012 at 9:14 AM, Iulian Grindeanu <iulian(a)mcs.anl.gov<http://us.mc1616.mail.yahoo.com/mc/[email protected]> > > wrote: > > Hi Jane, > Dan Le found this problem with respect to igs reader: > Please see the attached files. > testgeom.cc is a version of CGM/itaps/testgeom.cc file, which also prints > the coordinates of all the vertices from the model. > iges format is supported by OCC and Acis/cubit engines. > Still, the coordinates of the vertices are 1000 larger when occ is used. > So if you run this test > testgeom cduct.igs > in Cubit based cgm or > testgeom_occ cduct.igs > in OCC based cgm, > you get different results (1000 times bigger in occ case). It seems that > in cubit case, we do a conversion to sat format, first. > > ITAPS GEOMETRY INTERFACE TEST PROGRAM: > > gLoad: Reading STEP/IGES file > '/home/iulian/tmp/test_lorenzo/cduct.igs'... > Model conversion succeeded: /tmp/CBT.Hoo5yc.sat > Read 6 ACIS Entities from the input file > > > Constructed 6 Volumes: 1 to 6 > Model contents: > vertices: 24 > edges: 24 > faces: 6 > regions: 6 > vertex index 0 : 0 0 0 > vertex index 1 : 0 1 0 > vertex index 2 : 10.5 15 0 > vertex index 3 : 11.5 15 0 > ... > > testgeom_occ cduct.igs > Geometry engine set to: OpenCascade 6.3 > > > ITAPS GEOMETRY INTERFACE TEST PROGRAM: > > gLoad: Total number of loaded entities : 78. > > Constructed 6 Volumes: 1 to 6 > Model contents: > vertices: 24 > edges: 24 > faces: 6 > regions: 6 > vertex index 0 : 0 0 0 > vertex index 1 : 0 1000 0 > vertex index 2 : 10500 15000 0 > vertex index 3 : 11500 15000 0 > ... > > > > Can you please tell me what we should do to get similar results ? > > Thanks, > Iulian > > > > > >

1 0

Re: [cgma-dev] question about iges format (to Jane)
by Iulian Grindeanu 18 Jan '12

18 Jan '12

Thanks Jane, It is not urgent from my point of view. It is better to have a well thought solution. Are there other geometry formats that have the unit embedded? Should we maybe establish an option, for iGeom load file, that will allow for a conversion (as a last resort?) In general, I don't think we "support" unit conversion anywhere. It is a complicated process, in general, although for geometry / mesh generation point of view, only length units are needed. Thanks, Iulian ----- Original Message ----- | --- On Wed, 1/18/12, Iulian Grindeanu <iulian(a)mcs.anl.gov> wrote: | | From: Iulian Grindeanu <iulian(a)mcs.anl.gov> | | Subject: Re: [cgma-dev] question about iges format (to Jane) | | To: "Jane Hu" <janejhu(a)gmail.com> | | Cc: "jiangtao ma" <jiangtao_ma(a)yahoo.com>, "CGMA Development" | | <cgma-dev(a)mcs.anl.gov> | | Date: Wednesday, January 18, 2012, 2:06 PM | | Hi Jane, | | Thank you for looking into this. | | So I verified that with this fix, the output coordinates in | | testgeom_occ are the same with the one from testgeom. | | This is "hardcoded", so all iges files read by occ will be | | "converted" | | to M. | | That's why I haven't checked in the code yet. | | What field in igs file shows that the unit is M? Or is MM? I am | | still | | confused who does the conversion to MM, OCC igs reader ? | | In the iges file first several lines, with a 'G' in the 73th column, | | you can find a 1HM, which shows the unit is one charactor 'M', if | | it's | | MM, it'll be 2HMM. The conversion to MM is done in Opencascade | | reader, | | we need to set up the global unit outside it to prevent the | | conversion | | in this case. | | What I need to do is to add code in cgm to read iges/step file about | | the unit, and assign it to the reader, so it won't be hard coded to | | M. | | I may take tomorrow off since I agreed to give a talk to my son's | | preschool about Chinese New Year, I'll try to fix it as soon as | | possible. | | Jane | | Anyway, this has implications for MOAB too. With the current code, | | moab will convert the igs file to a faceted model, and in case of | | OCC | | it takes forever to facet (I think we have a unit issue there, as we | | use an absolute value for facet size, not a relative size of model) | | I mean, if you do "mbsize cducts.igs" for mbsize built with OCC, it | | will not finish in more than 3 minutes I waited (I had to kill the | | process). I need to try after this fix. | | While mbsize cducts.igs for moab built with cubit, finishes almost | | instantly. | | Again, mbsize <>.igs will do a faceting of geometry first, then will | | output the size of the (faceted) mesh. | | Thanks, | | Iulian | | | I need to code for reading the unit of iges, and set up the unit | | | in | | | the cgm. | | | For now, if you already knows the unit of the iges files, here is | | | meter, then just add the following lines to OCCQueryEngine.cpp | | | should | | | work. Please let me know if it temporarily solves your problem. | | | --- OCCQueryEngine.cpp (revision 5293) | | | +++ OCCQueryEngine.cpp (working copy) | | | @@ -32,6 +32,7 @@ | | | #include "gp_Ax2.hxx" | | | #include "Geom_Surface.hxx" | | | #include "Geom_Curve.hxx" | | | +#include "Interface_Static.hxx" | | | #include "BRepBuilderAPI.hxx" | | | #include "BRepBuilderAPI_Transform.hxx" | | | #include "BRepBuilderAPI_GTransform.hxx" | | | @@ -1491,6 +1492,9 @@ | | | else if(strcmp(file_type, "IGES") == 0) | | | { | | | IGESControl_Reader reader; | | | + char* name = "xstep.cascade.unit"; | | | + char* val = "M"; | | | + Interface_Static::SetCVal (name, val); | | | const Standard_CString string1 = file_name; | | | IFSelect_ReturnStatus stat = reader.ReadFile( string1); | | | if (stat != IFSelect_RetDone) | | | Thanks. | | | Jane | | | On Wed, Jan 18, 2012 at 10:21 AM, Jane Hu < janejhu(a)gmail.com > | | | wrote: | | | | Hi, Iulian, | | | | Opencascade internally assumes that OCC models are measured in | | | | millimeters, so if the model is given in unit M (meter), it'll | | | | be | | | | changed to 1000times larger and uses MM(millimeter) in OCC. I am | | | | now | | | | checking on the code, and see if we can do something on it. | | | | Jane | | | | On Wed, Jan 18, 2012 at 9:14 AM, Iulian Grindeanu < | | | | iulian(a)mcs.anl.gov | | | | > wrote: | | | | | Hi Jane, | | | | | Dan Le found this problem with respect to igs reader: | | | | | Please see the attached files. | | | | | testgeom.cc is a version of CGM/itaps/testgeom.cc file, which | | | | | also | | | | | prints the coordinates of all the vertices from the model. | | | | | iges format is supported by OCC and Acis/cubit engines. | | | | | Still, the coordinates of the vertices are 1000 larger when | | | | | occ | | | | | is | | | | | used. | | | | | So if you run this test | | | | | testgeom cduct.igs | | | | | in Cubit based cgm or | | | | | testgeom_occ cduct.igs | | | | | in OCC based cgm, | | | | | you get different results (1000 times bigger in occ case). It | | | | | seems | | | | | that in cubit case, we do a conversion to sat format, first. | | | | | ITAPS GEOMETRY INTERFACE TEST PROGRAM: | | | | | gLoad: Reading STEP/IGES file | | | | | '/home/iulian/tmp/test_lorenzo/cduct.igs'... | | | | | Model conversion succeeded: /tmp/CBT.Hoo5yc.sat | | | | | Read 6 ACIS Entities from the input file | | | | | Constructed 6 Volumes: 1 to 6 | | | | | Model contents: | | | | | vertices: 24 | | | | | edges: 24 | | | | | faces: 6 | | | | | regions: 6 | | | | | vertex index 0 : 0 0 0 | | | | | vertex index 1 : 0 1 0 | | | | | vertex index 2 : 10.5 15 0 | | | | | vertex index 3 : 11.5 15 0 | | | | | ... | | | | | testgeom_occ cduct.igs | | | | | Geometry engine set to: OpenCascade 6.3 | | | | | ITAPS GEOMETRY INTERFACE TEST PROGRAM: | | | | | gLoad: Total number of loaded entities : 78. | | | | | Constructed 6 Volumes: 1 to 6 | | | | | Model contents: | | | | | vertices: 24 | | | | | edges: 24 | | | | | faces: 6 | | | | | regions: 6 | | | | | vertex index 0 : 0 0 0 | | | | | vertex index 1 : 0 1000 0 | | | | | vertex index 2 : 10500 15000 0 | | | | | vertex index 3 : 11500 15000 0 | | | | | ... | | | | | Can you please tell me what we should do to get similar | | | | | results | | | | | ? | | | | | Thanks, | | | | | Iulian

1 0

Re: [cgma-dev] question about iges format (to Jane)
by Jiangtao Hu 18 Jan '12

18 Jan '12

--- On Wed, 1/18/12, Iulian Grindeanu <iulian(a)mcs.anl.gov> wrote: From: Iulian Grindeanu <iulian(a)mcs.anl.gov> Subject: Re: [cgma-dev] question about iges format (to Jane) To: "Jane Hu" <janejhu(a)gmail.com> Cc: "jiangtao ma" <jiangtao_ma(a)yahoo.com>, "CGMA Development" <cgma-dev(a)mcs.anl.gov> Date: Wednesday, January 18, 2012, 2:06 PM #yiv1031861050 p {margin:0;} Hi Jane, Thank you for looking into this. So I verified that with this fix, the output coordinates in testgeom_occ are the same with the one from testgeom. This is "hardcoded", so all iges files read by occ will be "converted" to M. That's why I haven't checked in the code yet. What field in igs file shows that the unit is M? Or is MM? I am still confused who does the conversion to MM, OCC igs reader ? In the iges file first several lines, with a 'G' in the 73th column, you can find a 1HM, which shows the unit is one charactor 'M', if it's MM, it'll be 2HMM. The conversion to MM is done in Opencascade reader, we need to set up the global unit outside it to prevent the conversion in this case. What I need to do is to add code in cgm to read iges/step file about the unit, and assign it to the reader, so it won't be hard coded to M. I may take tomorrow off since I agreed to give a talk to my son's preschool about Chinese New Year, I'll try to fix it as soon as possible. Jane Anyway, this has implications for MOAB too. With the current code, moab will convert the igs file to a faceted model, and in case of OCC it takes forever to facet (I think we have a unit issue there, as we use an absolute value for facet size, not a relative size of model) I mean, if you do "mbsize cducts.igs" for mbsize built with OCC, it will not finish in more than 3 minutes I waited (I had to kill the process). I need to try after this fix. While mbsize cducts.igs for moab built with cubit, finishes almost instantly. Again, mbsize <>.igs will do a faceting of geometry first, then will output the size of the (faceted) mesh. Thanks, Iulian I need to code for reading the unit of iges, and set up the unit in the cgm. For now, if you already knows the unit of the iges files, here is meter, then just add the following lines to OCCQueryEngine.cpp should work. Please let me know if it temporarily solves your problem. --- OCCQueryEngine.cpp (revision 5293) +++ OCCQueryEngine.cpp (working copy) @@ -32,6 +32,7 @@ #include "gp_Ax2.hxx" #include "Geom_Surface.hxx" #include "Geom_Curve.hxx" +#include "Interface_Static.hxx" #include "BRepBuilderAPI.hxx" #include "BRepBuilderAPI_Transform.hxx" #include "BRepBuilderAPI_GTransform.hxx" @@ -1491,6 +1492,9 @@ else if(strcmp(file_type, "IGES") == 0) { IGESControl_Reader reader; + char* name = "xstep.cascade.unit"; + char* val = "M"; + Interface_Static::SetCVal (name, val); const Standard_CString string1 = file_name; IFSelect_ReturnStatus stat = reader.ReadFile( string1); if (stat != IFSelect_RetDone) Thanks. Jane On Wed, Jan 18, 2012 at 10:21 AM, Jane Hu <janejhu(a)gmail.com> wrote: Hi, Iulian, Opencascade internally assumes that OCC models are measured in millimeters, so if the model is given in unit M (meter), it'll be changed to 1000times larger and uses MM(millimeter) in OCC. I am now checking on the code, and see if we can do something on it. Jane On Wed, Jan 18, 2012 at 9:14 AM, Iulian Grindeanu <iulian(a)mcs.anl.gov> wrote: Hi Jane, Dan Le found this problem with respect to igs reader: Please see the attached files. testgeom.cc is a version of CGM/itaps/testgeom.cc file, which also prints the coordinates of all the vertices from the model. iges format is supported by OCC and Acis/cubit engines. Still, the coordinates of the vertices are 1000 larger when occ is used. So if you run this test testgeom cduct.igs in Cubit based cgm or testgeom_occ cduct.igs in OCC based cgm, you get different results (1000 times bigger in occ case). It seems that in cubit case, we do a conversion to sat format, first. ITAPS GEOMETRY INTERFACE TEST PROGRAM: gLoad: Reading STEP/IGES file '/home/iulian/tmp/test_lorenzo/cduct.igs'... Model conversion succeeded: /tmp/CBT.Hoo5yc.sat Read 6 ACIS Entities from the input file Constructed 6 Volumes: 1 to 6 Model contents: vertices: 24 edges: 24 faces: 6 regions: 6 vertex index 0 : 0 0 0 vertex index 1 : 0 1 0 vertex index 2 : 10.5 15 0 vertex index 3 : 11.5 15 0 ... testgeom_occ cduct.igs Geometry engine set to: OpenCascade 6.3 ITAPS GEOMETRY INTERFACE TEST PROGRAM: gLoad: Total number of loaded entities : 78. Constructed 6 Volumes: 1 to 6 Model contents: vertices: 24 edges: 24 faces: 6 regions: 6 vertex index 0 : 0 0 0 vertex index 1 : 0 1000 0 vertex index 2 : 10500 15000 0 vertex index 3 : 11500 15000 0 ... Can you please tell me what we should do to get similar results ? Thanks, Iulian

1 0